From d24e6ce616f341f1dfa12c53f167d50a0f5531c9 Mon Sep 17 00:00:00 2001 From: Kenjiro Nakayama Date: Mon, 2 Nov 2020 23:23:36 +0900 Subject: [PATCH] Bump kubernetes minimum version to v1.17.0 (#1880) * Bump kubernetes minimum version to v1.17.0 This patch bumps up defaultMinimumVersion to v1.17.0 As per https://github.com/knative/community/issues/245#issuecomment-718316003, v0.19(next release)'s minimum version is v1.17. * Fix unit test --- version/version.go | 2 +- version/version_test.go | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/version/version.go b/version/version.go index f78014630..0f2ca7e03 100644 --- a/version/version.go +++ b/version/version.go @@ -30,7 +30,7 @@ const ( // the Kubernetes minimum version required by Knative. KubernetesMinVersionKey = "KUBERNETES_MIN_VERSION" - defaultMinimumVersion = "v1.16.0" + defaultMinimumVersion = "v1.17.0" ) func getMinimumVersion() string { diff --git a/version/version_test.go b/version/version_test.go index 5baa49312..9037f8e7f 100644 --- a/version/version_test.go +++ b/version/version_test.go @@ -41,16 +41,16 @@ func TestVersionCheck(t *testing.T) { wantError bool }{{ name: "greater version (patch)", - actualVersion: &testVersioner{version: "v1.16.2"}, + actualVersion: &testVersioner{version: "v1.17.2"}, }, { name: "greater version (minor)", - actualVersion: &testVersioner{version: "v1.17.0"}, + actualVersion: &testVersioner{version: "v1.18.0"}, }, { name: "same version", - actualVersion: &testVersioner{version: "v1.16.0"}, + actualVersion: &testVersioner{version: "v1.17.0"}, }, { name: "same version with build", - actualVersion: &testVersioner{version: "v1.16.0+k3s.1"}, + actualVersion: &testVersioner{version: "v1.17.0+k3s.1"}, }, { name: "smaller version", actualVersion: &testVersioner{version: "v1.14.3"},