From d5db385fccd5b4477626148f48a47de1d5ae1d34 Mon Sep 17 00:00:00 2001 From: Thomas Shafer Date: Fri, 5 Apr 2019 08:52:57 -0700 Subject: [PATCH] Address some lint errors (#351) * Fix lint error: Remove unused receiver name * Fix lint error: consistent receiver name * Update apis/duck/v1alpha1/conditions_types.go Update apis/duck/v1alpha1/retired_targetable_types.go Update apis/duck/v1alpha1/legacy_targetable_types.go Co-Authored-By: trshafer --- apis/duck/patch_test.go | 4 ++-- apis/duck/v1alpha1/addressable_types.go | 4 ++-- apis/duck/v1alpha1/conditions_types.go | 4 ++-- apis/duck/v1alpha1/legacy_targetable_types.go | 4 ++-- apis/duck/v1alpha1/retired_targetable_types.go | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/apis/duck/patch_test.go b/apis/duck/patch_test.go index d63cbd5fe..97dc2c217 100644 --- a/apis/duck/patch_test.go +++ b/apis/duck/patch_test.go @@ -250,7 +250,7 @@ type DoesntMarshal struct{} var _ json.Marshaler = (*DoesntMarshal)(nil) -func (_ *DoesntMarshal) MarshalJSON() ([]byte, error) { +func (*DoesntMarshal) MarshalJSON() ([]byte, error) { return nil, errors.New("what did you expect?") } @@ -270,7 +270,7 @@ type PatchSpec struct { var _ Implementable = (*Patchable)(nil) var _ Populatable = (*Patch)(nil) -func (_ *Patchable) GetFullType() Populatable { +func (*Patchable) GetFullType() Populatable { return &Patch{} } diff --git a/apis/duck/v1alpha1/addressable_types.go b/apis/duck/v1alpha1/addressable_types.go index bc7917975..12b630616 100644 --- a/apis/duck/v1alpha1/addressable_types.go +++ b/apis/duck/v1alpha1/addressable_types.go @@ -65,7 +65,7 @@ var _ duck.Populatable = (*AddressableType)(nil) var _ apis.Listable = (*AddressableType)(nil) // GetFullType implements duck.Implementable -func (_ *Addressable) GetFullType() duck.Populatable { +func (*Addressable) GetFullType() duck.Populatable { return &AddressableType{} } @@ -80,7 +80,7 @@ func (t *AddressableType) Populate() { } // GetListType implements apis.Listable -func (r *AddressableType) GetListType() runtime.Object { +func (*AddressableType) GetListType() runtime.Object { return &AddressableTypeList{} } diff --git a/apis/duck/v1alpha1/conditions_types.go b/apis/duck/v1alpha1/conditions_types.go index 37c54d0b0..b82de3c4c 100644 --- a/apis/duck/v1alpha1/conditions_types.go +++ b/apis/duck/v1alpha1/conditions_types.go @@ -159,7 +159,7 @@ var _ duck.Populatable = (*KResource)(nil) var _ apis.Listable = (*KResource)(nil) // GetFullType implements duck.Implementable -func (_ *Conditions) GetFullType() duck.Populatable { +func (*Conditions) GetFullType() duck.Populatable { return &KResource{} } @@ -187,7 +187,7 @@ func (t *KResource) Populate() { } // GetListType implements apis.Listable -func (r *KResource) GetListType() runtime.Object { +func (*KResource) GetListType() runtime.Object { return &KResourceList{} } diff --git a/apis/duck/v1alpha1/legacy_targetable_types.go b/apis/duck/v1alpha1/legacy_targetable_types.go index 3e13d9eaf..5e4d6f2e3 100644 --- a/apis/duck/v1alpha1/legacy_targetable_types.go +++ b/apis/duck/v1alpha1/legacy_targetable_types.go @@ -67,7 +67,7 @@ var _ duck.Populatable = (*LegacyTarget)(nil) var _ apis.Listable = (*LegacyTarget)(nil) // GetFullType implements duck.Implementable -func (_ *LegacyTargetable) GetFullType() duck.Populatable { +func (*LegacyTargetable) GetFullType() duck.Populatable { return &LegacyTarget{} } @@ -80,7 +80,7 @@ func (t *LegacyTarget) Populate() { } // GetListType implements apis.Listable -func (r *LegacyTarget) GetListType() runtime.Object { +func (*LegacyTarget) GetListType() runtime.Object { return &LegacyTargetList{} } diff --git a/apis/duck/v1alpha1/retired_targetable_types.go b/apis/duck/v1alpha1/retired_targetable_types.go index ab578e523..0e7da480b 100644 --- a/apis/duck/v1alpha1/retired_targetable_types.go +++ b/apis/duck/v1alpha1/retired_targetable_types.go @@ -67,7 +67,7 @@ var _ duck.Populatable = (*Target)(nil) var _ apis.Listable = (*Target)(nil) // GetFullType implements duck.Implementable -func (_ *Targetable) GetFullType() duck.Populatable { +func (*Targetable) GetFullType() duck.Populatable { return &Target{} } @@ -82,7 +82,7 @@ func (t *Target) Populate() { } // GetListType implements apis.Listable -func (r *Target) GetListType() runtime.Object { +func (*Target) GetListType() runtime.Object { return &TargetList{} }