knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove obsolete verbose log message for pre-release (#2235) 

The error was obsoleted by https://github.com/knative/pkg/pull/1944.

As we can see this test case
a70bb26767/version/version_test.go (L68-L71)

pre-release version is __NOT__ smaller than the corresponding release
version anymore.
This commit is contained in:
Kenjiro Nakayama 2021-08-27 00:40:32 +09:00 committed by GitHub
parent a7f5b39b89
commit ddd97e9fb8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
version/version.go
View File

@ -72,10 +72,6 @@ func CheckMinimumVersion(versioner discovery.ServerVersionInterface) error {
// Return error if the current version is less than the minimum version required.
if currentVersion.LT(minimumVersion) {
if len(currentVersion.Pre) > 0 {
return fmt.Errorf("pre-release kubernetes version %q is not compatible, need at least %q (this can be overridden with the env var %q); note pre-release version is smaller than the corresponding release version (e.g. 1.x.y-z < 1.x.y), using 1.x.y-0 as the minimum version is likely to help in this case",
currentVersion, minimumVersion, KubernetesMinVersionKey)
}
return fmt.Errorf("kubernetes version %q is not compatible, need at least %q (this can be overridden with the env var %q)",
currentVersion, minimumVersion, KubernetesMinVersionKey)
}