* expose qp request metrics reporting period
* remove dead link
* add comments
* add default
* fix unit test
* add back the correct url
* use metrics.reporting-period as default
* don't return a pointer
Go 1.17 introduced a new handy API for setting env vars scoped for
a single test so we can avoid the hard to read set and reset env
loops.
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
* drop stack driver as a tracing backend
* drop stackdriver as a metrics backend
* update deps - dropping stackdriver
* fix linting issues
* drop further references to stack driver
* drop serving & eventing metric key constants
these have been moved to their respective repos
see: https://github.com/knative/pkg/issues/608
* move source metrickeys to pkg/source
We're going to move the StatsReporter downstream eventually
related:
https://github.com/knative/eventing/pull/5587https://github.com/knative/eventing/pull/5586
* fix linter
* Add a flag to disable QP profiling.
Turning profiling on or off toggles full rolling restart
of knative pods. And if profiling QP is not of interest, this
might be quite undesireable. To permit that.
* spelling
* Fix the the request logging boolean toggle
Since we have cut the 0.17, we can go for the proper toggle setup:
- if request logging is on — template must be present and the logging will be on
- if the request of logging is off — template can be present, but will not affect whether the request logs will be collected
* review
* 1 moer test
the observability config is used in other packages including
the sample controller. This commit pulls observability config
into knative.dev/pkg similar to logging config for better reusability.
Stavros Kontopoulos
Kenny Leung
Pierangelo Di Pilato
Dave Protasowski
Victor Agababov
Julian Friedman
jjzeng-seattle
Nima Kaviani