Commit Graph

5 Commits

Author SHA1 Message Date
Victor Agababov a371418524
v2 (#1754) 2020-09-29 13:18:29 -07:00
Victor Agababov f1e8ecbf78
Disable GC to reduce test flakiness (#1581)
At least twice I saw this report +1 over what we expect, which I attribute
to actual GC being collected.
E.g. https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/1580/pull-knative-pkg-unit-tests/1290650655098146816
So disable GC for the duration of this test
2020-08-04 12:12:28 -07:00
Victor Agababov 7ea21a17b9
Make sure metrics tests are re-entrant (#1566)
* Make sure metrics tests are re-entrant
Currently they are not. 'go test -count=2' will miserably fail.
So ensure they are. Also add a helper to return current value.

* review
2020-07-28 14:52:59 -07:00
Yanwei Guo 19b1d7b64d
Add a helper func to set a default metric config for unit tests (#1263)
* do not record for empty metric config

* Revert "do not record for empty metric config"

This reverts commit 539a5e4dbb.

* add a comment

* fix typo

* fix tests

* revert

* revert tests

* revert

* fix conflicts

* one more test file
2020-05-07 21:11:45 -07:00
Matt Moore 2e019c8a87 Expose Go memstats as metrics. (#711)
This exposes metrics for the properties available through [here](https://godoc.org/runtime#MemStats) so that we can get some better visibility into things like GC pressure.
2019-09-21 00:07:08 -07:00