Commit Graph

9 Commits

Author SHA1 Message Date
Dave Protasowski 44d1d7d978
Go1.19 changes (#2631)
* run goimports

* ignore linter errors for now

* fix boilerplate
2022-11-03 22:34:05 +00:00
Julian Friedman 50410e0b83
Use consistent case for "Deprecated" comments (#2216)
* Use consistent case for "Deprecated" comments

Not the most important thing ever, but the canonical string to use for
Deprecated warnings is case sensitive, and also it's nice to be
consistent.

* Add nolint comment
2021-08-17 09:15:16 -07:00
Markus Thömmes 980a33719a
Fix revive related linting issues (#2131) 2021-05-26 01:10:28 -07:00
Victor Agababov b558677ab0
Use TB interface, rather than T pointer when doing test stuff (#2064)
* Use TB interface, rather than T pointer when doing test stuff

this will permit passing testing.B everywhere too!

/assign @markusthoemmes @dprotaso

* rm-todo
2021-03-23 13:29:17 -07:00
Adam Harwayne 6074a277ac ConfigOptions return an error (#657)
* ConfigOptions return an error, so we can react to things failing, rather than only reading it in the logs.

* Add unit tests.

* PR comments.

* PR comment - remove TODO.
2019-09-11 08:38:30 -07:00
Matt Moore 2a33038155 Expand the tracing package to support stackdriver. (#582)
* Expand the tracing package to support stackdriver.

This makes an assortment of changes to support the use of non-Zipkin tracing backends for publishing traces from system components based on config-tracing.

The changes to the config are modeled after config-observability, which already has support for prometheus and stackdriver backends for metrics.

* Incorporate review feedback.

* Incorporate feedback from @mdemirhan downstream
2019-08-20 18:52:32 -07:00
Matt Moore 9cc6a64541 Shuffle knative.dev/pkg/tracing code a bit (#581)
This moves around the code within the tracing package in preparation for adding support for other exporter options.

As the fields changed are all private, this should be a no-op for consumers of this package.

The goal of this change is to make it so that no files mention zipkin other than zipkin.go (or tests, which I left alone).
2019-08-19 18:50:02 -07:00
Matt Moore 222dd25986 Migrate pkg to use the knative.dev/pkg import path (#489)
* Manual changes.

* scripted changes.
2019-06-26 13:02:06 -07:00
Akash Verenkar c0f06c32f1 Move serving/pkg/tracing to pkg/tracing, so that eventing can start using it (#407)
* Move serving/pkg/tracing to pkg/tracing - initial version before testing

* Disabling TestInterlevedExporters. Refer to https://github.com/knative/pkg/issues/406
2019-05-08 11:43:37 -07:00