accfe36491
Satisfy linter ( #3132 )
...
* drop deprecated linter
* fix uint64=>int64 overflow
* fix unnecessary fmt.Sprintf
* ignore false positive fatcontext
* fix integer overflows
* update golangci-lint config - properly was moved
* fix formatting calls
* use new integer range syntax
* adjust nolint comments
* stop using deprecated k8s types
2025-01-10 15:06:18 +00:00
ee1db869c7
Update linter config and address lint warnings/failures ( #3068 )
...
* fix whitespace linter
* fix usestdlibvars
* fix staticheck
* ignore spancheck warning
* fix linter perfsprint
* fix nolintlint feedback
* fix nilerr lint checks
* fix misspell
* fix mirror lint
* fix intrange linter
* fix gofumpt linter
* fix gosec linter - ignore warning since default min tls version is 1.3
* fix gocritic linter
* fix whitespace
* fix fatcontext linter
* fix errorlint
* fix errname linter
* fix copyloopvar (go1.22) linter
* fix bodyclose linter
* update linter config
* add script to format code
* fix unit test
2024-06-25 14:49:36 +00:00
9bda38b216
Fix some webhook testing tech debt ( #2751 )
...
* TestRegistrationStopChanFire now uses ephemeral ports
* For TLS servers dial TLS
* have server error logs appear in zap
* log the correct error
* pass ephemeral listeners to the webhook for testing
2023-05-25 14:35:25 +00:00
44d1d7d978
Go1.19 changes ( #2631 )
...
* run goimports
* ignore linter errors for now
* fix boilerplate
2022-11-03 22:34:05 +00:00
3d24b8416b
fix lint warnings ( #2589 )
...
* resolve deprecation warnings
* drop use of ioutil
* fix license
* run hack/update-codegen.sh
2022-09-12 18:15:45 +00:00
a650186419
Make request body available in admission context ( #2583 )
...
* Make request body available in admission context
Signed-off-by: Andrés Torres <andrest@vmware.com>
* Add newline at the end of file
Signed-off-by: Andrés Torres <andrest@vmware.com>
Signed-off-by: Andrés Torres <andrest@vmware.com>
2022-08-26 15:50:19 +00:00
da7191979f
split warnings. Fix issue: 2581 ( #2582 )
...
* split warnings. Fix issue: 2581
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
* Add tests for splits. Simplify.
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
2022-08-23 19:52:18 +00:00
11a3414ec3
Provide the webhook infrastructure with the raw request context. ( #2305 )
...
Today, we can use `Path()` of `/foo/` (trailing slash) to support prefix-matched webhooks, but unfortunately the request context is lost when `Admit()` or `Convert()` is called.
This ensures that information flows through associated with context for anyone who would like this metadata for additional processing.
2021-10-05 13:22:44 -07:00
552bbc1061
Support the webhook serving over non-TLS. ( #2204 )
...
This reworks the way we setup the TLS Config for the webhook, so that when the `opts.SecretName` is omitted we serve over non-TLS.
2021-08-02 20:22:47 -07:00
c367a9d696
Drop Client as it is only used in tests ( #2203 )
2021-07-30 18:05:05 -07:00
7f753ea127
Slash off 5s from TestAdmissionValidResponseForResource ( #2046 )
2021-03-05 09:33:20 -08:00
b39d5da935
Spelling ( #1797 )
...
* spelling: adopted
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: aliased
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: apierrs
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: assignment
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: available
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: coexistence
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: commit
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: conversions
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: creates
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: custom
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: determine
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: different
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: distribution
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: duplicate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: editing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: endpoint
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: environment
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: generate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: implementation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: identified
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: ignore
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: indicates
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interface
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interleaved
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: labels
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: label
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mimic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: namespaced
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: necessary
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: organization
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: populatable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: prometheus
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: refer
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: reference
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: repetitive
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: response
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: something
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: specable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: spoofing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: synchronized
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: this
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: trailing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unsupported
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: validation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* chore: reviewdog go header boilerplate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2020-10-18 14:22:57 -07:00
247841408e
Apply the cleanup to the pkg ( #1776 )
...
* Apply the cleanup to the pkg
This is probably the final iteration of my cleanup application.
* codegen
* one more try
2020-10-05 21:41:20 -07:00
a371418524
v2 ( #1754 )
2020-09-29 13:18:29 -07:00
5be32bbb99
Return TypeMeta as part of the admission response ( #1444 )
2020-06-24 08:54:27 -07:00
caa444033b
use crd & webhook v1 APIs ( #1391 )
2020-06-19 08:43:25 -07:00
19b1d7b64d
Add a helper func to set a default metric config for unit tests ( #1263 )
...
* do not record for empty metric config
* Revert "do not record for empty metric config"
This reverts commit 539a5e4dbb
2020-05-07 21:11:45 -07:00
3506048289
t.Fatal must not be called in a goroutine. ( #1194 )
...
* t.Fatal must not be called in a goroutine.
* Add early return statements.
2020-04-06 08:27:19 -07:00
e2ee5bed78
Start the webhook before informers sync. ( #1180 )
...
* Start the webhook before informers sync.
Some webhooks (e.g. conversion) are required to list resources, so by delaying those until after informers have synced, we create a deadlock when they run in the same process. This change has two key parts:
1. Start the webhook immediately when our process starts, and issue a callback from sharedmain when the informers have synced.
2. Block `Admit` calls until informers have synced (all conversions are exempt), unless they have been designated by implementing `webhook.StatelessAdmissionController`.
Our built-in admission controllers (defaulting, validation, configmap validation) have all been marked as stateless, the main case where we want to block `Admit` calls is when we require the informer to have synchronized to populate indices for Bindings.
* Add missing err declaration
2020-03-30 18:14:50 -07:00
1cc3c3e852
Update jsonpatch lib that correctly handle object removal ( #1078 )
...
* update jsonpatch lib
* add more patch tests for removal
2020-02-12 08:27:22 -08:00
cff115c2dd
Refactor webhook to allow adding conversion support ( #989 )
...
* Refactor webhook to allow adding conversion support
* pr feedback
* fix memory leak
* We can use mux.Handle
* move admission integration tests to separate file
2020-01-20 09:20:05 -08:00
Dave Protasowski
Andrés Torres
Ville Aikas
Matt Moore
Markus Thömmes
Josh Soref
Victor Agababov
Yanwei Guo
Matt Moore
cshou