Commit Graph

6 Commits

Author SHA1 Message Date
Victor Agababov 2465d13e72
Switch bool parsing to the real parser (#1651)
* Switch bool parsing to the real parser

We parse junk as false, but that's not really corect

* fix comment

* 2
2020-08-25 18:35:06 -07:00
Dave Protasowski 20e1d27cd6
add helper to parse namespaced names (#1600)
* add helper to parse namespaced names

* address feedback

* drop comment & re-order checks

* address vagababov feedback

* add optional method and include note about namespace being required
2020-08-10 15:00:05 -07:00
Matt Moore 7df8fc5d77
Implement the first wave of per-reconciler leaderelection. (#1301)
* Implement the first wave of per-reconciler leaderelection.

Detailed design: https://docs.google.com/document/d/1i_QHjQO2T3SNv49xjZLWlivcc0UvZN1Tbw2NKxThkyM/edit#
Issue: https://github.com/knative/pkg/issues/1181

* Feedback from vagababov

* Feedback from yanweiguo

* Drop IsLeaderFor from the LeaderAware interface.

* Moar vagababov nits

* dprotaso feedback

* Add issue comment, error return

* Incorporate dprotaso test feedback
2020-06-18 19:07:25 -07:00
Julian Friedman 6eb9fa1546
Add AsQuantity to configmap parser (#1362) 2020-05-28 10:23:01 -07:00
Markus Thömmes 60f4ae1dbe
Use config map parsing lib and enhance it further. (#1335)
* Use config map parsing lib and enhance it further.

* Unexport test struct values.

* Migrate tracing config too.

* Use sample-rate.
2020-05-18 10:42:06 -07:00
Markus Thömmes a43a1b10f2
Add a library to parse config map values. (#1329)
* Add a library to parse config map values.

* Add AsString and comments.

* Add ParseFunc type.
2020-05-14 09:17:00 -07:00