a2394e8895
Fix produced events if patching a finalizer fails ( #1843 )
2020-10-26 09:05:41 -07:00
b39d5da935
Spelling ( #1797 )
...
* spelling: adopted
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: aliased
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: apierrs
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: assignment
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: available
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: coexistence
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: commit
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: conversions
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: creates
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: custom
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: determine
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: different
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: distribution
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: duplicate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: editing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: endpoint
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: environment
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: generate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: implementation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: identified
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: ignore
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: indicates
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interface
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interleaved
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: labels
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: label
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mimic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: namespaced
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: necessary
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: organization
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: populatable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: prometheus
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: refer
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: reference
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: repetitive
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: response
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: something
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: specable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: spoofing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: synchronized
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: this
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: trailing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unsupported
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: validation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* chore: reviewdog go header boilerplate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2020-10-18 14:22:57 -07:00
1e373a9e5d
take 2 ( #1755 )
2020-09-29 14:10:29 -07:00
5d1dfa9ef7
Improve the logging messages in the reconciler generator. ( #1750 )
...
And other minor nits.
2020-09-28 13:32:28 -07:00
2d4efecc6b
bump to k8s 1.18 ( #1428 )
...
* bump to k8s 1.18.8
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
* plumbing ctx through
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
* add more ctx plumbing
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
* ctx WithCancel()
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
2020-09-11 07:54:00 -07:00
2eaf40292b
don't pre/post process if skipstatusupdate ( #1625 )
2020-08-15 08:51:06 -07:00
3a98b0671c
Have codegen log status diffs at debug level ( #1598 )
...
Fixes: https://github.com/knative/pkg/issues/1597
2020-08-08 11:49:29 -07:00
47e34f1f4e
use const when gen reconciler ( #1568 )
...
* use const when gen reconciler
* move to reconciler common
Signed-off-by: RyderXia <ryder.xia@sap.com>
* update
Signed-off-by: RyderXia <ryder.xia@sap.com>
2020-07-29 14:45:59 -07:00
ae9c3f7fa8
Refactor the genreconciler code to pull state out ( #1544 )
...
* Refactor the genreconciler code to pull state out
* don't generate the stubs
* fix indent
2020-07-22 23:02:57 -07:00
f397d1a271
Propagate SkipStatusUpdates to reconciler from NewReconciler ( #1466 )
2020-07-01 22:59:42 -07:00
cd84a3ec16
Update generated reconciler code with a switch ( #1457 )
...
* Update generated reconciler code with a switch
* flip
* update-codegen
* dont want to warn on equal
2020-07-01 21:31:41 -07:00
a92c682188
Add an option to skip automated status updates in a reconciler. ( #1456 )
...
* Add an option to skip automated status updates in a reconciler.
This option is necessary to be able to create reconcilers like Serving's labeler, that is purely adding labels to resources. If that fails, the new automated observed generation handling changes the status and that gets written to the API currently, which is not desired.
* Flip the bool.
2020-06-30 08:02:29 -07:00
5e60b6f863
Implement the fourth wave of per-reconciler leaderelection. ( #1304 )
...
With this, all downstream `// +genreconciler` reconcilers will become leader-aware and expose a model for the typed reconcilers they wrap to themselves become leader-aware.
Detailed design: https://docs.google.com/document/d/1i_QHjQO2T3SNv49xjZLWlivcc0UvZN1Tbw2NKxThkyM/edit#
Issue: https://github.com/knative/pkg/issues/1181
2020-06-21 18:58:26 -07:00
c365f7d338
Abort reconcilation on finalizer patch errors. ( #1423 )
...
* Abort reconcilation on finalizer patch errors.
This aborts reconcilation if finalizers could not be patched correctly with an error and thus it retries.
We shouldn't start a reconcilation if we haven't been able to correctly add the finalizer first. Otherwise we could get into a weird spot where the resources are created before the finalizer and in a very degenerate case the finalizer wouldn't even be executed. Also, the current code has a bug where if the patch fails the resource coming back from the patch (essentially an empty object) is passed into ReconcileKind, causing headaches.
The same imo goes for removing a finalizer. Failing to remove a finalizer blocks the resource forever, thus we should retry if that happens too.
* Add generated code.
2020-06-19 08:26:25 -07:00
d5043a4332
Groom conditions LastTransitionTime in postprocess ( #1403 )
...
* Groom conditions time
* unit test
* unit test fix
* make readme accurate
2020-06-18 11:46:25 -07:00
2266252575
Prevent nil access when resource is nil ( #1386 )
...
When an error is returned frequently the resource is nil and results in nil.Name being called for the error.
2020-06-06 12:53:18 -07:00
8930ffb535
Fail reconciliation when event is wrapped ( #1289 )
2020-05-08 10:09:45 -07:00
b559da3646
Generate common logic for krshaped resources ( #1311 )
...
* generate krshaped logic
* add logic to the tag
* Update injection/README.md
Co-authored-by: Matt Moore <mattmoor@vmware.com>
* move var to reconciler
Co-authored-by: Matt Moore <mattmoor@vmware.com>
2020-05-08 10:00:45 -07:00
c0dd593d3f
Ensure that all needed imports are tracked in reconciler generator ( #1308 )
2020-05-07 07:07:45 -07:00
31657d4f05
Fix the logging to be a sentence ( #1236 )
...
Also it seems in the test logs this is manifested as 'returned an event' and nothing else...
but I blame it to the testing log configuration, perhaps.
2020-04-23 10:56:31 -07:00
7fbf4b0edc
Add finalizer option and default to test code too. ( #1238 )
2020-04-23 10:02:31 -07:00
6103dd9b71
Add a controller option to specify a custom finalizer name. ( #1230 )
2020-04-22 14:55:40 -07:00
5036c917e5
Drop 'no longer exist' line to DEBUG. ( #1234 )
2020-04-22 07:34:40 -07:00
8a6d25b309
Generate reconcilers for resources out of tree. ( #1175 )
...
* genreconciler:nonNamespaced
* Adding a force-kinds flag to the reconciler generator to allow us to generate reconcilers for non-owned types.
* force-kinds --> force-genreconciler-kinds
* some minor nits with the generators for non-knative types needed to be removed.
* remove whitespace
Co-authored-by: Nacho Cano <nachoacano@gmail.com>
2020-03-25 11:34:51 -07:00
5605ade524
Add filtering to class based controller stubs. ( #1133 )
2020-03-03 12:57:53 -08:00
5d8a01d12c
Implement strongly typed class reconcilers ( #1103 )
...
* Implement strongly typed class reconcilers
* document class filters.
* matt is always right
2020-02-19 08:38:06 -08:00
72f3cd2bbc
[Genreconciler] Fix group names when client groups differ than their directory name. ( #1097 )
...
* looking at annotations for group overrides.
* checkpoint.
* checkpoint
* I think it is correct.
* ok
* trim down the files.
* simulate tekton
* working test out of checkin
* remove test client
* update docs
* and test.
* lint
* it ok
* update codegen
2020-02-18 17:14:59 -08:00
69f70e37d9
adding recorder to context. ( #1096 )
2020-02-14 14:28:41 -08:00
602d92f69b
I screwed up the return for clearFinalizer. ( #1089 )
2020-02-13 08:35:36 -08:00
558f848aa0
[GenRec] Keep resource in sync when setting and removing finalizers. ( #1086 )
...
* Update the resource if it is patched for finalizer mods to let status update work the first try.
* matt does not like extra :
2020-02-12 17:08:36 -08:00
d93ce78496
[Reconciler Generators] Adding support for configStore.ToContext ( #1085 )
...
* Support optional config maps.
* document configmap stores
* whitespace.
* optionsFns
* review
* check for nil.
* zero trust imports.
2020-02-12 16:10:35 -08:00
a5517037d3
set the import for sets ( #1075 )
2020-02-11 07:52:07 -08:00
248c9f0353
fix filtering for reconcilers gen. ( #1071 )
2020-02-11 05:26:07 -08:00
85608a8329
Generate Managed Finalizers for Reconcilers ( #1069 )
...
* fix rando issues
* code in the group for finalizer name.
* Use FinalizeKind
* show the Finalizer interface.
* removing isFinalizing
* sync finalizers before calling reconcilekind
* missed the events change.
2020-02-10 19:46:06 -08:00
b63641488a
fix event recorder ( #1053 )
2020-02-05 13:51:31 -08:00
b9974987c2
Fix issue with returning errors, and not adding scheme ( #1049 )
2020-02-04 18:03:30 -08:00
b317048346
Generate Base Reconciler Code for Injection Based Controllers. ( #947 )
...
* adding a reconciler generator to use as the base reconcilers for all of knative.
* mend
* fix tag names.
* use reconciler events
* trying new thing.
* base working reconciler gen
* working cleaned up reconciler generator.
* fix typo
* fix some ordering.
* fix interface path
* fix whitespace
* update deps.
* updates based on feedback.
* Remove core loop.
* reconcilerImpl
* add NewReconciler
* Fix copyright header
* Comment out finalizers
* remove finalizers from generated code.
2020-02-04 10:23:30 -08:00
Markus Thömmes
Josh Soref
Victor Agababov
Zbynek Roubalik
Weston Haught
Matt Moore
runzexia
Scott Nichols
Thomas Shafer
Antoine Cotten
Ian Milligan
Scott Nichols