ee1db869c7
Update linter config and address lint warnings/failures ( #3068 )
...
* fix whitespace linter
* fix usestdlibvars
* fix staticheck
* ignore spancheck warning
* fix linter perfsprint
* fix nolintlint feedback
* fix nilerr lint checks
* fix misspell
* fix mirror lint
* fix intrange linter
* fix gofumpt linter
* fix gosec linter - ignore warning since default min tls version is 1.3
* fix gocritic linter
* fix whitespace
* fix fatcontext linter
* fix errorlint
* fix errname linter
* fix copyloopvar (go1.22) linter
* fix bodyclose linter
* update linter config
* add script to format code
* fix unit test
2024-06-25 14:49:36 +00:00
8535fcc248
gofumpt the repo ( #3067 )
...
* gofumpt the repo
* don't prefix numbers with 0 - otherwise they're octal
2024-06-25 07:27:07 +00:00
4dbc3122f3
fix boilerplate ( #2753 )
...
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
2023-06-12 15:40:44 +00:00
15605c78a2
Defaulting Controller options for all kind of webhooks ( #2738 )
...
* functional options
* move options to its own package
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
* add controller options to the webhook options
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
* create custom options funcs for each webhook type
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
* address comments from reviewers
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
---------
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
Co-authored-by: dprotaso <dprotaso@gmail.com>
2023-06-12 08:38:02 +00:00
5569169b0c
update boilerplate date ( #2539 )
...
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com>
2022-06-30 22:25:31 +00:00
e61a20dd64
Update actions ( #2313 )
...
Signed-off-by: Knative Automation <automation@knative.team>
2021-10-15 12:26:13 -07:00
9c7fd8e14f
Introduce `NewContext`, deprecate `NewImplFull`. ( #2222 )
...
* Introduce `NewContext`, deprecate `NewImplFull`.
Our generated `NewImpl` methods have long taken `context.Context`, but despite many iterations the forms we expose from our `controller` package never have. This change contains several elements:
1. Expose a new `NewContext` method that takes `context.Context` in addition to the current `NewImplFull` signature.
2. Call `NewContext` instead of the deprecated `NewImpl` from our generated controller code.
3. Call `NewContext` from all our webhook reconcilers.
* Add a Tracker to controller.Impl to cut down on downstream boilerplate.
2021-08-21 14:00:34 -07:00
6484377731
update boilerplate date ( #2134 )
2021-05-28 13:21:29 -07:00
75d66b5894
preserve the stable webhook logger names we had before ( #1994 )
...
* preserve the stable webhook logger names we had before
* pr feedback
2021-01-18 11:25:21 -08:00
f0ea5e6b9c
Use special error type to designate skips. ( #1988 )
...
This change introduces a new `controller.NewSkipKey` method to designate certain reconciliations as "skipped".
The primary motivation for this is to squelch useless logging on non-leader replicas, which currently report success with trivial latency.
I have plumbed this through existing reconcilers and the code-gen so most things downstream should get this for free. In places where a key is observed, I do not mark the reconcile as skipped as the reconciler did some processing for which the awareness of side-effects and reported latency may be interesting.
2021-01-14 14:30:20 -08:00
5807b6f9ee
Fix the error/warn log usage ( #1839 )
...
* Fix the error/warn log usage
zap doesn't do this well, when errors are not presented without zap.Error
* nits
2020-10-23 13:06:37 -07:00
b39d5da935
Spelling ( #1797 )
...
* spelling: adopted
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: aliased
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: apierrs
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: assignment
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: available
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: coexistence
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: commit
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: conversions
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: creates
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: custom
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: determine
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: different
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: distribution
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: duplicate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: editing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: endpoint
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: environment
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: generate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: implementation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: identified
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: ignore
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: indicates
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interface
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interleaved
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: labels
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: label
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mimic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: namespaced
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: necessary
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: organization
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: populatable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: prometheus
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: refer
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: reference
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: repetitive
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: response
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: something
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: specable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: spoofing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: synchronized
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: this
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: trailing
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unsupported
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: validation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* chore: reviewdog go header boilerplate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2020-10-18 14:22:57 -07:00
247841408e
Apply the cleanup to the pkg ( #1776 )
...
* Apply the cleanup to the pkg
This is probably the final iteration of my cleanup application.
* codegen
* one more try
2020-10-05 21:41:20 -07:00
1e373a9e5d
take 2 ( #1755 )
2020-09-29 14:10:29 -07:00
a371418524
v2 ( #1754 )
2020-09-29 13:18:29 -07:00
2d4efecc6b
bump to k8s 1.18 ( #1428 )
...
* bump to k8s 1.18.8
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
* plumbing ctx through
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
* add more ctx plumbing
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
* ctx WithCancel()
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
2020-09-11 07:54:00 -07:00
3ff7bcc422
Remove spammy log line ( #1687 )
...
Fixes: https://github.com/knative/pkg/issues/1686
2020-09-07 10:55:32 -07:00
bfc0cee945
Implement the second wave of per-reconciler leaderelection ( #1302 )
...
* Implement the second wave of per-reconciler leaderelection.
Detailed design: https://docs.google.com/document/d/1i_QHjQO2T3SNv49xjZLWlivcc0UvZN1Tbw2NKxThkyM/edit#
Issue: https://github.com/knative/pkg/issues/1181
* incorporate vagababov feedback
* Improve controller.go coverage
2020-06-19 09:47:25 -07:00
caa444033b
use crd & webhook v1 APIs ( #1391 )
2020-06-19 08:43:25 -07:00
18ed8c75b6
Add the key of the object to the log context ( #1348 )
...
* Add the key of the object to the log context
We don't log _what_ we convert, but only _what type_ it is.
And it's not very useful
So log all the stuff
* issues
* redo
2020-05-25 12:49:47 -07:00
5ba6c1d101
Change %v to %w in errors and other nits ( #1252 )
...
* Change %v to %w in errors and other nits
Other are things I noticed when fixing the main %v->%w conversion
* fold
2020-04-27 15:04:51 -07:00
83edd9f30d
Add augmented logger to the context to pass it down. ( #1192 )
2020-04-06 08:21:27 -07:00
1893541a0f
Scope the webhook secret informers to the system namespace. ( #1158 )
2020-03-12 18:29:29 -07:00
a572b9922a
Remove named returns, since they look icky :) ( #1151 )
...
In general, imo, it's prettier to return things as is, rather than the pattern that was
there.
Also handle one more error case, which was kind of ignored before (probably in practice
impossible, but idk)
2020-03-10 14:39:29 -07:00
507b519649
Fix some nits in the webhook code ( #1150 )
2020-03-10 10:36:29 -07:00
d771641c91
Fixed #1057 - Rename ConvertUp/Down to ConvertTo/From ( #1122 )
2020-02-24 09:44:08 -08:00
88d4536182
Conversion Webhook Framework ( #993 )
...
* ConversionController implementation
This controller will reconcile target CRDs with the correct
conversion webhook configuration. Specifically, the HTTP path and
CA bundle will be updated.
Additionally, the conversion controller will perform the given
conversions through a hub and spoke model utilizing the
apis.Convertible interface.
* Webhook now can host ConversionControllers
* injection/sharedmain now supports webhook.ConversionControllers
These conversion controllers will be hosted by the webhook that
the sharedmain will start
* support defaulting & include godoc
2020-02-03 08:59:29 -08:00
Dave Protasowski