Commit Graph

8 Commits

Author SHA1 Message Date
jjzeng-seattle 68b3eeeaab
Add helper functions for metric tests in serving (#1564)
* Add helper functions for metric tests in seving

* typo

* Add WithResource to simply the code
2020-07-29 03:08:59 -07:00
Evan Anderson deb6b33d2a
Make EnsureRecorded part of metricstest (#1554)
* Make EnsureRecorded part of metricstest; call it automatically in the "Assert" methods.

Increase test coverage.

* Address yanweiguo comments

* Add a barrier to ensure all metrics are recorded before scraping prometheus.
2020-07-27 08:45:58 -07:00
Evan Anderson bc4dc000cb
Add utilities for accessing metrics via metricproducer (#1526)
* Add utilities for accessing metrics via metricproducer.

* Fix tag comparison, bump up coverage.

* Convert workqueue_test (one of the main users of metricstest) to the new methods.

* Force event propagation sync one more place.

* Boost test coverage again.

* Address vagababov comments
2020-07-22 18:31:57 -07:00
Victor Agababov 25f2aa6443
micro-Nit in the test: don't make a private type public (#1510) 2020-07-16 10:41:33 -07:00
Evan Anderson 9f3fb07346
Remove delay-based flakiness from workqueue_test.go (#1497) 2020-07-15 10:20:33 -07:00
Yanwei Guo 19b1d7b64d
Add a helper func to set a default metric config for unit tests (#1263)
* do not record for empty metric config

* Revert "do not record for empty metric config"

This reverts commit 539a5e4dbb.

* add a comment

* fix typo

* fix tests

* revert

* revert tests

* revert

* fix conflicts

* one more test file
2020-05-07 21:11:45 -07:00
Matt Moore e4ac97c252 Update our dependency on K8s libs to 1.15.3 (#686)
With a minimum K8s version of 1.14 (starting in 0.10), 1.15.3 puts us in the center of the +/-1 version window of support.
2019-09-18 13:36:48 -07:00
Matt Moore ecb98001f2 Implement workqueue.MetricsProvider (#678)
The kubernetes workqueue provides a facility for collecting metrics by registering a workqueue.MetricsProvider
via workqueue.SetProvider.

This change implements that interface to expose the workqueue metrics into opencensus.

This is loosely based on some work started by @grantr [here](https://github.com/kubernetes-sigs/controller-runtime/compare/master...grantr:opencensus-replace#diff-bb94124aff8d568cb4e82854c7d44fd1)

Fixes: https://github.com/knative/pkg/issues/522
2019-09-16 09:55:41 -07:00