247841408e
Apply the cleanup to the pkg ( #1776 )
...
* Apply the cleanup to the pkg
This is probably the final iteration of my cleanup application.
* codegen
* one more try
2020-10-05 21:41:20 -07:00
a371418524
v2 ( #1754 )
2020-09-29 13:18:29 -07:00
5fbbde31b3
Align linters with serving (enables stylecheck and asciicheck) ( #1738 )
2020-09-23 07:37:40 -07:00
ddf2cbe3c1
Various nits around the code ( #1719 )
...
* Various nits around the code
* stagger
2020-09-18 16:22:45 -07:00
caa3276afd
Remove now unused test helpers ( #1716 )
...
They were used in perf tests in serving, but those don't exit anymore either.
2020-09-18 11:12:44 -07:00
b4fa6c275e
Add linting config and fix issues. ( #1691 )
...
* Add linting config and fix issues.
* Inline unused test helper.
2020-09-09 08:35:50 -07:00
c451e3c37f
Various cleanups around the codebase ( #1630 )
...
* Various cleanups around the codebase
- unindent the else after return
- make things private that are not used anywhere
- rearrange params
- etc
* add
2020-08-17 19:11:13 -07:00
e0a0d63a9e
Ingore files under benchmark folder ( #1441 )
2020-06-23 13:46:27 -07:00
fb0320d928
fix typo ( #1436 )
2020-06-22 19:45:26 -07:00
f0da4c9b6e
add --delete option for the perf-tests tool ( #1432 )
2020-06-22 08:06:26 -07:00
8b0054f5f1
Update boskos dependency to sigs.k8s.io/boskos ( #1378 )
...
* Update k8s.io/test-infra/boskos -> sigs.k8s.io/boskos
* Run hack/update-deps.sh
2020-06-09 11:28:32 -07:00
42e2ce9558
Junithelper refactor into a function that can be re-used. ( #1370 )
2020-06-02 16:16:17 -07:00
1ceb875570
Fix \" escaping and other nits in the pkg ( #1339 )
2020-05-16 09:36:02 -07:00
478962f05e
Properly fix the tests for the client ( #1300 )
...
There was a comment on the PR I merged earlier.
To add cmp.diff to the tests,
but when I actually looked, the tests look pretty bleak,
so I beefed them up and used t rather log
2020-05-05 17:17:44 -07:00
1b41d4f041
Hide metadata as a private ( #1292 )
...
* Hide metadata as a private
I am pretty sure it is unused outside of the package.
* also fix test
2020-05-05 09:36:45 -07:00
f591fc672a
export Client ( #1278 )
2020-05-04 00:22:43 -07:00
d29cf98a77
Assorted linting fixes. ( #1249 )
...
* Remove unused code.
* Use raw strings to avoid escaping.
* Remove unneeded type conversions.
* Preallocate slices where possible.
* Use semantic equality in psbinding reconciler.
2020-04-28 08:20:51 -07:00
5ba6c1d101
Change %v to %w in errors and other nits ( #1252 )
...
* Change %v to %w in errors and other nits
Other are things I noticed when fixing the main %v->%w conversion
* fold
2020-04-27 15:04:51 -07:00
064b156ab7
Update and fixes to the cluster management lib ( #1196 )
...
* fix project in e2e cluster manager
* delete async for boskos
* use the right quota in the GKE requests
* update google cloud api
* update
* fix unit tests
* fix unit tests
* fix unit tests
* acquire always creates new
* support resolving GKE version
* go fmt
* delete version.go
* add more unit tests
2020-04-06 14:52:59 -07:00
7727cb37e0
Retry cluster creation if there's an error ( #1186 )
...
* retry cluster creation if there's an error
* nit renaming
* go fmt
* delete cluster async
* clean up the code a bit
* nits
* address comments
* fix unit tests
* nits
* go fmt
* fix unit tests
2020-04-03 09:23:18 -07:00
777b215a64
use boskos to fetch a project if only a project is not specified ( #1169 )
2020-03-23 12:45:09 -07:00
1cc7b71529
golang format tools ( #1099 )
...
Produced via:
`gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)`
`goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party)`
/assign n3wscott
/cc n3wscott
2020-02-17 09:56:10 -08:00
d8caefc1cd
Default occupy Boskos for long enough time so we don't need to do hea… ( #1095 )
...
* Default occupy Boskos for long enough time so we don't need to do heartbeat
* Update testutils/clustermanager/e2e-tests/boskos/boskos.go
Co-Authored-By: Victor Agababov <vagababov@gmail.com>
Co-authored-by: Victor Agababov <vagababov@gmail.com>
2020-02-14 10:07:41 -08:00
84c9a84d38
Add extra flags for cluster creation in test ( #1033 )
...
* add extra flags for cluster creation
* move flags out of request.go
2020-02-03 07:38:30 -08:00
446f2e9f2c
Use e2 VMs instead of n1 for test clusters ( #1024 )
...
* Use n2 VMs instead of n1 for test clusters
* Update unit tests that use default values
2020-01-30 16:20:28 -08:00
b51ee347cb
give cloud-platform scope by default ( #1015 )
2020-01-27 17:39:25 -08:00
8daabb442e
do not enable workload identity for perf tests GKE clusters ( #1014 )
2020-01-27 14:44:26 -08:00
96d3b8c24c
Format markdown ( #997 )
...
Produced via:
`prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)`
/assign n3wscott
/cc n3wscott
2020-01-20 10:00:06 -08:00
d99cc30f66
Add a junithelper for creating a junit result from command ( #926 )
...
* Add a junithelper for creating a junit result from command
* Fix typo
2020-01-17 12:57:03 -08:00
e0330640f0
perf-tests cluster manager supports creating clusters in other environment ( #982 )
...
* perf-tests cluster manager supports creating clusters in other environment
* address codereview comments
* address comments
2020-01-10 11:29:57 -08:00
4f9e59084b
Return GKECluster info in PCO ( #975 )
...
Returns gkeOps in create, get prow-cluster-operation actions to fetch the Cluster info that's just created/fetched without reading the metadata file when running in Go
2020-01-06 14:43:50 -08:00
169ef0797c
Added GKE release channel support in cluster creation in cluster manager lib ( #968 )
...
* Added release channel support in cluster creation in cluster manager lib
* updated k8s beta dependency to pick up release channel API
* added unit test for the missing coverage in request_test.go
2020-01-02 11:27:42 -08:00
400dfb9ff9
updated boskos client based on the latest API in k8s ( #945 )
...
* updated boskos client based on the latest API in k8s
* Added clarification comments and cleanup dead code
* Apply suggestions from code review
Co-Authored-By: Victor Agababov <vagababov@gmail.com>
* Updated test error messages in boskos_test.go
* clarification on parameters
* removed accidentally modified client/istio changes
* Fixed unit test for AcquireGKEProject
* Apply suggestions from code review
Co-Authored-By: Victor Agababov <vagababov@gmail.com>
* simplified NewClient + annotated NewClient in boskos_test.go
Co-authored-by: Victor Agababov <vagababov@gmail.com>
2019-12-29 20:19:35 -08:00
9fda5bd59a
For GKE clusters used in performance tests, always enable Workload Identity ( #954 )
...
* always enable workload identity for perf test cluster creation
* fix unit tests
* add comments
2019-12-20 19:25:35 -08:00
0094d3a892
RecreateClusters function also create new clusters if they do not exist ( #950 )
...
* recreate-clusters also create new clusters
* fix unit tests
2019-12-17 18:27:04 -08:00
138ab0d10d
Propagate the error in prow-cluster-operation actions instead of log.Fatalf ( #931 )
...
* Propagate the error in prow-cluster-operation actions instead of log.Fatalf
* log error in the same manner in prow-cluster-operation main
2019-12-09 20:45:46 -08:00
da3d090aa9
modify boskos in cluster manager to make the boskos resource type customizable ( #922 )
2019-12-03 16:45:36 -08:00
c259ed6f2e
Moved cluster name check to later so --get can use cluster name in kubeconfig ( #918 )
2019-12-02 15:50:35 -08:00
56c2594e4f
Assorted linting fixes. ( #840 )
...
* Remove unused code.
* Remove unneeded loops.
* Remove unneeded Printf calls.
* Use time.Since instead of time.Now().Sub.
* Remove unused values.
* Rename error variable according to conventions.
* Return error last.
* Simplify array allocations.
* Remove leaky ticker.
* Remove Yoda conditions.
* Remove deprecated function to talk to GKE.
* Remove dot import.
* Remove empty critical section and replace with a channel operation.
* Add linter directives to explicitly state wanted weirdness.
* Update deps.
* Fix broken line.
2019-11-01 12:49:12 -07:00
12ca01312b
Format markdown ( #792 )
...
Produced via:
`prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)`
/assign mattmoor
2019-10-23 13:42:37 -07:00
2d54fc909d
golang format tools ( #791 )
...
Produced via:
`gofmt -s -w $(find -path './vendor' -prune -o -type f -name '*.go' -print))`
`goimports -w $(find -name '*.go' | grep -v vendor)`
/assign mattmoor
2019-10-23 13:37:29 -07:00
0b19b4ad91
Add prow-cluster-operation package ( #788 )
...
* Add prow-cluster-operation package
* Remove binary committed by accident
2019-10-22 11:19:26 -07:00
f0ffda4667
Add metahelper for reading/writing metadata in Prow ( #773 )
...
* Add metahelper for writing metadata in Prow
* Update prow package importing path
2019-10-22 10:29:26 -07:00
1331c9178a
Add perf test cluster manager ( #776 )
...
* name the parameters of functions in interface
* add perf test cluster manager
* fix package path
* fix build error
2019-10-18 23:50:20 -07:00
3f11504864
Some refactors of the pkg/test code ( #763 )
...
* some refactors of the pkg/test code
* move clustermanager
* fix unit tests
* address comments
* address feedback
* move clustermanager package
* add comments
* address comment
2019-10-15 23:03:15 -07:00
757d7e4c77
Add support for new addons for GKE cluster ( #764 )
...
* add all addons for gke so far
* fix tests
* support other addons for gke cluster
2019-10-15 13:10:15 -07:00
7a2cadb6ad
Modify cluster manager lib to make it work better with Prow ( #755 )
...
* Consolidate cluster manager lib
* Adjust unit test
* updates based on feedback
* Fixing unit tests
* Use project as string instead of pointer
2019-10-11 16:11:31 -07:00
7750c7d435
Support listing all clusters under a project' ( #752 )
...
* support listing all clusters under a project'
* address comments
* address comments
2019-10-08 22:41:37 -07:00
9353a99265
Move GKE basic operations to a separate package ( #737 )
...
* move GKE basic operations to a separate package
* trying to fix unit tests...
* fix unit tests
* also move wait out
* move the clustercreaterequest out
* fix unit tests
* Update testutils/gke/request_test.go
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
* add a flag to indicate whether it's blocking
* address comments, unit tests pending
* bump up unit tests
* minor changes
* fix unit tests
* get zonal changes back, and a few minor changes
* clean up
* more clean up
* address codereview comments
* fix unit test
* remove project id from the request
* project name is not required
* fix unit tests
2019-10-03 15:39:06 -07:00
385ff7299f
Clustermanager lib supports zonal cluster ( #740 )
...
* Support zonal cluster
* test util.go
* feedback updates
* Fix unit tests
* feedback updates2
* Update testutils/clustermanager/util_test.go
Co-Authored-By: Victor Agababov <vagababov@gmail.com>
2019-10-02 10:27:07 -07:00
Victor Agababov
Markus Thömmes
Chi Zhang
Murphylu1993
Jeff Grafton
peterfeifanchen
Joyce Liu
Matt Moore
chaodaiG
Adriano Cunha
mattmoor-sockpuppet