* Use atomic.Bool for TracingEnabled flag
* Expose IsTracingEnabled and make tracingEnabled package-scoped
* Fix
* Only keep ZipkingTracingEnabled but do not use it
* Revert "Fixed error with #1531 (#1533)"
This reverts commit d7498436
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
* Revert "Added logging of port forwarding stdout (#1531)"
This reverts commit 3b7ca76a
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
* JSONTrace returns a structured object, not just a string.
* Fix usage in spoof.go.
* Update test/zipkin/util.go
Co-Authored-By: Victor Agababov <vagababov@gmail.com>
* Update test/zipkin/util.go
Co-Authored-By: Victor Agababov <vagababov@gmail.com>
* PR comments.
* Separate common monitoring methods into monitoring package
* Add doc.go to monitoring
* Update doc.go to add information about the public methods
* Fix build tests
Existing support for Zipkin tracing pushes the
responsibility of logging zipkin traces to
individual tests. This change moves the responsibility
to SpoofClient, so that all tests get it by default.
Traces are logged only for requests that have
encountered Server errors i.e if the
http.Response.StatusCode between 500 to 599.
For SpoofingClient.Poll calls we only log trace of the
final SpoofingClient.Do made.
* Some fixes to the spoof.go and exporter.go
While reviewing some other CL, I saw some avenues for improving
spoof.go, to log the URL that's being fetched, which would help in test
debugging and to use switch construct, rather than nested if's.
While testing the change, I noticed some shifty loggin from the
exporter, so I fixed that as well while I was there.
* Continuation of the previous cleanups.
* Fix the issues with formatting by executing a grep
* and fix compilation error
* lowercase error
* fix the newly changed unit test