Victor Agababov
31657d4f05
Fix the logging to be a sentence ( #1236 )
...
Also it seems in the test logs this is manifested as 'returned an event' and nothing else...
but I blame it to the testing log configuration, perhaps.
2020-04-23 10:56:31 -07:00
Markus Thömmes
7fbf4b0edc
Add finalizer option and default to test code too. ( #1238 )
2020-04-23 10:02:31 -07:00
Markus Thömmes
6103dd9b71
Add a controller option to specify a custom finalizer name. ( #1230 )
2020-04-22 14:55:40 -07:00
Markus Thömmes
5036c917e5
Drop 'no longer exist' line to DEBUG. ( #1234 )
2020-04-22 07:34:40 -07:00
Markus Thömmes
c09083a601
Fix a few simple linter warnings: unused code, govet warnings etc. ( #1191 )
2020-04-06 08:21:20 -07:00
Scott Nichols
8a6d25b309
Generate reconcilers for resources out of tree. ( #1175 )
...
* genreconciler:nonNamespaced
* Adding a force-kinds flag to the reconciler generator to allow us to generate reconcilers for non-owned types.
* force-kinds --> force-genreconciler-kinds
* some minor nits with the generators for non-knative types needed to be removed.
* remove whitespace
Co-authored-by: Nacho Cano <nachoacano@gmail.com>
2020-03-25 11:34:51 -07:00
Markus Thömmes
5605ade524
Add filtering to class based controller stubs. ( #1133 )
2020-03-03 12:57:53 -08:00
Scott Nichols
3a272190c3
Found missing forced packages in injection gen. ( #1116 )
...
* ctx
* runtime.object
* update codegen
2020-02-21 13:42:07 -08:00
Scott Nichols
5d8a01d12c
Implement strongly typed class reconcilers ( #1103 )
...
* Implement strongly typed class reconcilers
* document class filters.
* matt is always right
2020-02-19 08:38:06 -08:00
Scott Nichols
72f3cd2bbc
[Genreconciler] Fix group names when client groups differ than their directory name. ( #1097 )
...
* looking at annotations for group overrides.
* checkpoint.
* checkpoint
* I think it is correct.
* ok
* trim down the files.
* simulate tekton
* working test out of checkin
* remove test client
* update docs
* and test.
* lint
* it ok
* update codegen
2020-02-18 17:14:59 -08:00
Scott Nichols
69f70e37d9
adding recorder to context. ( #1096 )
2020-02-14 14:28:41 -08:00
Scott Nichols
602d92f69b
I screwed up the return for clearFinalizer. ( #1089 )
2020-02-13 08:35:36 -08:00
Matt Moore
12ca62e262
golang format tools ( #1087 )
...
Produced via:
`gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)`
`goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party)`
/assign n3wscott
/cc n3wscott
2020-02-13 08:27:36 -08:00
Scott Nichols
558f848aa0
[GenRec] Keep resource in sync when setting and removing finalizers. ( #1086 )
...
* Update the resource if it is patched for finalizer mods to let status update work the first try.
* matt does not like extra :
2020-02-12 17:08:36 -08:00
Scott Nichols
d93ce78496
[Reconciler Generators] Adding support for configStore.ToContext ( #1085 )
...
* Support optional config maps.
* document configmap stores
* whitespace.
* optionsFns
* review
* check for nil.
* zero trust imports.
2020-02-12 16:10:35 -08:00
Scott Nichols
a5517037d3
set the import for sets ( #1075 )
2020-02-11 07:52:07 -08:00
Matt Moore
dddb2d8753
golang format tools ( #1072 )
...
Produced via:
`gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)`
`goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party)`
/assign n3wscott
/cc n3wscott
2020-02-11 07:13:07 -08:00
Scott Nichols
248c9f0353
fix filtering for reconcilers gen. ( #1071 )
2020-02-11 05:26:07 -08:00
Scott Nichols
85608a8329
Generate Managed Finalizers for Reconcilers ( #1069 )
...
* fix rando issues
* code in the group for finalizer name.
* Use FinalizeKind
* show the Finalizer interface.
* removing isFinalizing
* sync finalizers before calling reconcilekind
* missed the events change.
2020-02-10 19:46:06 -08:00
Matt Moore
8e404c7c40
golang format tools ( #1056 )
...
Produced via:
`gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)`
`goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party)`
/assign n3wscott
/cc n3wscott
2020-02-06 16:57:32 -08:00
Scott Nichols
b63641488a
fix event recorder ( #1053 )
2020-02-05 13:51:31 -08:00
Scott Nichols
51af633af7
adding matt and scott to owners for codegen ( #1054 )
2020-02-05 13:44:31 -08:00
Matt Moore
5660964262
golang format tools ( #1051 )
...
Produced via:
`gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)`
`goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party)`
/assign n3wscott
/cc n3wscott
2020-02-05 07:57:31 -08:00
Scott Nichols
b9974987c2
Fix issue with returning errors, and not adding scheme ( #1049 )
2020-02-04 18:03:30 -08:00
Scott Nichols
b317048346
Generate Base Reconciler Code for Injection Based Controllers. ( #947 )
...
* adding a reconciler generator to use as the base reconcilers for all of knative.
* mend
* fix tag names.
* use reconciler events
* trying new thing.
* base working reconciler gen
* working cleaned up reconciler generator.
* fix typo
* fix some ordering.
* fix interface path
* fix whitespace
* update deps.
* updates based on feedback.
* Remove core loop.
* reconcilerImpl
* add NewReconciler
* Fix copyright header
* Comment out finalizers
* remove finalizers from generated code.
2020-02-04 10:23:30 -08:00
Matt Moore
43ca049cdb
Reduce the boilerplate for setting up duck.InformerFactory's. ( #896 )
...
This augments the injection codegen with the capability to produce a duck.InformerFactory
attached to context for each type that we process.
Now a `duck.InformerFactory` for "Addressable" can be produced by "Get"ing it from the context.
This is triggered by placing `// +genduck` on the type that implements `duck.Implementable`.
2019-11-25 09:57:10 -08:00
Markus Thömmes
56c2594e4f
Assorted linting fixes. ( #840 )
...
* Remove unused code.
* Remove unneeded loops.
* Remove unneeded Printf calls.
* Use time.Since instead of time.Now().Sub.
* Remove unused values.
* Rename error variable according to conventions.
* Return error last.
* Simplify array allocations.
* Remove leaky ticker.
* Remove Yoda conditions.
* Remove deprecated function to talk to GKE.
* Remove dot import.
* Remove empty critical section and replace with a channel operation.
* Add linter directives to explicitly state wanted weirdness.
* Update deps.
* Fix broken line.
2019-11-01 12:49:12 -07:00
Dave Protasowski
528ad1c1dd
Generate K8s Injection Code ( #640 )
...
* update codegen so the fatal error messages are more informative
String representation of an untyped nil is 'nil' so the Fatal messages weren't useful
* generate k8s injection code
* generate apiextensions injection code
* use Fatal & move output paths
* switch from Fatal to Panic
* injection creates a single factory
2019-09-09 12:52:11 -07:00
Matt Moore
524f6c5bb2
Add the ability to scope informers to a namespace with injection. ( #626 )
2019-09-03 07:17:00 -07:00
mattmoor-sockpuppet
1864f499dc
golang format tools ( #497 )
...
Produced via:
`gofmt -s -w $(find -path './vendor' -prune -o -type f -name '*.go' -print))`
`goimports -w $(find -name '*.go' | grep -v vendor)`
/assign @mattmoor
2019-06-27 07:37:08 -07:00
Matt Moore
222dd25986
Migrate pkg to use the knative.dev/pkg import path ( #489 )
...
* Manual changes.
* scripted changes.
2019-06-26 13:02:06 -07:00
mattmoor-sockpuppet
5d105b46d3
golang format tools ( #444 )
...
Produced via:
`gofmt -s -w $(find -path './vendor' -prune -o -type f -name '*.go' -print))`
`goimports -w $(find -name '*.go' | grep -v vendor)`
2019-06-06 09:54:40 -07:00
Matt Moore
4d86f3ad6f
Access a logger and Fatalf when Get would return nil. ( #439 )
2019-06-05 09:06:38 -07:00
Matt Moore
35bb0fc83b
Add code-generation for the various injection stubs. ( #438 )
...
This is largely based on work by @n3wscott
2019-06-05 08:50:38 -07:00