This method is not used anywhere outside pkg right now, so it's a safe change.
This will permit activator to set desired maxidle params and cache more connection for better performance
We're playing around with writing TableTests for the Operator (which uses manifestival) and would
like to see if we can get a good comparator for the automatically added last-applied-configuration annotation.
If that ends up being general purpose we can upstream it here, but in general it's nice to be allowed to do
some application specific filtering of the desired state changes.
* Add utilities for accessing metrics via metricproducer.
* Fix tag comparison, bump up coverage.
* Convert workqueue_test (one of the main users of metricstest) to the new methods.
* Force event propagation sync one more place.
* Boost test coverage again.
* Address vagababov comments
* Revert "Fixed error with #1531 (#1533)"
This reverts commit d7498436
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
* Revert "Added logging of port forwarding stdout (#1531)"
This reverts commit 3b7ca76a
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
* do not record for empty metric config
* Revert "do not record for empty metric config"
This reverts commit 539a5e4dbb.
* redo
* use local
* typo
* Update leaderelection/context.go
Co-authored-by: Matt Moore <mattmoor@vmware.com>
* merge another pr
* update dep
* Update hash/bucketer_test.go
Co-authored-by: Victor Agababov <vagababov@gmail.com>
* Update hash/bucketer_test.go
Co-authored-by: Victor Agababov <vagababov@gmail.com>
* output diff
* output diff
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Victor Agababov <vagababov@gmail.com>
* Harden the drain tests more
- introduce synthetic timer that gives us the capability to actually trigger events in the drain itself
- unfortunately we still need time.After calls in the test due to the timing for go routines to finish (they race the default: case and lose).
* comment
* more things
* pfpf
* dudud
* Add component name as the metric prefix for opencensus exporter
Read from all meters instead of just he default one
Add component name as the metric prefix for opencensus exporter
* Update codegen
* Add domain as metric prefix
* Use path.Join to simply the code
* Use two lane queue instead of the regular workqueue
- we need to poll for len in the webhook tests because we have async propagation now, and check at the wrong time will be not correct.
- otherwise just a drop in replacement.
* update test
* cmt
* tests hardened
* Implement a new shared "Drainer" handler.
This implements a new `http.Handler` called `Drainer`, which is intended to wrap some inner `http.Handler` business logic with a new outer handler that can respond to Kubelet probes (successfully until told to "Drain()").
This takes over the webhook's relatively new probe handling and lame duck logic with one key difference. Previously the webhook waited for a fixed period after SIGTERM before exitting, but the new logic waits for this same grace period AFTER THE LAST REQUEST. So if the handler keeps getting (non-probe) requests, the timer will continually reset, and once it stops receiving requests for the configured grace period, "Drain()" will return and the webhook will exit.
The goal of this work is to try to better cope with what we believe to be high tail latencies of the API server seeing that a webhook replica is shutting down.
Related: https://github.com/knative/pkg/issues/1509
* Switch to RWLock
* do not record for empty metric config
* Revert "do not record for empty metric config"
This reverts commit 539a5e4dbb.
* for standard
* delete bucket
* add s
* Make logstream watch the pods as they change.
- watch the pods and track what we already watch
- start watchers for the new pods
* log
* review
* other
Markus Thömmes