3 Commits

Author	SHA1	Message	Date
Matt Moore	4da41e302a	Bump the sleep in the controller testing. (#88) ... The rate limiting queue makes the sleep necessary. Locally I see 0-2 failures when this is run with -count=10000. This bumps the sleep slightly to reduce this further. Fixes: https://github.com/knative/pkg/issues/56	2018-09-24 07:49:20 -07:00
Matt Moore	3ca427071d	Add a logkey for the reconcile key. (#49) ... This adds a logkey.Key for attaching the key being reconciled to a logger we embed into the context passed to Reconcile. The point of this is to enable us to eliminate [this](928d580756/pkg/reconciler/v1alpha1/service/service.go (L101-L104)) boilerplate from each of the Reconcilers. These aren't identical, this has the form: knative.dev/key: foo/bar What it's replacing has the form: knative.dev/namespace: foo serving.knative.dev/service: bar However, the type information present in the latter is redundant with the controller type that [should already be embedded](928d580756/pkg/reconciler/reconciler.go (L80)) in the logger.	2018-08-23 09:48:59 -07:00
Matt Moore	bf6f9e373f	Move our base controller infrastructure into knative/pkg. (#33) ... The `controller.go` is from: https://github.com/knative/serving/pull/1770, however, this adds 100% coverage of `controller.go`, which we have been missing in `knative/serving`. This also adds a `context.Context` to the `Reconcile` signature, to enable better sharing of logger setup across controllers. Fixes: https://github.com/knative/pkg/issues/8	2018-08-01 14:32:37 -07:00