Commit Graph

11 Commits

Author SHA1 Message Date
Dave Protasowski ee1db869c7
Update linter config and address lint warnings/failures (#3068)
* fix whitespace linter

* fix usestdlibvars

* fix staticheck

* ignore spancheck warning

* fix linter perfsprint

* fix nolintlint feedback

* fix nilerr lint checks

* fix misspell

* fix mirror lint

* fix intrange linter

* fix gofumpt linter

* fix gosec linter - ignore warning since default min tls version is 1.3

* fix gocritic linter

* fix whitespace

* fix fatcontext linter

* fix errorlint

* fix errname linter

* fix copyloopvar (go1.22) linter

* fix bodyclose linter

* update linter config

* add script to format code

* fix unit test
2024-06-25 14:49:36 +00:00
Vishal Choudhary 300df436f9
Eventing TLS: Added AddressableFromDestination method on the resolver (#2717)
* Added AddressableFromDestination method

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

* requested changes

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

* added requested change

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

* added changes from pierDipi

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

* tests

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

* fixes

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

* fixes in tests

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

* added changes

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

* added return

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

* fixing errors

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

* updated tests for ref

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

* added null pointer fix

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

---------

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
2023-04-20 07:15:39 +00:00
Rahul Sawra 4835a4cb0c
Eventing TLS: update destination and Kref types (#2716)
* update destination and Kref types

* Update apis/duck/v1/destination.go

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* update Destination in v1beta1

---------

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
2023-04-04 10:08:38 +00:00
Francesco Guardiani 192b0c9d6e
Add KReference.Group field and ResolveGroup function (#2127)
* Add Group field and ResolveGroup function

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Remove core special case

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Copyright

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Added validation code

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fix comment

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Add omitempty

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Moved ResolveGroup code to kref
Made ResolveGroup a util method, more than an instance method

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* New type KReferenceResolver

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Added +optional as suggested

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
2021-06-15 02:27:20 -07:00
Victor Agababov 8c2e0012c3
No reason to get parent NS if we're not gonna use it. (#1055)
and add a comment for the public method
2020-02-06 09:42:32 -08:00
Ville Aikas 4ec5e09f71
check KReference namespace matches parent. Allow escape hatch. (#1052) 2020-02-05 08:04:31 -08:00
Victor Agababov 0264117c2b
Some nit cleanups (#1040) 2020-02-03 16:56:30 -08:00
Ville Aikas 95163c65ac
Rename KnativeReference to KReference (#1039) 2020-02-03 12:58:30 -08:00
Ville Aikas d5698e90e2
make namespace optional so existing objects keep working (#1034) 2020-02-02 22:17:30 -08:00
Ville Aikas 99abcc2ff5
add SetDefaults from parent (using context), change Destination to us… (#1031)
* add SetDefaults from parent (using context), change Destination to use KnativeReference

* address pr comments, change address resolver to use kref
2020-02-01 11:59:29 -08:00
Ville Aikas aebcdbd5f3
add KnativeReference (#1030)
* add KnativeReference

* fix copyright year
2020-01-31 13:22:28 -08:00