If suffix name itself contained dashes, when we append the trimmed suffix
we might end up on the dash, which is a non valid k8s name.
So fix that.
/assign mattmoor
currently if the suffix is longer than 31 characters the function would panic.
This fixes that by adding additional checks and trimming. Plus in this case
it will hash the whole string, to ensure uniqueness.
/assign @mattmoor