Commit Graph

7 Commits

Author SHA1 Message Date
Markus Thömmes 385c8b9c0e
Fix nolint warnings and adhere to best practices (#1823) 2020-10-20 09:33:59 -07:00
Markus Thömmes e4ecf702a3
Apply gosec checks to the codebase, except tests. (#1725)
* Apply gosec checks to the codebase, except tests.

* Fix YAML whitespace.

* Tune back file mode change and add a comment.
2020-09-22 08:55:40 -07:00
Victor Agababov e73c8084c2 Fix a typo in the comment (#962) 2019-12-23 14:38:26 -08:00
Victor Agababov 731f943e4f Fix the childname where trimming caused a dash. (#928)
If suffix name itself contained dashes, when we append the trimmed suffix
we might end up on the dash, which is a non valid k8s name.
So fix that.

/assign mattmoor
2019-12-08 14:12:44 -08:00
Victor Agababov 8a10634b4f Fix the panics in the naming functions. (#556)
currently if the suffix is longer than 31 characters the function would panic.
This fixes that by adding additional checks and trimming. Plus in this case
it will hash the whole string, to ensure uniqueness.

/assign @mattmoor
2019-08-02 14:48:46 -07:00
Victor Agababov 74c5d67ea0 Fix the issues pointed out by staticcheck (#541)
* Fix the issues pointed out by staticcheck

* review fix
2019-07-23 13:13:36 -07:00
Victor Agababov 55ded05b4e Upstream ChildName to the pkg (#471) 2019-06-18 18:43:46 -07:00