pkg/webhook
Victor Agababov 5807b6f9ee
Fix the error/warn log usage (#1839)
* Fix the error/warn log usage

zap doesn't do this well, when errors are not presented without zap.Error

* nits
2020-10-23 13:06:37 -07:00
..
certificates Fix the error/warn log usage (#1839) 2020-10-23 13:06:37 -07:00
configmaps Fix the error/warn log usage (#1839) 2020-10-23 13:06:37 -07:00
psbinding Fix the error/warn log usage (#1839) 2020-10-23 13:06:37 -07:00
resourcesemantics Fix the error/warn log usage (#1839) 2020-10-23 13:06:37 -07:00
testing v2 (#1754) 2020-09-29 13:18:29 -07:00
OWNERS add self to aliases and add reviewers to OWNERS (#1409) 2020-06-22 12:30:27 -07:00
README.md Format markdown (#875) 2019-11-13 15:08:28 -08:00
admission.go take 2 (#1755) 2020-09-29 14:10:29 -07:00
admission_integration_test.go Spelling (#1797) 2020-10-18 14:22:57 -07:00
context.go Streamline `webhook.New`. (#821) 2019-10-28 16:12:11 -07:00
conversion.go take 2 (#1755) 2020-09-29 14:10:29 -07:00
conversion_integration_test.go v2 (#1754) 2020-09-29 13:18:29 -07:00
env.go Add helper function to read webhook port number from env var (#1162) 2020-05-16 18:43:02 -07:00
env_test.go Add helper function to read webhook port number from env var (#1162) 2020-05-16 18:43:02 -07:00
helper_test.go bump to k8s 1.18 (#1428) 2020-09-11 07:54:00 -07:00
stats_reporter.go Spelling (#1797) 2020-10-18 14:22:57 -07:00
stats_reporter_test.go Remove resource_name tag from webhook stats (#1464) 2020-09-21 12:09:49 -07:00
webhook.go Spelling (#1797) 2020-10-18 14:22:57 -07:00
webhook_integration_test.go v2 (#1754) 2020-09-29 13:18:29 -07:00
webhook_test.go v2 (#1754) 2020-09-29 13:18:29 -07:00

README.md

Knative Webhooks

Knative provides infrastructure for authoring webhooks under knative.dev/pkg/webhook and has a few built-in helpers for certain common admission control scenarios. The built-in admission controllers are:

  1. Resource validation and defaulting (builds around apis.Validatable and apis.Defaultable under knative.dev/pkg/apis).
  2. ConfigMap validation, which builds around similar patterns from knative.dev/pkg/configmap (in particular the store concept)

To illustrate standing up the webhook, let's start with one of these built-in admission controllers and then talk about how you can write your own admission controller.

Standing up a Webhook from an Admission Controller

We provide facilities in knative.dev/pkg/injection/sharedmain to try and eliminate much of the boilerplate involved in standing up a webhook. For this example we will show how to stand up the webhook using the built-in admission controller for validating and defaulting resources.

The code to stand up such a webhook looks roughly like this:

// Create a function matching this signature to pass into sharedmain.
func NewResourceAdmissionController(ctx context.Context, cmw configmap.Watcher) *controller.Impl {
	return resourcesemantics.NewAdmissionController(ctx,
		// Name of the resource webhook (created via yaml)
		fmt.Sprintf("resources.webhook.%s.knative.dev", system.Namespace()),

		// The path on which to serve the webhook.
		"/resource-validation",

		// The resources to validate and default.
		map[schema.GroupVersionKind]resourcesemantics.GenericCRD{
			// List the types to validate, this from knative.dev/sample-controller
			v1alpha1.SchemeGroupVersion.WithKind("AddressableService"): &v1alpha1.AddressableService{},
		},

		// A function that infuses the context passed to Validate/SetDefaults with custom metadata.
		func(ctx context.Context) context.Context {
			// Here is where you would infuse the context with state
			// (e.g. attach a store with configmap data, like knative.dev/serving attaches config-defaults)
			return ctx
		},

		// Whether to disallow unknown fields when parsing the resources' JSON.
		true,
	)
}

func main() {
	// Set up a signal context with our webhook options.
	ctx := webhook.WithOptions(signals.NewContext(), webhook.Options{
		// The name of the Kubernetes service selecting over this deployment's pods.
		ServiceName: "webhook",

		// The port on which to serve.
		Port:        8443,

		// The name of the secret containing certificate data.
		SecretName:  "webhook-certs",
	})

	sharedmain.MainWithContext(ctx, "webhook",
		// The certificate controller will ensure that the named secret (above) has
		// the appropriate shape for our webhook's admission controllers.
		certificates.NewController,

		// This invokes the method defined above to instantiate the resource admission
		// controller.
		NewResourceAdmissionController,
	)
}

There is also a config map validation admission controller built in under knative.dev/pkg/webhook/configmaps.

Writing new Admission Controllers

To implement your own admission controller akin to the resource defaulting and validation controller above, you implement a knative.dev/pkg/controller.Reconciler as with any you would with any other type of controller, but the Reconciler that gets embedded in the *controller.Impl should also implement:

// AdmissionController provides the interface for different admission controllers
type AdmissionController interface {
	// Path returns the path that this particular admission controller serves on.
	Path() string

	// Admit is the callback which is invoked when an HTTPS request comes in on Path().
	Admit(context.Context, *admissionv1beta1.AdmissionRequest) *admissionv1beta1.AdmissionResponse
}

The Reconciler part is responsible for the mutating or validating webhook configuration. The AdmissionController part is responsible for guiding request dispatch (Path()) and handling admission requests (Admit()).