mirror of https://github.com/knative/pkg.git
c365f7d338
* Abort reconcilation on finalizer patch errors. This aborts reconcilation if finalizers could not be patched correctly with an error and thus it retries. We shouldn't start a reconcilation if we haven't been able to correctly add the finalizer first. Otherwise we could get into a weird spot where the resources are created before the finalizer and in a very degenerate case the finalizer wouldn't even be executed. Also, the current code has a bug where if the patch fails the resource coming back from the patch (essentially an empty object) is passed into ReconcileKind, causing headaches. The same imo goes for removing a finalizer. Failing to remove a finalizer blocks the resource forever, thus we should retry if that happens too. * Add generated code. |
||
|---|---|---|
| .. | ||
| v1/namespace | ||