mirror of https://github.com/knative/pkg.git
c267dfecb7
Immutable fields with default values may now be changed iff they change is to populate their default value. This is to support defaulting in the scenario where an object was created long ago and a new field (with a default!) is added. When controllers attempt to mutate the object status today, this would create a webhook rejection! With this change, we compare against a freshly defaulted "old" object to exclude newly defaulted fields from the immutability check. We saw this in knative/serving for the newly added TimeoutSeconds field in Revision (otherwise immutable), which I believe it leading to upgrade testing flakes since post-upgrade Revision status updates will fail. |
||
|---|---|---|
| .. | ||
| OWNERS | ||
| certs.go | ||
| certs_test.go | ||
| helper_test.go | ||
| webhook.go | ||
| webhook_integration_test.go | ||
| webhook_test.go | ||