Commit Graph

95 Commits

Author SHA1 Message Date
Dave Protasowski 3424b8cd70
use new observability config instead of knative.dev/pkg/metrics (#15959) 2025-07-08 20:31:09 +00:00
Stavros Kontopoulos 6ccb82f47c
Integrate net-certmanager in Serving (#15066)
* integrate net-certmanager in Serving

* Revert "disable kourier-tls (#15053)"

This reverts commit 8bda840b1a.

* fix imports

* add netcert conformance tests

* fix vendor

* add vendor networking test files

* some fixes + rebase

* fixes

* add crd check

* sym link

* fix vendor

* move reconciler

* fix style

* empty

* move to pkg/client
2024-04-25 19:36:46 +00:00
Caleb Woodbine e9425f8d52
chore: remove v1alpha1 domainmapping (#14275)
the API is deprecated and is ready to removed
2023-08-18 20:27:18 +00:00
Stavros Kontopoulos fc166ac8b4
Consolidate webhooks (#14082)
* consolidate webhooks

* pass the queue name update

* merge types, clean up webhook configs

* remove unused
2023-07-07 21:02:41 +00:00
Stavros Kontopoulos 22783d6bd5
Deployment probe fixes (#13885)
* probe fixes

* fixes

* fix threshold

* cleanup
2023-04-24 19:38:43 +00:00
Dave Protasowski e2862ae45a
allow unknown fields in our webhooks since our CRD schemas are now specified (#13111) 2022-07-11 21:35:19 +00:00
Dave Protasowski 45f7c054f6
Fix deprecation notices (#12958)
* bump knative.dev/networking

* fix deprecation notices

* canonicalize knative.dev/networking/pkg/http/header import

* canonicalize knative.dev/networking/pkg/config import

* canonicalize knative.dev/networking/pkg/http/stats import

* canonicalize knative.dev/networking/pkg/http/probe import

* fix typo
2022-05-21 00:17:59 +00:00
Julian Friedman 5a0ea08fd7
Validate features configmap (#11391)
* Validate features configmap

* fix duplicate package import
2021-05-21 04:02:17 -07:00
Arghya Sadhu 3efbd13426
get webhook name from env (#10205)
Signed-off-by: Arghya Sadhu <arghya88@gmail.com>
2020-11-26 08:50:35 -08:00
Markus Thömmes 89fc5bd68b
Drop unnecessary wrapper functions (#9706) 2020-10-06 05:17:21 -07:00
Dave Protasowski 862d230322
drop serving v1beta1 (#9620) 2020-09-30 15:59:29 -07:00
Matt Moore 13e6833194
Eliminate serving v1alpha1 (#9545)
* Eliminate serving v1alpha1

/hold

Hold until we're in 19

Related: https://github.com/knative/serving/issues/8638

* Remove lemonade stuff

* Update deps to remove pruned deps

* Fix typo in v1beta1
2020-09-29 10:27:28 -07:00
Nghia Tran 66ba375b9a
Remove / deprecate code that was moved to knative.dev/networking (#8873)
* Remove / deprecate code that was moved to knative.dev/networking

* Fix linter comments.
2020-07-31 14:02:00 -07:00
Weston Haught 5ee8c9cd43
PodSpec dry-run for unparented Configurations (#8828)
* validate configurations

* Update pkg/webhook/validate_unstructured.go

Co-authored-by: Julian Friedman <julz.friedman@uk.ibm.com>

Co-authored-by: Julian Friedman <julz.friedman@uk.ibm.com>
2020-07-28 17:20:59 -07:00
Matt Moore 584d41b172
Enable HA by default (#8602)
* Enable HA by default

* Centralize the bucket/replica information for running the HA testing.

Add a test to ensure the count of the controller's reconciler stays in sync with the actual controller binary.
2020-07-13 14:59:18 -07:00
Julian Friedman d7033ad342
Tidy up some lint complaints (#8296) 2020-06-11 06:39:23 -07:00
Nghia Tran f1582404be
Use types from networking. (#8237) 2020-06-08 14:34:32 -07:00
Victor Agababov 8e4034aa49
Clean up linter errors and other nits (#8080)
Clean code — happy code!
2020-05-26 17:44:49 -07:00
Jihui Nie 8070a0165a
Add WEBHOOK_PORT env var to webhook container (#7248)
* Add WEBHOOK_PORT env var to webhook container

* Use PortFromEnv func from pkg/
2020-05-25 09:19:47 -07:00
Zhimin Xiang 392aa1233e
Remove certmanager related code from serving (#7824)
* remove certmanager related code

* fix update-codegen

* re-run update-codegen
2020-05-03 19:43:43 -07:00
whaught 052d278549
Validate Revision templates with K8s Dry-Run (#7544)
* Pass an empty list of callbacks

* include package name

* punctuation

* modify deployment make dryrun

* Decode fix and soft-fail unsupported

* Create a unit test with a good config

* Include a test that fails

* add a test case for not supported

* skip dryrun for empty template

* Check for nil pointer

* Fix unit test

* minor review comments

* move package location

* Use the unstructured to find nested template

* Add unit test for no spec found

* Set defaults on the Revision

* use generate name

* Dryrun all versions of Service

* Include proper namespace

* correct metadata

* Increase test coverage

* Only attempt dryrun validation if also in dryrun mode.

* I can't spell.

* dryrun assert unit test

* Switch unit test to compare strings

* remove emptystring inits

* expect test annotation

* remove ref to dryrun

* Switch to string contains for clarity

* update to empty annotations list

* use unstructured builtins

* addressing feedback

* address review comments

* update error message

* adding an owners file

* include issue in todo
2020-04-22 12:52:40 -07:00
Nghia Tran 2ea8445c67
Code has been moved to new home https://github.com/knative/net-istio (#7169)
* Code has been moved to new home https://github.com/knative/net-istio

* Move config validation in webhook to knative.dev/net-istio.

* Run hack/update-*.sh
2020-03-07 07:43:27 -08:00
Paul Morie 37852e689d
Add leader election (#6683)
* Leader election: config changes

* Add leader election configmap to validation

* Fix broken symlink to leader election config

* Add leader election config validation

* Validate leader election config

* Add valid but inactive config for leader election

* Add copyright headers

* Remove empty enabledComponents from leader election config

* Update dependencies

* Add comment for exported validation method

* Move leader election config -> pkg/leaderelection

* Nits in leader election config

* Rename leader election config validation method
2020-02-27 09:13:51 -08:00
Dave Protasowski b1f991033d
Rename ConvertUp/Down to ConvertTo/From (#6986)
* bump knative.dev/pkg

* Rename ConvertUp/Down to ConvertTo/From

Replacing done via the commands:
```
rg -l ConvertDown | xargs -n1 sed -i ''  's/ConvertDown/ConvertFrom/g'
rg -l ConvertUp | xargs -n1 sed -i ''  's/ConvertUp/ConvertTo/g'
```

* fix Gopkg.lock digest
2020-02-24 16:57:15 -08:00
Murugappan Chetty 723eed6bd3
Set config in the context for validation admission controller (#6938)
* set default context for validation webhook

* set default context for validation webhook
2020-02-24 08:33:09 -08:00
Paul Morie 0507dcf31f
Move webhooks onto new sharedmain methods (#6824)
* Move webhook onto sharedmain.WebHookMain

* Update dependency on pkg
2020-02-21 08:21:06 -08:00
Julian Friedman 03121e2e89
Move autoscaler config to subpackage (#6822)
* Move autoscaler config to its own package

* Fix import ordering
2020-02-12 15:08:35 -08:00
Dave Protasowski 292b6149e0
Conversion Webhook Support (#6566)
* bump knative.dev/pkg which includes conversion webhook support

* Wire in conversion webhook support for serving's public types

Change the storage type to v1

* include a link to the per-version CRD schema issue

* use constant group resources for our Knative types

* revert the storage version to v1alpha1
2020-02-04 10:53:30 -08:00
Nima Kaviani dcfc487521 move ObservabilityConfig funcs into knative.dev/pkg (#5841) 2020-01-21 14:16:23 -08:00
Matt Moore d5adfb5869 Move webhooks to separate paths. (#6215) 2019-12-12 10:06:51 -08:00
Matt Moore 916ab9f5ac Split apart defaulting and validation webhooks (#5947)
Related: knative/pkg#848
2019-11-14 17:20:02 -08:00
Matt Moore 143c72e47c Pull in the latest knative/pkg, incl. webhook refactor. (#5911)
This pulls in a series of changes to knative.dev/pkg/webhook that allows the boilerplate we need to be greatly reduced.  The webhook is also now reconciler-based, so it should be much more resilient.
2019-10-31 10:49:12 -07:00
Matt Moore eb63b051c6 Have the GC config take context. (#5888) 2019-10-28 10:35:42 -07:00
Matt Moore 5c2f5aed12 Add yaml to explicitly create our webhook configs. (#5871)
* Add yaml to explicitly create our webhook configs.

This imports https://github.com/knative/pkg/pull/802 and explicitly creates the
webhook configurations that updates, and handles the breaking struct changes.

Related: https://github.com/knative/serving/issues/5845

* Incorporate feedback from @dgerd
2019-10-25 12:33:35 -07:00
Markus Thömmes d245bb9c2f Removing duplicated imports and unused code. (#5794)
* Remove duplicated imports and unused code.

* Remove unused helpers from the v1alpha1 API.
2019-10-11 11:32:30 -07:00
Grant Rodgers e59a7f4c6a Use the correct zap sugared logger syntax (#5747)
Fatalw needs either a zap.Field or key, value pairs in the variadic
args.
2019-10-02 19:19:06 -07:00
William Tam ec457adcb1 Remove clusteringress from source (#5665)
* remove clusteringress resources in routereconcile loop

* Remove clusteringress from source

* Remove dead function 'ensureFinalizer'

* re-run update-codegen.sh

* Rollback DefaultIngressClassKey to 'clusteringress.class' since it is a breaking change.  We will be depreciated in a follow up PR.

* undo change to reinstate clusteringress role rules
2019-09-28 10:37:44 -07:00
Nima Kaviani 4081b85af5 add config validation as admission controller (#5404) 2019-09-27 11:40:42 -07:00
Matt Moore b4b2158488 Ensure all of the Serving binaries expose the new Go memstats. (#5632)
See: https://github.com/knative/pkg/pull/711
2019-09-25 15:44:43 -07:00
mattmoor-sockpuppet 13a6b60927 golang format tools (#5557)
Produced via:
  `gofmt -s -w $(find -path './vendor' -prune -o -type f -name '*.go' -print))`
  `goimports -w $(find -name '*.go' | grep -v vendor)`
/assign mattmoor
2019-09-16 07:40:40 -07:00
Dan Gerdesmeier b818dcecdc Integrate v1 types (#5483)
* Integrate v1 types

* Enable v1 API when v1beta1 is enabled
* Add v1 to the set of APIs webhook understands

v1alpha1:
* Replace inlined references with v1

v1beta1:
* Replaces all but outer shape to prevent drifting duplication. Embed v1
directly into v1beta1.
* Move context logic into v1

* Bring coverage up

* Add v1 to migration test

* Fix import error

* Fix typo
2019-09-12 10:17:33 -07:00
Nima Kaviani 0f246e7a8b rename the variable for resource validation webhook (#5474) 2019-09-11 08:01:29 -07:00
Dave Protasowski 80ec2f7fce bump knative pkg & caching (#5423) 2019-09-09 17:55:11 -07:00
Nima Kaviani 53c0d16892 use the amdission controller interface for webhook (#5338) 2019-09-04 11:29:03 -07:00
Martin Gencur 364cfa1f0c Profiling support (#5083)
* Profiling support

* Update to latest knative.dev/pkg

* Fix rebase error
2019-08-24 15:40:13 -07:00
Markus Thömmes f09d564ee6 Remove unnecessary volume mounts. (#5049)
* Use config helpers in webhook as well.

* Remove unnecessary volume mounts.
2019-08-02 14:28:45 -07:00
Markus Thömmes 36e94ebfec Use injection based client creation in activator and webhook. (#5017) 2019-08-01 12:19:44 -07:00
Markus Thömmes 621ec87b16 Use context based signals handler in the activator and webhook as well. (#5004) 2019-07-31 15:18:46 -07:00
William Tam f2c67e9445 Add namespaced ingress implementation which runs along side with cluster ingress (#4750)
* Add namespaced ingress implementation which runs along side with cluster ingress

* moved checkout to knative,dev/serving

* fix Golint arg-order: context.Context should be the first parameter of a function.

* ran update-codegen.sh

* add eventhandler with impl.EnqueueControllerOf

* Ingress gets owner reference of route.  Clusteringress informer to add eventhandler using enqueuelabelof route
2019-07-18 07:16:28 -07:00
Markus Thömmes 866b9c48cc Introduce 'Metric' as a full-fledged API object. (#4753)
* Introduce 'Metric' as a full-fledged API object.

This is a step towards enabling pluggable autoscalers to manipulate the metric-collector. For now the whole lifecycle is still handled in-memory though.

* Fix compilation issues.

* Review comments.
2019-07-17 07:45:29 -07:00