manifests/tests
Yannis Zarkadas f4d4aac424
Cherry-pick commits to v1.3-branch (#1849)
* chore: remove argo manifests from contrib (#1813)

* Make note of knative-eventing being optional in README  (#1826)

Only Knative Serving is required for KFServing to work.
Knative Eventing is used for specific logger/metrics tracking
use cases, so a note is made in the README about eventing
being optional.

* README: Expand section for connecting to a Kubeflow cluster (#1841)

The current section for connecting to a Kubeflow cluster only covers
connecting with port-forward. Expand the section with instructions for
NodePort / LoadBalancer / Ingress.

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Sync Katib manifests with Kustomize v4 support (#1840)

* Kubeflow Tekton Pipelines: Sync manifests (#1843)

Sync manifests for application "Kubeflow Tekton Pipelines".
Upstream manifests are copied from:
- Repo: https://github.com/kubeflow/kfp-tekton
- Path: manifests/kustomize
- Revision: v0.8.0-rc0

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Sync wg-notebooks apps to revision 1.3.0-rc.1 (#1846)

* Notebook Controller: Sync manifests

Sync manifests for application "Notebook Controller".
Upstream manifests are copied from:
- Repo: https://github.com/kubeflow/kubeflow
- Path: components/notebook-controller/config
- Revision: 8901e3af3b83f599b89562162cdb2854f57082d3

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Tensorboard Controller: Sync manifests

Sync manifests for application "Tensorboard Controller".
Upstream manifests are copied from:
- Repo: https://github.com/kubeflow/kubeflow
- Path: components/tensorboard-controller/config
- Revision: 8901e3af3b83f599b89562162cdb2854f57082d3

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Central Dashboard: Sync manifests

Sync manifests for application "Central Dashboard".
Upstream manifests are copied from:
- Repo: https://github.com/kubeflow/kubeflow
- Path: components/centraldashboard/manifests
- Revision: 8901e3af3b83f599b89562162cdb2854f57082d3

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Profiles + KFAM: Sync manifests

Sync manifests for application "Profiles + KFAM".
Upstream manifests are copied from:
- Repo: https://github.com/kubeflow/kubeflow
- Path: components/profile-controller/config
- Revision: 8901e3af3b83f599b89562162cdb2854f57082d3

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* PodDefaults Webhook: Sync manifests

Sync manifests for application "PodDefaults Webhook".
Upstream manifests are copied from:
- Repo: https://github.com/kubeflow/kubeflow
- Path: components/admission-webhook/manifests
- Revision: 8901e3af3b83f599b89562162cdb2854f57082d3

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Jupyter Web App: Sync manifests

Sync manifests for application "Jupyter Web App".
Upstream manifests are copied from:
- Repo: https://github.com/kubeflow/kubeflow
- Path: components/crud-web-apps/jupyter/manifests
- Revision: 8901e3af3b83f599b89562162cdb2854f57082d3

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Tensorboards Web App: Sync manifests

Sync manifests for application "Tensorboards Web App".
Upstream manifests are copied from:
- Repo: https://github.com/kubeflow/kubeflow
- Path: components/crud-web-apps/tensorboards/manifests
- Revision: 8901e3af3b83f599b89562162cdb2854f57082d3

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Volumes Web App: Sync manifests

Sync manifests for application "Volumes Web App".
Upstream manifests are copied from:
- Repo: https://github.com/kubeflow/kubeflow
- Path: components/crud-web-apps/volumes/manifests
- Revision: 8901e3af3b83f599b89562162cdb2854f57082d3

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Remove load_restrictor kustomize flag and lint README markdown (#1844)

* remove load-restrictor kustomize flag and lint README markdown

* Set kustomize loader to RestrictionRootOnly in test_util.go

* review: undo changes to test scripts

* review: add note to reusing patches best practices

* README: Add component version matrix (#1847)

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* README: Add FAQ, elaborate kustomize version, update version matrix (#1848)

* README: Add FAQ section and justify kustomize version

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* README: Update version matrix

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

Co-authored-by: Yuan (Bob) Gong <4957653+Bobgy@users.noreply.github.com>
Co-authored-by: Paul Van Eck <pvaneck@us.ibm.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Co-authored-by: DavidSpek <vanderspek.david@gmail.com>
2021-04-17 06:29:14 -07:00
..
katib/installs fix mysql deployment strategy (#1562) 2020-11-09 21:54:41 -08:00
legacy_kustomizations feat: remove outdated metadata UI manifests (#1619) 2020-11-11 11:44:52 -08:00
scripts Update the notebook-controller image. (#443) 2019-10-08 15:13:51 -07:00
stacks [IBM] deprecate custom ibm openshift singleuser kfdef (#1732) 2021-02-03 14:36:28 -08:00
testdata_gcp_kpt/gcp Convert v1 to v2 setters & substituions in gcp (#1398) 2020-07-20 21:21:13 -07:00
tests/legacy_kustomizations Change cluster-admin role to `ml-pipeline-persistenceagent` for the pipeline/persistent-agent sa (#1712) 2021-01-13 21:17:03 -08:00
tools commonLabels need to be immutable to support upgrading. (#1140) 2020-04-30 22:14:06 -07:00
Makefile Update manifests for 1.3 RC (#1794) 2021-04-02 13:25:20 -07:00
OWNERS Update Notebook OWNERS (#1599) 2020-11-03 15:30:03 -08:00
README.md unittests should compare result of kustomize build to golden set of YAML resources. (#1016) 2020-03-22 17:52:44 -07:00
doc.go unittests should compare result of kustomize build to golden set of YAML resources. (#1016) 2020-03-22 17:52:44 -07:00
go.mod Private gke fixes (#1746) 2021-02-26 15:56:38 -08:00
go.sum chore(kfp): upgrade istio resources -- part 1 (#1719) 2021-01-20 23:55:00 -08:00
test_util.go Cherry-pick commits to v1.3-branch (#1849) 2021-04-17 06:29:14 -07:00
validate_resources_test.go Step 1: Reorganize folder structure (#1739) 2021-02-15 04:05:06 -08:00

README.md

Kustomize Manifest Tests

Unittests

There are two goals for the unittests:

  1. Verify that kustomizations are applied correctly (kubeflow/manifests#1014)
  2. Verify that various conventions are enforced (kubeflow/manifests#1015)

Verifying Kustomizations Are Applied Correctly

Examples of kustomizations that we would like to verify are applied and generate the expected output

  • Patches
  • Variable substitution
  • Composition of resources

The general approach to doing this is

  1. Check in one more "kustomization.yaml" files corresponding to test cases

  2. Run "kustomize build -o ..." and check in the output as the expected test output

    • Reviewers can verify changes to the expected output to ensure changes have the desired effect on the expected output
  3. Unittests run "kustomize build" and compare output to expected output to ensure kustomize packages are in sync with the expected output

  4. Make commands make it easy to regenerate the expected output as part of a change.

    cd tests
    make generate-changed-only