Use comprehensive lint Make target
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
This commit is contained in:
parent
6c4f285eba
commit
ff8a11608a
|
|
@ -1,27 +0,0 @@
|
||||||
name: golangci-lint
|
|
||||||
on:
|
|
||||||
push:
|
|
||||||
branches:
|
|
||||||
- "master"
|
|
||||||
- "release-*"
|
|
||||||
tags:
|
|
||||||
- "v*"
|
|
||||||
pull_request:
|
|
||||||
branches:
|
|
||||||
- "master"
|
|
||||||
- "release-*"
|
|
||||||
|
|
||||||
jobs:
|
|
||||||
golangci:
|
|
||||||
name: lint
|
|
||||||
runs-on: ubuntu-latest
|
|
||||||
steps:
|
|
||||||
- uses: actions/checkout@v3
|
|
||||||
- uses: actions/setup-go@v3
|
|
||||||
with:
|
|
||||||
go-version-file: go.mod
|
|
||||||
- name: golangci-lint
|
|
||||||
uses: golangci/golangci-lint-action@v3
|
|
||||||
with:
|
|
||||||
version: v1.64.8
|
|
||||||
args: --timeout=5m
|
|
||||||
|
|
@ -30,7 +30,7 @@ jobs:
|
||||||
with:
|
with:
|
||||||
go-version-file: ${{ env.GOPATH }}/src/github.com/kubeflow/mpi-operator/go.mod
|
go-version-file: ${{ env.GOPATH }}/src/github.com/kubeflow/mpi-operator/go.mod
|
||||||
- name: fmt check
|
- name: fmt check
|
||||||
run: make fmt
|
run: make fmt lint
|
||||||
- name: go mod tidy
|
- name: go mod tidy
|
||||||
run: make tidy
|
run: make tidy
|
||||||
- name: Build
|
- name: Build
|
||||||
|
|
|
||||||
2
Makefile
2
Makefile
|
|
@ -134,7 +134,7 @@ tidy:
|
||||||
|
|
||||||
.PHONY: lint
|
.PHONY: lint
|
||||||
lint: bin/golangci-lint ## Run golangci-lint linter
|
lint: bin/golangci-lint ## Run golangci-lint linter
|
||||||
$(GOLANGCI_LINT) run
|
$(GOLANGCI_LINT) run --timeout=5m
|
||||||
|
|
||||||
# Generate deploy/v2beta1/mpi-operator.yaml
|
# Generate deploy/v2beta1/mpi-operator.yaml
|
||||||
manifest: kustomize crd
|
manifest: kustomize crd
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue