kubeflow
/
notebooks
mirror of https://github.com/kubeflow/notebooks.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix notebook route (kubeflow/kubeflow#4402)

This commit is contained in:
Lun-Kai Hsu 2019-10-24 16:01:39 -07:00 committed by Kubernetes Prow Robot
parent 2e7dc7ec06
commit 2fe3108347
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
components/notebook-controller/controllers/notebook_controller.go
View File

@ -344,8 +344,8 @@ func virtualServiceName(kfName string, namespace string) string {
func generateVirtualService(instance *v1beta1.Notebook) (*unstructured.Unstructured, error) {
name := instance.Name
namespace := instance.Namespace
prefix := fmt.Sprintf("/notebook/%s/%s", namespace, name)
rewrite := fmt.Sprintf("/notebook/%s/%s", namespace, name)
prefix := fmt.Sprintf("/notebook/%s/%s/", namespace, name)
rewrite := fmt.Sprintf("/notebook/%s/%s/", namespace, name)
// TODO(gabrielwen): Make clusterDomain an option.
service := fmt.Sprintf("%s.%s.svc.cluster.local", name, namespace)