kubeflow
/
notebooks
mirror of https://github.com/kubeflow/notebooks.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: set default GPU vendors list (kubeflow/kubeflow#7320) 

The change introduced by kubeflow/kubeflow#6736 removed the default GPU vendors
list, which causes an issue when trying to select a vendor from the dropdown menu
if the vendors list is not configured.
This commit can be reverted if proper documentation is provided for users/distributions
to configure the dropdown menu.
Fixes #7273
This commit is contained in:
Daniela Plascencia 2023-10-09 10:28:18 +02:00 committed by GitHub
parent b9ff781a21
commit b38794b7c6
2 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
components/crud-web-apps/jupyter/backend/apps/common/yaml/spawner_ui_config.yaml
View File

@ -129,12 +129,11 @@ spawnerFormDefaults:
# the list of available vendors in the dropdown # the list of available vendors in the dropdown
# `limitsKey` - what will be set as the actual limit # `limitsKey` - what will be set as the actual limit
# `uiName` - what will be displayed in the dropdown UI # `uiName` - what will be displayed in the dropdown UI
vendors: [] vendors:
#vendors: - limitsKey: "nvidia.com/gpu"
# - limitsKey: "nvidia.com/gpu" uiName: "NVIDIA"
# uiName: "NVIDIA" - limitsKey: "amd.com/gpu"
# - limitsKey: "amd.com/gpu" uiName: "AMD"
# uiName: "AMD"
# the default value of the limit # the default value of the limit
# (possible values: "none", "1", "2", "4", "8") # (possible values: "none", "1", "2", "4", "8")

11
components/crud-web-apps/jupyter/manifests/base/configs/spawner_ui_config.yaml
View File

@ -129,12 +129,11 @@ spawnerFormDefaults:
# the list of available vendors in the dropdown # the list of available vendors in the dropdown
# `limitsKey` - what will be set as the actual limit # `limitsKey` - what will be set as the actual limit
# `uiName` - what will be displayed in the dropdown UI # `uiName` - what will be displayed in the dropdown UI
vendors: [] vendors:
#vendors: - limitsKey: "nvidia.com/gpu"
# - limitsKey: "nvidia.com/gpu" uiName: "NVIDIA"
# uiName: "NVIDIA" - limitsKey: "amd.com/gpu"
# - limitsKey: "amd.com/gpu" uiName: "AMD"
# uiName: "AMD"
# the default value of the limit # the default value of the limit
# (possible values: "none", "1", "2", "4", "8") # (possible values: "none", "1", "2", "4", "8")