kubeflow
/
notebooks
mirror of https://github.com/kubeflow/notebooks.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: update supported platforms for multi-arch builds 

After discussion with the Kubeflow WG lead - concerns were raised about including `linux/s390x` support in our multi-arch builds for the following reasons:
- not clear we could in good faith support this system due to lack of hardware / potential emulation issues
- not clear there is enough of a need from community to support `linux/s390x` for Kubeflow Notebooks.

As a result - we are going to remove the `linux/s390x` target from our multi-arch builds logic.

Additionally, included a minor fix to explicitly specify the `v8` variant of `linux/arm64`.  Today `linux/arm64` and `linux/arm64/v8` are essentially the same - but that could change if there was ever a `v9` variant introduced.  As such - opting to be explicit here.

Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
This commit is contained in:
Andy Stoneberg 2025-09-05 10:17:41 -04:00
parent 0fbbe7a0ee
commit b4b94276ad
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
workspaces/backend/Makefile
View File

@ -104,7 +104,7 @@ docker-push: ## Push docker image with the backend.
# - have enabled BuildKit. More info: https://docs.docker.com/develop/develop-images/build_enhancements/ # - have enabled BuildKit. More info: https://docs.docker.com/develop/develop-images/build_enhancements/
# - be able to push the image to your registry (i.e. if you do not set a valid value via IMG=<myregistry/image:<tag>> then the export will fail) # - be able to push the image to your registry (i.e. if you do not set a valid value via IMG=<myregistry/image:<tag>> then the export will fail)
# To adequately provide solutions that are compatible with multiple platforms, you should consider using this option. # To adequately provide solutions that are compatible with multiple platforms, you should consider using this option.
PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le PLATFORMS ?= linux/arm64/v8,linux/amd64,linux/ppc64le
.PHONY: docker-buildx .PHONY: docker-buildx
docker-buildx: ## Build and push docker image for the manager for cross-platform support docker-buildx: ## Build and push docker image for the manager for cross-platform support
# copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile # copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile

2
workspaces/controller/Makefile
View File

@ -114,7 +114,7 @@ docker-push: ## Push docker image with the manager.
# - have enabled BuildKit. More info: https://docs.docker.com/develop/develop-images/build_enhancements/ # - have enabled BuildKit. More info: https://docs.docker.com/develop/develop-images/build_enhancements/
# - be able to push the image to your registry (i.e. if you do not set a valid value via IMG=<myregistry/image:<tag>> then the export will fail) # - be able to push the image to your registry (i.e. if you do not set a valid value via IMG=<myregistry/image:<tag>> then the export will fail)
# To adequately provide solutions that are compatible with multiple platforms, you should consider using this option. # To adequately provide solutions that are compatible with multiple platforms, you should consider using this option.
PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le PLATFORMS ?= linux/arm64/v8,linux/amd64,linux/ppc64le
.PHONY: docker-buildx .PHONY: docker-buildx
docker-buildx: ## Build and push docker image for the manager for cross-platform support docker-buildx: ## Build and push docker image for the manager for cross-platform support
# copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile # copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile

2
workspaces/frontend/Makefile
View File

@ -39,7 +39,7 @@ docker-push: ## Push docker image for the frontend.
$(CONTAINER_TOOL) push ${IMG} $(CONTAINER_TOOL) push ${IMG}
# PLATFORMS defines the target platforms for cross-platform support. # PLATFORMS defines the target platforms for cross-platform support.
PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le PLATFORMS ?= linux/arm64/v8,linux/amd64,linux/ppc64le
.PHONY: docker-buildx .PHONY: docker-buildx
docker-buildx: ## Build and push docker image for cross-platform support. docker-buildx: ## Build and push docker image for cross-platform support.