kubeflow
/
notebooks
mirror of https://github.com/kubeflow/notebooks.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: return waiting on no pvcviewer status (kubeflow/kubeflow#7350) 

In some cases, a PVCViewer object has no status as it was just created or is having issues starting a pod.  In those cases, we should rather return waiting than uninitialized, which would appear to the users as if no viewer was started.
This commit is contained in:
Tobias Goerke 2024-05-24 02:25:27 +02:00 committed by GitHub
parent c032359463
commit d4f0f18a70
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
components/crud-web-apps/volumes/backend/apps/common/status.py
View File

@ -51,15 +51,14 @@ def viewer_status(viewer):
Return a string representing the status of that viewer. If a deletion
timestamp is set we want to return a `Terminating` state.
"""
try:
ready = viewer["status"]["ready"]
except KeyError:
if viewer is None or not viewer:
return status.STATUS_PHASE.UNINITIALIZED
if "deletionTimestamp" in viewer["metadata"]:
metadata = viewer.get("metadata", {})
if "deletionTimestamp" in metadata:
return status.STATUS_PHASE.TERMINATING
if not ready:
return status.STATUS_PHASE.WAITING
if viewer.get("status", {}).get("ready", False):
return status.STATUS_PHASE.READY
return status.STATUS_PHASE.READY
return status.STATUS_PHASE.WAITING