kubeflow
/
notebooks
mirror of https://github.com/kubeflow/notebooks.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: reference ghcr.io images in workspacekind yaml (#305) 

Given we have migrated all our images from docker.io to ghcr.io - our `notebooks-v2` branch should reference the "proper" container registry.

This commit updates the code to use:
- `ghcr.io/kubeflow/kubeflow/notebook-servers`

Affected areas:
- `jupyterlab_scipy_180` and `jupyterlab_scipy_190` `imageConfig` entries
- various test files

Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
This commit is contained in:
Andy Stoneberg 2025-06-26 16:49:17 -04:00 committed by GitHub
parent 5690c2ee52
commit dd4ef1f939
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
workspaces/backend/api/suite_test.go
View File

@ -312,7 +312,7 @@ func NewExampleWorkspaceKind(name string) *kubefloworgv1beta1.WorkspaceKind {
}, },
}, },
Spec: kubefloworgv1beta1.ImageConfigSpec{ Spec: kubefloworgv1beta1.ImageConfigSpec{
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.8.0", Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.8.0",
Ports: []kubefloworgv1beta1.ImagePort{ Ports: []kubefloworgv1beta1.ImagePort{
{ {
Id: "jupyterlab", Id: "jupyterlab",
@ -337,7 +337,7 @@ func NewExampleWorkspaceKind(name string) *kubefloworgv1beta1.WorkspaceKind {
}, },
}, },
Spec: kubefloworgv1beta1.ImageConfigSpec{ Spec: kubefloworgv1beta1.ImageConfigSpec{
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.9.0", Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.9.0",
Ports: []kubefloworgv1beta1.ImagePort{ Ports: []kubefloworgv1beta1.ImagePort{
{ {
Id: "jupyterlab", Id: "jupyterlab",

2
workspaces/controller/api/v1beta1/workspacekind_types.go
View File

@ -318,7 +318,7 @@ type ImageConfigValue struct {
type ImageConfigSpec struct { type ImageConfigSpec struct {
// the container image to use // the container image to use
// +kubebuilder:validation:MinLength:=2 // +kubebuilder:validation:MinLength:=2
// +kubeflow:example="docker.io/kubeflownotebookswg/jupyter-scipy:v1.7.0" // +kubeflow:example="ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.7.0"
Image string `json:"image"` Image string `json:"image"`
// the pull policy for the container image // the pull policy for the container image

4
workspaces/controller/config/samples/jupyterlab_v1beta1_workspacekind.yaml
View File

@ -271,7 +271,7 @@ spec:
spec: spec:
## the container image to use ## the container image to use
## ##
image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.8.0" image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.8.0"
## the pull policy for the container image ## the pull policy for the container image
## - default: "IfNotPresent" ## - default: "IfNotPresent"
@ -301,7 +301,7 @@ spec:
- key: "python_version" - key: "python_version"
value: "3.11" value: "3.11"
spec: spec:
image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.9.0" image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.9.0"
imagePullPolicy: "IfNotPresent" imagePullPolicy: "IfNotPresent"
ports: ports:
- id: "jupyterlab" - id: "jupyterlab"

4
workspaces/controller/internal/controller/suite_test.go
View File

@ -288,7 +288,7 @@ func NewExampleWorkspaceKind1(name string) *kubefloworgv1beta1.WorkspaceKind {
}, },
}, },
Spec: kubefloworgv1beta1.ImageConfigSpec{ Spec: kubefloworgv1beta1.ImageConfigSpec{
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.8.0", Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.8.0",
Ports: []kubefloworgv1beta1.ImagePort{ Ports: []kubefloworgv1beta1.ImagePort{
{ {
Id: "jupyterlab", Id: "jupyterlab",
@ -313,7 +313,7 @@ func NewExampleWorkspaceKind1(name string) *kubefloworgv1beta1.WorkspaceKind {
}, },
}, },
Spec: kubefloworgv1beta1.ImageConfigSpec{ Spec: kubefloworgv1beta1.ImageConfigSpec{
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.9.0", Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.9.0",
Ports: []kubefloworgv1beta1.ImagePort{ Ports: []kubefloworgv1beta1.ImagePort{
{ {
Id: "jupyterlab", Id: "jupyterlab",

4
workspaces/controller/internal/webhook/suite_test.go
View File

@ -276,7 +276,7 @@ func NewExampleWorkspaceKind(name string) *kubefloworgv1beta1.WorkspaceKind {
}, },
}, },
Spec: kubefloworgv1beta1.ImageConfigSpec{ Spec: kubefloworgv1beta1.ImageConfigSpec{
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.8.0", Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.8.0",
Ports: []kubefloworgv1beta1.ImagePort{ Ports: []kubefloworgv1beta1.ImagePort{
{ {
Id: "jupyterlab", Id: "jupyterlab",
@ -301,7 +301,7 @@ func NewExampleWorkspaceKind(name string) *kubefloworgv1beta1.WorkspaceKind {
}, },
}, },
Spec: kubefloworgv1beta1.ImageConfigSpec{ Spec: kubefloworgv1beta1.ImageConfigSpec{
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.9.0", Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.9.0",
Ports: []kubefloworgv1beta1.ImagePort{ Ports: []kubefloworgv1beta1.ImagePort{
{ {
Id: "jupyterlab", Id: "jupyterlab",