kubeflow
/
notebooks
mirror of https://github.com/kubeflow/notebooks.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

jwa(front): Don't disable vendors with no GPUs (kubeflow/kubeflow#6171) 

JWA should not block users from selecting GPUs if the current cluster
nodes do not have any GPUs attached to them. We've seen users that have
autoscaled nodegroups for GPUs, so a GPU node will be added to the
cluster once a Pod has requested it.

Refs: arrikto/dev#1484

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
This commit is contained in:
Kimonas Sotirchos 2021-10-07 17:23:23 +04:00 committed by GitHub
parent dcec619962
commit eb68995189
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-gpus/form-gpus.component.html
View File

@ -25,7 +25,6 @@
<mat-option <mat-option
*ngFor="let v of vendors" *ngFor="let v of vendors"
[value]="v.limitsKey" [value]="v.limitsKey"
[disabled]="vendorIsDisabled(v)"
[matTooltip]="vendorTooltip(v)" [matTooltip]="vendorTooltip(v)"
> >
{{ v.uiName }} {{ v.uiName }}

6
components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-default/form-gpus/form-gpus.component.ts
View File

@ -47,13 +47,9 @@ export class FormGpusComponent implements OnInit {
} }
// Vendor handling // Vendor handling
public vendorIsDisabled(vendor: GPUVendor) {
return !this.installedVendors.has(vendor.limitsKey);
}
public vendorTooltip(vendor: GPUVendor) { public vendorTooltip(vendor: GPUVendor) {
return !this.installedVendors.has(vendor.limitsKey) return !this.installedVendors.has(vendor.limitsKey)
? $localize`No ${vendor.uiName} GPU found installed in the cluster.` ? $localize`There are currently no ${vendor.uiName} GPUs in you cluster.`
: ''; : '';
} }