related: #239
This commit brings partial support for secrets to the backend API. It enables the `frontend` component to successfully create a Workspace through the "wizard flow".
**HOWEVER**, it is important to note this secrets attribute is not supported within the `controller` component yet - as #240 is not yet merged. To unblock the `frontend` - the logic contained in this commit simply adds the necessary scaffolding to accept the `secrets` attribute defined within `volumes`. Once umarshalled, the backend essentially ignores this data. Code to fully enable the end to end flow is included in this PR - but simply commented out with `TODO:` comments denoting what can be uncommented once #240 is merged into `notebooks-v2`. A test is also presently disabled with `XIt` - and can also be enabled when required code present.
Changes were initially coded against the branch provided on #240 to verify full end-to-end behavior. Once confirmed, commit was rebased onto `notebooks-v2`, relevant code commented out as described above, and behavior retested to ensure desired outcome.
In summary, with these changes:
- `backend` API accepts `volumes.secrets` in the _Create_ payload
- secrets data is **NOT USED** when programmatically constructing the Workspace CR
- Resultant workspace has no `secrets` data - irrespective of it if was provided in the payload or not.
Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
* feat(ws): Notebooks 2.0 // Backend // List Workspaces API - II
In this PR:
- FUP for Notebooks 2.0 // Backend // List Workspaces API (#60) review
- Create /api/v1/workspaces to return all workspaces
- Review API endpoints as requested
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
* Notebooks 2.0 // Backend // CRUD Workspaces API
In this PR:
- Created handlers and repositories for create, get and delete workspace
- Improved the type of our json response
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
* feat(ws): Notebooks 2.0 // Backend // List WorkspaceKinds
This PR builds on top of: https://github.com/kubeflow/notebooks/pull/61 and https://github.com/kubeflow/notebooks/pull/65
In this PR:
- Created handlers and repositories for get workspacekinds
This PR closes https://github.com/kubeflow/notebooks/issues/51
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
* mathew: fix linting
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
---------
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Andy Stoneberg
yehudit1987
Eder Ignatowicz
Mathew Wicks
Mohamed Akrem Chabchoub