Given we have migrated all our images from docker.io to ghcr.io - our `notebooks-v2` branch should reference the "proper" container registry.
This commit updates the code to use:
- `ghcr.io/kubeflow/kubeflow/notebook-servers`
Affected areas:
- `jupyterlab_scipy_180` and `jupyterlab_scipy_190` `imageConfig` entries
- various test files
Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
* Add routes for Workspace Kind Create
Signed-off-by: Charles Thao <cthao@redhat.com>
* Implement method selection step for Workspace Kind Create wizard
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add styling
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add type guards for yaml file upload
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add properties step to WorkspaceKindForm
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add image step to WorkspaceKindForm
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add empty steps and switch Method step to radio buttons
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add step description to Workspace Kind Form
Signed-off-by: Charles Thao <cthao@redhat.com>
* Migrate Workspace Kind Form to utilize Toggle Group
Signed-off-by: Charles Thao <cthao@redhat.com>
* Disable Form View when YAML is not uploaded or valid
Signed-off-by: Charles Thao <cthao@redhat.com>
* Allow VScode to discover local ESLint rules
Signed-off-by: Charles Thao <cthao@redhat.com>
* Styling organization improvements + Refactor types
Signed-off-by: Charles Thao <cthao@redhat.com>
---------
Signed-off-by: Charles Thao <cthao@redhat.com>
* Minor refactorings and initial work for the Workspace Kind summary page
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat(ws): added links from workspace kind details drawer to workspace kinds details page (#1)
Signed-off-by: Paulo Rego <832830+paulovmr@users.noreply.github.com>
* Enable workspace filtering by namespace in the WorkspaceKind summary page
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Update Pause/Start action response types according to backend
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Fix WorkspaceKind logo href
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Replace placeholders for GPU data with real values in WorkspaceKind summary page
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Allow columns to be hidden in the WorkspaceTable
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat(ws): added links from workspace kind details drawer namespace tab to workspace kinds details page (#2)
Signed-off-by: Paulo Rego <832830+paulovmr@users.noreply.github.com>
* Improve types around Filter component
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat: Add Workspace Actions Context and related components
- Introduced WorkspaceActionsContext to manage workspace actions such as view, edit, delete, start, restart, and stop.
- Created WorkspaceActionsContextProvider to encapsulate the context logic and provide it to child components.
- Implemented WorkspaceKindSummary and Workspaces components to utilize the new context for handling workspace actions.
- Added polling for refreshing workspaces at a default interval.
- Enhanced WorkspaceTable to support row actions for workspaces.
- Updated various components to include sortable and filterable data fields.
- Refactored WorkspaceStartActionModal and WorkspaceStopActionModal to handle optional onActionDone callback.
- Added loading and error handling components for better user experience.
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat: Add buildWorkspaceList function and integrate into mockAllWorkspaces
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* refactor: Update mock data and formatting for workspace activity timestamps
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat: Implement usePolling hook and refactor workspace actions in Workspaces and WorkspaceKindSummary components
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* refactor: Update column key usage in ExpandedWorkspaceRow and adjust workspace actions visibility in Workspaces component
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Make mocked workspace list deterministic
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat: Enhance WorkspaceTable with additional columns and filtering capabilities
- Added 'namespace', 'gpu', and 'idleGpu' columns to WorkspaceTable.
- Updated filtering logic to support new columns in WorkspaceTable.
- Refactored useWorkspaces hook to remove unnecessary parameters related to idle and GPU filtering.
- Modified WorkspaceKindSummary and its expandable card to utilize new filtering functionality.
- Updated WorkspaceUtils to include a method for formatting workspace idle state.
- Adjusted Filter component to support generic filtered column types.
- Updated Workspaces page to hide new columns as needed.
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* refactor: Improve sorting functionality in WorkspaceTable by utilizing specific types for sortable columns
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Adjustments after rebase
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Format with prettier
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
---------
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Paulo Rego <832830+paulovmr@users.noreply.github.com>
Co-authored-by: Paulo Rego <832830+paulovmr@users.noreply.github.com>
related: #239
This commit brings partial support for secrets to the backend API. It enables the `frontend` component to successfully create a Workspace through the "wizard flow".
**HOWEVER**, it is important to note this secrets attribute is not supported within the `controller` component yet - as #240 is not yet merged. To unblock the `frontend` - the logic contained in this commit simply adds the necessary scaffolding to accept the `secrets` attribute defined within `volumes`. Once umarshalled, the backend essentially ignores this data. Code to fully enable the end to end flow is included in this PR - but simply commented out with `TODO:` comments denoting what can be uncommented once #240 is merged into `notebooks-v2`. A test is also presently disabled with `XIt` - and can also be enabled when required code present.
Changes were initially coded against the branch provided on #240 to verify full end-to-end behavior. Once confirmed, commit was rebased onto `notebooks-v2`, relevant code commented out as described above, and behavior retested to ensure desired outcome.
In summary, with these changes:
- `backend` API accepts `volumes.secrets` in the _Create_ payload
- secrets data is **NOT USED** when programmatically constructing the Workspace CR
- Resultant workspace has no `secrets` data - irrespective of it if was provided in the payload or not.
Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
* feat(ws): Add secrets to workspace creation properties form
Signed-off-by: Charles Thao <cthao@redhat.com>
* Fix typos
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add descriptions to Secrets in Workspace creation wizard
Signed-off-by: Charles Thao <cthao@redhat.com>
---------
Signed-off-by: Charles Thao <cthao@redhat.com>
* feat(ws): Add properties tile to new workspace creation
Signed-off-by: Hen Schwartz (EXT-Nokia) <hen.schwartz@nokia.com>
* feat(ws): Add properties tile to new workspace creation
Signed-off-by: Hen Schwartz (EXT-Nokia) <hen.schwartz@nokia.com>
* feat(ws): Add properties tile to new workspace creation
Signed-off-by: Hen Schwartz (EXT-Nokia) <hen.schwartz@nokia.com>
* feat(ws): Add properties tile to new workspace creation
Signed-off-by: Hen Schwartz (EXT-Nokia) <hen.schwartz@nokia.com>
---------
Signed-off-by: Hen Schwartz (EXT-Nokia) <hen.schwartz@nokia.com>
Co-authored-by: Hen Schwartz (EXT-Nokia) <hen.schwartz@nokia.com>
Jenny
Charles Thao
Guilherme Caponetto
Liav Weiss
Mathew Wicks
Andy Stoneberg
Jiri Daněk
Paulo Rego
aviavissar
yehudit1987
Mohamed
henschwartz
Yossi Elias