Given we have migrated all our images from docker.io to ghcr.io - our `notebooks-v2` branch should reference the "proper" container registry.
This commit updates the code to use:
- `ghcr.io/kubeflow/kubeflow/notebook-servers`
Affected areas:
- `jupyterlab_scipy_180` and `jupyterlab_scipy_190` `imageConfig` entries
- various test files
Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
* Add routes for Workspace Kind Create
Signed-off-by: Charles Thao <cthao@redhat.com>
* Implement method selection step for Workspace Kind Create wizard
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add styling
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add type guards for yaml file upload
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add properties step to WorkspaceKindForm
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add image step to WorkspaceKindForm
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add empty steps and switch Method step to radio buttons
Signed-off-by: Charles Thao <cthao@redhat.com>
* Add step description to Workspace Kind Form
Signed-off-by: Charles Thao <cthao@redhat.com>
* Migrate Workspace Kind Form to utilize Toggle Group
Signed-off-by: Charles Thao <cthao@redhat.com>
* Disable Form View when YAML is not uploaded or valid
Signed-off-by: Charles Thao <cthao@redhat.com>
* Allow VScode to discover local ESLint rules
Signed-off-by: Charles Thao <cthao@redhat.com>
* Styling organization improvements + Refactor types
Signed-off-by: Charles Thao <cthao@redhat.com>
---------
Signed-off-by: Charles Thao <cthao@redhat.com>
* Minor refactorings and initial work for the Workspace Kind summary page
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat(ws): added links from workspace kind details drawer to workspace kinds details page (#1)
Signed-off-by: Paulo Rego <832830+paulovmr@users.noreply.github.com>
* Enable workspace filtering by namespace in the WorkspaceKind summary page
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Update Pause/Start action response types according to backend
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Fix WorkspaceKind logo href
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Replace placeholders for GPU data with real values in WorkspaceKind summary page
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Allow columns to be hidden in the WorkspaceTable
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat(ws): added links from workspace kind details drawer namespace tab to workspace kinds details page (#2)
Signed-off-by: Paulo Rego <832830+paulovmr@users.noreply.github.com>
* Improve types around Filter component
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat: Add Workspace Actions Context and related components
- Introduced WorkspaceActionsContext to manage workspace actions such as view, edit, delete, start, restart, and stop.
- Created WorkspaceActionsContextProvider to encapsulate the context logic and provide it to child components.
- Implemented WorkspaceKindSummary and Workspaces components to utilize the new context for handling workspace actions.
- Added polling for refreshing workspaces at a default interval.
- Enhanced WorkspaceTable to support row actions for workspaces.
- Updated various components to include sortable and filterable data fields.
- Refactored WorkspaceStartActionModal and WorkspaceStopActionModal to handle optional onActionDone callback.
- Added loading and error handling components for better user experience.
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat: Add buildWorkspaceList function and integrate into mockAllWorkspaces
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* refactor: Update mock data and formatting for workspace activity timestamps
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat: Implement usePolling hook and refactor workspace actions in Workspaces and WorkspaceKindSummary components
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* refactor: Update column key usage in ExpandedWorkspaceRow and adjust workspace actions visibility in Workspaces component
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Make mocked workspace list deterministic
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* feat: Enhance WorkspaceTable with additional columns and filtering capabilities
- Added 'namespace', 'gpu', and 'idleGpu' columns to WorkspaceTable.
- Updated filtering logic to support new columns in WorkspaceTable.
- Refactored useWorkspaces hook to remove unnecessary parameters related to idle and GPU filtering.
- Modified WorkspaceKindSummary and its expandable card to utilize new filtering functionality.
- Updated WorkspaceUtils to include a method for formatting workspace idle state.
- Adjusted Filter component to support generic filtered column types.
- Updated Workspaces page to hide new columns as needed.
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* refactor: Improve sorting functionality in WorkspaceTable by utilizing specific types for sortable columns
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Adjustments after rebase
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
* Format with prettier
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
---------
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Paulo Rego <832830+paulovmr@users.noreply.github.com>
Co-authored-by: Paulo Rego <832830+paulovmr@users.noreply.github.com>
* chore(ws): comment workspace details logs tab while it is not supported
Signed-off-by: paulovmr <832830+paulovmr@users.noreply.github.com>
* chore(ws): comment workspace details pod template tab while it is not supported
Signed-off-by: paulovmr <832830+paulovmr@users.noreply.github.com>
---------
Signed-off-by: paulovmr <832830+paulovmr@users.noreply.github.com>
- Updated swaggo/swag from v1.16.4 to v1.16.6 in go.mod and Makefile.
- Added required fields to various OpenAPI definitions in docs.go and swagger.json for better validation via `--requiredByDefault` flag
- `swag` `v1.16.6` contains a commit we authored to treat `json:omitempty` as `required: false`. That, in conjunction with `--requiredByDefault` flag, allows us to generate models with proper _required-ness_
Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
- added @ID annotations for all API routes to populate operationId Swagger attribute
- split GetWorkspacesHandler into 2 separate handlers to account for @ID needing to be unique-per-route
- GetAllWorkspacesHandler now services GET /workspaces
- GetWorkspacesByNamespaceHandler now services GET /workspaces/{namespace}
- non-exported getWorkspacesHandler function contains all business logic that existed in GetWorkspacesHandler
- Adjusted test cases to align with the new handler names.
Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
remove comment
fix(ws): remove set to first page when filters applied
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
fix tests for filterWorkspacesTest
fix single filter test
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
fix bug in ws kind table
related: #298
- Added PauseActionWorkspaceHandler to handle pausing or unpausing a given workspace
- Introduced single new route for starting and pausing workspaces in the API.
- `api/v1/workspaces/{namespace}/{name}/actions/pause`
- pausing or unpausing operation is specified in the request payload
- Created a new WorkspaceActionPauseEnvelope type for successful responses.
- Leveraging JSONPatch / client.RawPatch to ensure Workspace in "valid state" before attempting action
- for `start`: `spec.paused` must be `true`, and `status.state` must be `Paused`
- for `pause`: `spec.paused` must be `false`
- note: I would love to have a `status.state` check here of `status.state != Paused`, but that type of comparison is not supported in [JSONPatch](https://datatracker.ietf.org/doc/html/rfc6902#section-4.6)
- Added tests for the new API, including success and error cases.
- Updated README/OpenAPI documentation to include the new endpoints.
---
As an interesting "edge case" worth calling out, the following payload is currently honored by the API:
```
{
"data": {}
}
```
Given the `WorkspaceActionPause` struct is simply `{"paused": true|false}`, the "empty" Envelope presented above deserializes the JSON using the zero value of `bool` (which is `false`).
Our validation today is always performed against the **deserialized** object, and as such impossible to distinguish the following cases:
```
{
"data": {}
}
```
vs
```
{
"data": {
"paused": false
}
}
```
The effort and (relative) complexity to prevent this and return a `422` in this scenario was not deemed "worth it" for the time being. As a result, a test case has been added for this specific scenario to at minimum document this "strange" behavior.
- Clients, however, should **NOT** rely on this behavior and always provide a fully defined `WorkspaceActionPause` JSON object to ensure future compatibility.
Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
fix(ws): remove extra DrawerPanelBody
remove unused file
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
fix(ws): remove comment and hide drawer on previousStep callback
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com>
fix(ws): when navigating between wizard steps, show drawer for steps that have drawer content
Liav Weiss