Commit Graph

8 Commits

Author SHA1 Message Date
Tobias Goerke 0e787960f5 fix: local var shadowing import (kubeflow/kubeflow#7375)
resolves #7373
2023-10-23 18:05:08 +00:00
Tobias Goerke 7286a41656 fix: KeyError on KF 1.8 (kubeflow/kubeflow#7335)
This change fixes an error 500 on notebook creation
2023-10-13 08:45:52 +00:00
Kimonas Sotirchos 0dc4261955 Fix Python linting (kubeflow/kubeflow#7060)
* gh-action: Workflow for testing python lint

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* lint: Run autopep8 to lint files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* linting: Manual changes

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

---------

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2023-03-30 09:32:05 +00:00
Elena Zioga c0f00e836b jwa: Improve how JWA exposes errors (kubeflow/kubeflow#6952)
* web-apps(front): Fix status case

* Fix the status case to properly show the warning icon when the status
  phase is warning.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify status-icon component

* Modify the status-icon component to follow the status cases.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify status component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce status-info component

* Have an admonition in the details page of each Notebook with a
  detailed message on the current status.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Extend process_status function

The process_status parses the status by:
- Checking the .status.containerState.
- Checking the .status.conditions, since they have the one-liner reason
  and a message.
- If none of the above exist, it will use the Events emitted for the
  notebook.
- In case it deduces the status from an Event and it's not available
  anymore, it uses a generic message.

Also, add a 10 second delay to the backend logic where we display a
spinner and a generic message to prevent a warning icon from appearing
immediately after a notebook is initialized.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Extend getNotebook request

* Extend the getNotebook request to also include the processed status
  information in the Notebook details page.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Extend the frontend

Extend the frontend by:
- Adding an admonition with a detailed message on the current status
  bellow the notebook name.
- Adding the processed_status field.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix unit tests

Fix unit tests accordingly.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa: Don't show the popup when a notebook is being stopped

* Use the waiting status, which also uses the spinner, when a notebook
  is being stopped.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update lib-status-icon

Signed-off-by: Elena Zioga <elena@arrikto.com>

* fixup! jwa(back): Extend getNotebook request

* fixup! jwa(back): Extend process_status function

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-23 15:23:22 +00:00
Kimonas Sotirchos e9b1bfca5c fix(web-apps): Use Angular's i18n proposed implementation (kubeflow/kubeflow#6065)
* jwa(front): Add i18n for french in angular.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Add i18n rules in package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormImage

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormAdvancedOptions

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormAffinityTolerations

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormConfigurations

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormCpuRam

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormDataVolumes

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormGpus

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FromName

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormWorkspaceVolume

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n Volume

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n BackendService

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): Add localize to peerDependencies

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): Import $localize in library

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n RokService

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n Form

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n BackendService

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n ConfirmDialog

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n Index

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n ResourceTable

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n SnackBar

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n Form

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-app(front): i18n NameNamespaceSelector

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): Remove ngx-translate

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n App

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Remove ngx-translate from package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(back): Don't parse keys in status

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(back): Revert backend messages

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Update translation language files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(back): Don't parse keys in status

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add i18n for french in angular.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add i18n rules in package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): i18n Form

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): i18n Index

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): i18n BackendService

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): i18n App

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Remove ngx-translate from package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): i18n Form

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Update translation language files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(back): Revert backend messages

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): Add i18n rules in package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): Add i18n for french in angular.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): i18n Index

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): i18n BackendService

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): i18n App

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): Update translation language files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): Remove ngx-translate from package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* wa: Update READMEs

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): Add localize when testing

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-08-12 05:13:03 -07:00
Wendy Gaultier 9f0334174c CRUD web apps: i18n (kubeflow/kubeflow#5880)
* feat(jupyter): add modules for translations

* feat(jupyter): fix path for translations + add GPU translations

* feat(jupyter): add translations

* feat(jupyter): add translations to form-default

* feat(jupyter): add translations to affinity/tolerations

* feat(jupyter): add translations to Image Pull Policy

* feat(jupyter): remove imports from app.module.ts + fix translations

* web-apps(front): add TranslationModule to common for jupyter

* Implement i18n for jupyter frontend
- Including common components needed
- Refactor translation file

* web-apps(front): add i18n to messages from backend
Status tooltip text
Snackbar message

* web-apps(front): volumes and tensorboards i18n ini
Add the i18n feature for the other 2 projects

* feat(volume): add translations for volume

* feat(jupyter): refactor asset file

* Update asset files for all folders

* feat(tensorboards): add i18n
Update all asset files

* cwa: add new translations

* cwa: Add README documentation

* fix: formatting with prettier

* Fix tests

* Fix python format

* remove comment

Co-authored-by: saffaalvi <alvi118@uwindsor.ca>
Co-authored-by: Jose-Matsuda <tongster789@gmail.com>
2021-06-21 07:26:17 -07:00
Kimonas Sotirchos 9593da2cd3 Initialize the Jupyter web app frontend in crud-web-apps (kubeflow/kubeflow#5332)
* Update the backend

For the frontend to work properly we will need to add the following
changes to jupyter web app's backend as well as to the common backend
code:
* rename the references from `flask_rest_backend` to `crud_backend` in
  the web app's backend code
* add a route for exposing GPU info. This way the UI will block users
  from creating Notebooks with a GPU type that is not installed at all
  in the cluster

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Update the common frontend library

New functionality added:
* An `Advanced Settings` button that can expand and shrink to
  expose/hide more options in the form
* All validators will have a debounce time to make the input of
  characters smoother
* Extend the Status types to allow start/stopped resources
* Extend the main table config to support a button [ ex CONNECT for
  jupyter web app ]
* The http services should use relative URLs

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Update the frontend to utilize the common code

The bulk of the new frontend code. The folder structure is changed to
make it more clear what pages are used from the page.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* {Make,Docker}files

Add Makefile and Dockerfiles. Note that GCB build process needs to be
updated.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* README.md

Add a readme that explains how to build the app and have a development
environment.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2020-10-27 07:45:59 -07:00
Kimonas Sotirchos 5d84874fc4 Refactor the JWA backend to utilize common code (kubeflow/kubeflow#5316)
* WA: Backend common: update the library

Update the common python wheel wrt:
* How to distinguish between dev and prod mode
* Extra routes for handling Notebooks
* Serving the index.html for every non api route (SPA)
* Add a STOPPED state to the possible Status values

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* JWA: Add the refactored backend

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* JWA: Backend: Add support for Affinity/Tolerations

* Extend the configuration yaml with default form values for the
  affinity/tolerations
* Set them accordingly when the user submits a notebook

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
2020-09-29 02:37:25 -07:00