- added @ID annotations for all API routes to populate operationId Swagger attribute
- split GetWorkspacesHandler into 2 separate handlers to account for @ID needing to be unique-per-route
- GetAllWorkspacesHandler now services GET /workspaces
- GetWorkspacesByNamespaceHandler now services GET /workspaces/{namespace}
- non-exported getWorkspacesHandler function contains all business logic that existed in GetWorkspacesHandler
- Adjusted test cases to align with the new handler names.
Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
* feat(ws): Notebooks 2.0 // Backend // List Workspaces API - II
In this PR:
- FUP for Notebooks 2.0 // Backend // List Workspaces API (#60) review
- Create /api/v1/workspaces to return all workspaces
- Review API endpoints as requested
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
* Notebooks 2.0 // Backend // CRUD Workspaces API
In this PR:
- Created handlers and repositories for create, get and delete workspace
- Improved the type of our json response
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
* feat(ws): Notebooks 2.0 // Backend // List WorkspaceKinds
This PR builds on top of: https://github.com/kubeflow/notebooks/pull/61 and https://github.com/kubeflow/notebooks/pull/65
In this PR:
- Created handlers and repositories for get workspacekinds
This PR closes https://github.com/kubeflow/notebooks/issues/51
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
* mathew: fix linting
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
---------
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Andy Stoneberg
asaadbalum
Liav Weiss
Mohamed
Mathew Wicks
Eder Ignatowicz