Commit Graph

10 Commits

Author SHA1 Message Date
Saffa Alvi 1e7fbce505 feat(jupyter): add fonts as assets to service (kubeflow/kubeflow#5691)
* cwa(front): Ignore font files in assets

* feat(jupyter): add fonts as assets to service

* CRUD: fonts in common

* CWA: Remove link to css file

* jwa(front): Remove font assets from jupyter

Co-authored-by: Wendy Gaultier <wvgaultier@gmail.com>
2021-06-02 10:44:35 -07:00
juliusvonkohout 2406692558 FIX The number of gpu must be set as string in Kubernetes/Openshift (kubeflow/kubeflow#5891)
* Update form.py

* Update form.py

* Update form-default.component.ts

* fix whitespace issue
2021-06-02 10:28:35 -07:00
Kimonas Sotirchos 0a7ba3170b JWA: Don't override assets with logos ConfigMap (kubeflow/kubeflow#5942)
* jwa(front): Add static logos in the app

The app does not contain the logos' svgs in its source code/static
files. This results in the icons to not show when developing locally.

This commit adds the svgs found in the logos ConfigMap to the static
files of the app as well.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Change logos fetch url

Change the URLs of the logos from `static/assets/*` to
`static/assets/logos`.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(manifests): Don't override assets with logos

Mount the ConfigMap under the `static/assets/logos` directory to not
override the contents of the entire assets dir.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-05-31 01:36:03 -07:00
DavidSpek fe2789b9d4 Make notebook limits configurable with a multiplication factor (kubeflow/kubeflow#5815)
* Make notebook limits configurable with a multiplication factor

* Make limits configurable under advanced section

* run prettier to format frontend code

* fix formatting and add rounding in backend

* Return error if limit is smaller than request

* Allow disabling limitFactor by setting it to none

* review: remove camelCase in python backend

* fix: update spawner_ui_config.yaml in manifests directory

* review: fix setting limits backend

* review: remove unnecessary check from backend
2021-04-13 08:40:11 -07:00
DavidSpek 2570a8eea4 Remove Logo Trademarks from the Jupyter Web App and make logos configurable (kubeflow/kubeflow#5823)
* rebase: Make logos configurable in configmap and remove trademark references

Rebased to remove the changes to the package-lock.json

* review: add suggested changes and add image group section to README
2021-04-13 05:04:04 -07:00
Kimonas Sotirchos 149a986d3d Add CI format checks for the Jupyter web app (kubeflow/kubeflow#5811)
* jwa(front): Add npm rule for checking the format

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* ci: Add common tasks for format checks

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* ci(jwa): Add format check tasks

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(back): Fix formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Fix formatting

Run `npm run format:write` on frontend

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Include prettier in package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(docker): Don't copy node_modules in Dockerfile

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps: Add global dockerignore file

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa: Remove unused dockerignore file

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(make): Don't include dockerignore and cleanup

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-04-08 03:51:02 -07:00
DavidSpek b89ce2ce21 (JWA): Add RStudio trademark statement in Notebook Spawner UI (kubeflow/kubeflow#5758)
* Add RStudio trademark statement

* move tooltip position to the right of the RStudio button

* fix labels of icons

* RStudio trademark tooltip on index page, remove title jupyter-icon
2021-03-23 13:05:44 -07:00
DavidSpek 90a8e02fc1 (JWA): Add server type selector for jupterlab, vs-code and r-studio (kubeflow/kubeflow#5646)
* jwa(back): ability to setting annotations on NB resource

* jwa(back): update spanwer yaml, dump logo from yaml if file doesn't exist

* jwa(front): add annotations and VSCode/RStudio image types/config

* jwa(front): add server type toggle to UI

* jwa(front): set annotations in notebook request based on server-type

* jwa(front): add server type column to index page

* review: improve button toggle formatting

* jwa(back): set rstudio-tidyverse image in spawner_ui_config

* review: move rewrite and headers to backend

* review: add logo SVGs and set them in environment*.ts

* review: fix how allowing custom images works

* review: add server type logo to index
2021-03-22 05:09:18 -07:00
Kimonas Sotirchos 9580c16791 web-apps(front): Update the common frontend library (kubeflow/kubeflow#5463)
* web-apps(front): Udate the common library

Add new components to the library. These components will enhance
* The current common table for visualizing objects
* The components we can use for a details-page for each object

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): Add unit tests to common lib

Fix and introduce new unit tests for most of the components in the
library. We expect the developers to always run `ng test` before any PR
to ensure that the existing functionality is not broken.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Add required packages for common lib

The common library will expect extra npm modules to be installed in each
app that consumes it.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2020-12-21 05:06:25 -08:00
Kimonas Sotirchos 9593da2cd3 Initialize the Jupyter web app frontend in crud-web-apps (kubeflow/kubeflow#5332)
* Update the backend

For the frontend to work properly we will need to add the following
changes to jupyter web app's backend as well as to the common backend
code:
* rename the references from `flask_rest_backend` to `crud_backend` in
  the web app's backend code
* add a route for exposing GPU info. This way the UI will block users
  from creating Notebooks with a GPU type that is not installed at all
  in the cluster

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Update the common frontend library

New functionality added:
* An `Advanced Settings` button that can expand and shrink to
  expose/hide more options in the form
* All validators will have a debounce time to make the input of
  characters smoother
* Extend the Status types to allow start/stopped resources
* Extend the main table config to support a button [ ex CONNECT for
  jupyter web app ]
* The http services should use relative URLs

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Update the frontend to utilize the common code

The bulk of the new frontend code. The folder structure is changed to
make it more clear what pages are used from the page.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* {Make,Docker}files

Add Makefile and Dockerfiles. Note that GCB build process needs to be
updated.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* README.md

Add a readme that explains how to build the app and have a development
environment.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2020-10-27 07:45:59 -07:00