Commit Graph

4 Commits

Author SHA1 Message Date
Elena Zioga c0f00e836b jwa: Improve how JWA exposes errors (kubeflow/kubeflow#6952)
* web-apps(front): Fix status case

* Fix the status case to properly show the warning icon when the status
  phase is warning.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify status-icon component

* Modify the status-icon component to follow the status cases.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify status component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce status-info component

* Have an admonition in the details page of each Notebook with a
  detailed message on the current status.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Extend process_status function

The process_status parses the status by:
- Checking the .status.containerState.
- Checking the .status.conditions, since they have the one-liner reason
  and a message.
- If none of the above exist, it will use the Events emitted for the
  notebook.
- In case it deduces the status from an Event and it's not available
  anymore, it uses a generic message.

Also, add a 10 second delay to the backend logic where we display a
spinner and a generic message to prevent a warning icon from appearing
immediately after a notebook is initialized.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Extend getNotebook request

* Extend the getNotebook request to also include the processed status
  information in the Notebook details page.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Extend the frontend

Extend the frontend by:
- Adding an admonition with a detailed message on the current status
  bellow the notebook name.
- Adding the processed_status field.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix unit tests

Fix unit tests accordingly.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa: Don't show the popup when a notebook is being stopped

* Use the waiting status, which also uses the spinner, when a notebook
  is being stopped.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update lib-status-icon

Signed-off-by: Elena Zioga <elena@arrikto.com>

* fixup! jwa(back): Extend getNotebook request

* fixup! jwa(back): Extend process_status function

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-23 15:23:22 +00:00
Elena Zioga 8af965fb9b jwa(front): Fix the workspace volume form's inputs (kubeflow/kubeflow#7029)
* jwa(front): Fix the size input value

The size form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix the access-mode input value

The access mode form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix the name input value

The name form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Use 5Gi everywhere

All new volumes will have a default value of 5Gi. This includes the 'Add
new volume' button for both the workspace and data volumes.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Add UI tests with Cypress

Add integration tests with Cypress to ensure that the form will have the
correct values once it gets the ConfigMap.

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-22 13:57:43 +00:00
Elena Zioga 85f262abb9 jwa: Remove all the Rok references (kubeflow/kubeflow#6985)
* jwa(front): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-06 10:06:35 +00:00
Orfeas Kourkakis c7e03bbaba jwa(front): Add UI tests with Cypress (kubeflow/kubeflow#6891)
* jwa(front): Add integration tests with Cypress

 - Upgrade Cypress to version ^10.10.0
 - Add integration tests with Cypress to check that:
   * Index page renders every Notebook name into the table
   * Index page shows correct Status icon for all notebooks

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(jwa): Add UI tests to JWA's frontend workflow

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* fixup! gh-actions(jwa): Add UI tests to JWA's frontend workflow

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-16 11:03:00 +00:00