Commit Graph

4 Commits

Author SHA1 Message Date
Elena Zioga c0f00e836b jwa: Improve how JWA exposes errors (kubeflow/kubeflow#6952)
* web-apps(front): Fix status case

* Fix the status case to properly show the warning icon when the status
  phase is warning.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify status-icon component

* Modify the status-icon component to follow the status cases.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify status component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce status-info component

* Have an admonition in the details page of each Notebook with a
  detailed message on the current status.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Extend process_status function

The process_status parses the status by:
- Checking the .status.containerState.
- Checking the .status.conditions, since they have the one-liner reason
  and a message.
- If none of the above exist, it will use the Events emitted for the
  notebook.
- In case it deduces the status from an Event and it's not available
  anymore, it uses a generic message.

Also, add a 10 second delay to the backend logic where we display a
spinner and a generic message to prevent a warning icon from appearing
immediately after a notebook is initialized.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Extend getNotebook request

* Extend the getNotebook request to also include the processed status
  information in the Notebook details page.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Extend the frontend

Extend the frontend by:
- Adding an admonition with a detailed message on the current status
  bellow the notebook name.
- Adding the processed_status field.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix unit tests

Fix unit tests accordingly.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa: Don't show the popup when a notebook is being stopped

* Use the waiting status, which also uses the spinner, when a notebook
  is being stopped.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update lib-status-icon

Signed-off-by: Elena Zioga <elena@arrikto.com>

* fixup! jwa(back): Extend getNotebook request

* fixup! jwa(back): Extend process_status function

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-23 15:23:22 +00:00
Elena Zioga e7a1d7d288 vwa: Remove all the Rok references (kubeflow/kubeflow#6984)
* vwa(front): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(back): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(build): Update Dockerfile

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-06 10:22:35 +00:00
Orfeas Kourkakis 6a02712226 vwa(front): Prevent PVCs from being deleted when there is a corresponding notebook (kubeflow/kubeflow#6899)
* vwa(back): Append notebooks using each PVC

Append notebooks using each PVC when getting and parsing all PVCs.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Create custom delete action column

Create custom delete column component that extends ActionComponent from
Kubeflow common code and adds the following functionalities:

* Disable the button when a row's notebooks array is not empty
* Display an appropriate message including the notebooks' names

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add delete button component in index page

Implement custom delete column in the table in VWA's index page.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add Used by column in volumes table

Add a Used by column in volumes table of VWA's index page in order to
link to the notebooks that are using each PVC.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Fix integration tests

Update mock request for PVCs

Refs arrikto/dev#2017
Refs arrikto/dev#2135

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Fix format error

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

---------

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-30 10:02:05 +00:00
Orfeas Kourkakis cf5301b10a vwa(front): Add UI tests with Cypress (kubeflow/kubeflow#6862)
* web-apps(front): Remove Protractor files

Remove Protractor files since it's not used anywhere in the common
code.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Add Cypress attributes

Add more attributes and modify some existing ones for elements to be
selectable during UI tests with Cypress.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Install Cypress

 - Install Cypress & npm scripts for UI tests
 - Remove Protractor files
 - Update README.md with UI tests instructions

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add UI tests with Cypress

 - Add Cypress attributes for elements to be selectable during
   UI tests.
 - Add UI tests with Cypress to check that:
    * New Volume form dialog has proper values
    * Index page table contains all PVC names received
    * Index page table status icons are correctly shown
    * Index page table browse buttons are correctly shown

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(vwa): Add UI tests to VWA's frontend workflow

Add UI tests to VWA's frontend workflow. These tests should run in
Ubuntu 20.04 since Ubuntu 20.04 includes both Chrome and Firefox
installations by default.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix formatting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Fix format errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-03 13:11:24 +00:00