aa26b048b9
chore: update controller manifests to follow conventions
...
This commit brings about various changes to improve naming consistency across the `workspaces/` components.
The original `controller/` manifests were generated by kubebuilder and were not aligned with the conventions we have established in the `backend` and `frontend` components. Changing the manifests also had a "trickle effect" of requiring minor modifications to the `Makefile` as well as some e2e tests and documentation.
Key manifest changes:
- dropped `namePrefix` transformation
- standardized on `kubeflow-workspaces` namespace
- leveraged name of `workspaces-controller` where sensible
- Standardized `app.kubernetes.io/*` labels across all resources
- leveraging `labels` transformation as much as possible
- selectively applied `includeSelectors: true` when appropriate
- Removed legacy control-plane=controller-manager labels
- replaced with appropriate `app.kubernetes.io/*` labels to keep behavioral parity
Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
2025-09-18 17:05:47 -04:00
bc4e4454bc
feat(ws): add validation webhooks for Workspace and WorkspaceKind ( #34 )
...
* add validating webhook
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
* add tests for workspacekind and workspace webhooks
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
* re-add cert-manager
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
* refactor ValidateCreate and ValidateUpdate functions in wokrspaceKind webhook
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
* add e2e test for webhooks
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
* mathew refactor 1
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
* mathew refactor 2
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
* mathew refactor 3
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
---------
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
2024-08-29 00:14:03 +00:00
0ff4d0371a
feat(ws): add `Workspace` and `WorkspaceKind` CRD scaffolds ( #6 )
...
* feat(ws): add `Workspace` and `WorkspaceKind` CRD scaffolds
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
* fixup, regenerate WOrkspaceKind to be cluster scope
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
* fixes to crd spec
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
* updates to CRD spec
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
---------
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
2024-06-19 01:00:59 +00:00
20a3de3bd7
feat(ws): initial commit for controller ( #5 )
...
* feat: Generate kubebuilder project
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
* fixup add unittests gha
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
* fixup disable permissions for all of the available scopes
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
* fixup add triggers for release branches
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
* fixup remove duplicated gitignores
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
* fixup remove workflow dispatch
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
* Apply suggestions from code review
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
* fixup rename the project to workspace-controller
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
* fixup update kubebuilder to 3.15
https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v3.15.0
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
---------
Signed-off-by: Jiri Daněk <jdanek@redhat.com>
2024-05-23 18:36:26 +00:00
Andy Stoneberg