Commit Graph

10 Commits

Author SHA1 Message Date
Elena Zioga cca60b7d26 jwa(front): Fix unit tests (kubeflow/kubeflow#6804)
* jwa(front): Rename form-default component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Create missing module files

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Remove form-rok and form components

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Update JWA's @angular/common package

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify rok-url component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add Rok URL message

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update VWA's @angular/common package

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Remove the headers request

Remove the headers request since the common code implements it.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix JWA's unit tests

Fix JWA's unit tests.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* gh-actions: Add GH action to run JWA unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(build): Update Dockerfile

Update Dockerfile to not build Rok.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-07 12:49:38 +00:00
Pranav Pandit d83d55a892 updated compatible base images & removed arch dependencies in different components for multiple arch support (kubeflow/kubeflow#6650)
* updated base images in Volume Web component for multiple arch

* updated base images in Tensorboard Web component for multiple arch

* updated base images in Jupyter Web component for multiple arch

* updated admission webhook component for multiple arch

* removed goarch depedency for multiarch building

* removed goarch depedency for multiarch building in admission webhook component

* removed goarch depedency & added powerPC case for multiarch building in access-management component

* removed goarch depedency for multiarch building in tensorboard controller

* removed goarch depedency for multiarch building in notebook Controller

* Removing empty computation to resolve future build issues
2022-11-23 13:42:42 +00:00
Xiangquan Xiao 1d16e6aaab Bump Jupyter web app to Python 3.8. (kubeflow/kubeflow#6562) 2022-07-25 12:15:12 +00:00
Kimonas Sotirchos 5da1860f4a Don't use asterisk in Dockerfiles (kubeflow/kubeflow#6318)
* wa(docker): Don't copy node_modules

To ensure Kaniko is not copying stale node_moduels folders, even though
we have a dockerignore file, we are explicitly only copying the source
code.

We have seen the build system with Kaniko to fail, due to NFS stale
instances with files in node_modules and expect that this is the root
cause.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa: Update makefile to use global dockerignore

The dockerfile for TWA was copying over the local dockerignore. This was
overriding the global one we had for all the web apps.

This commit updates the Makefile of the app to use the global
dockerignore that all the apps should use.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2022-01-26 21:52:10 +00:00
Kimonas Sotirchos 33fea6f503 Add CI format checks for the Volumes web app (kubeflow/kubeflow#5820)
* vwa(front): Add npm script to check the formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Update the package-lock.json

Run `npm install` to bring the package-lock.json up to date

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Fix formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(back): Fix formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(docker): Remove unused dockerignore file

We have created a global dockerignore file for all the web apps in the
parent dir.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(docker): Don't copy node_modules in dockerfile

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(make): Don't include dockerignore

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* ci(vwa): Add format check tasks

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(docker): Copy only necessary files for build

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* review: Use docker context instead of cd ..

Don't use a `cd ..` and copy dockerignore files back and forth. Instead
we should use the Docker context and the global dockerignore file we
have for all the web apps.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-05-17 08:25:31 -07:00
Kimonas Sotirchos 149a986d3d Add CI format checks for the Jupyter web app (kubeflow/kubeflow#5811)
* jwa(front): Add npm rule for checking the format

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* ci: Add common tasks for format checks

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* ci(jwa): Add format check tasks

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(back): Fix formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Fix formatting

Run `npm run format:write` on frontend

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Include prettier in package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(docker): Don't copy node_modules in Dockerfile

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps: Add global dockerignore file

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa: Remove unused dockerignore file

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(make): Don't include dockerignore and cleanup

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-04-08 03:51:02 -07:00
DavidSpek 738e438c98 Fix entrypoint of crud-jwa (kubeflow/kubeflow#5606)
* Fix entrypoint of crud-jwa

* remove APP_PREIX ENV variable from entrypoint
2021-03-02 04:31:47 -08:00
DavidSpek 4ec593159f Move JWA python images to slim-buster (kubeflow/kubeflow#5555) 2021-01-27 10:37:07 -08:00
DavidSpek b9917b8507 Use node:12 as specified in the docs (kubeflow/kubeflow#5522)
* Use node:12 as specified in the docs

* Move to buster-slim

Move images that build the kubeflow library and frontend to buster-slim to reduce image size. Tested with the Jupyter Web App, assumed to also work for Tensorboards Web App once https://github.com/kubeflow/kubeflow/issues/5529 is solved.
2021-01-25 10:22:54 -08:00
Kimonas Sotirchos 9593da2cd3 Initialize the Jupyter web app frontend in crud-web-apps (kubeflow/kubeflow#5332)
* Update the backend

For the frontend to work properly we will need to add the following
changes to jupyter web app's backend as well as to the common backend
code:
* rename the references from `flask_rest_backend` to `crud_backend` in
  the web app's backend code
* add a route for exposing GPU info. This way the UI will block users
  from creating Notebooks with a GPU type that is not installed at all
  in the cluster

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Update the common frontend library

New functionality added:
* An `Advanced Settings` button that can expand and shrink to
  expose/hide more options in the form
* All validators will have a debounce time to make the input of
  characters smoother
* Extend the Status types to allow start/stopped resources
* Extend the main table config to support a button [ ex CONNECT for
  jupyter web app ]
* The http services should use relative URLs

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Update the frontend to utilize the common code

The bulk of the new frontend code. The folder structure is changed to
make it more clear what pages are used from the page.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* {Make,Docker}files

Add Makefile and Dockerfiles. Note that GCB build process needs to be
updated.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* README.md

Add a readme that explains how to build the app and have a development
environment.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2020-10-27 07:45:59 -07:00