Commit Graph

4 Commits

Author SHA1 Message Date
Pranav Pandit d83d55a892 updated compatible base images & removed arch dependencies in different components for multiple arch support (kubeflow/kubeflow#6650)
* updated base images in Volume Web component for multiple arch

* updated base images in Tensorboard Web component for multiple arch

* updated base images in Jupyter Web component for multiple arch

* updated admission webhook component for multiple arch

* removed goarch depedency for multiarch building

* removed goarch depedency for multiarch building in admission webhook component

* removed goarch depedency & added powerPC case for multiarch building in access-management component

* removed goarch depedency for multiarch building in tensorboard controller

* removed goarch depedency for multiarch building in notebook Controller

* Removing empty computation to resolve future build issues
2022-11-23 13:42:42 +00:00
Kimonas Sotirchos 5da1860f4a Don't use asterisk in Dockerfiles (kubeflow/kubeflow#6318)
* wa(docker): Don't copy node_modules

To ensure Kaniko is not copying stale node_moduels folders, even though
we have a dockerignore file, we are explicitly only copying the source
code.

We have seen the build system with Kaniko to fail, due to NFS stale
instances with files in node_modules and expect that this is the root
cause.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa: Update makefile to use global dockerignore

The dockerfile for TWA was copying over the local dockerignore. This was
overriding the global one we had for all the web apps.

This commit updates the Makefile of the app to use the global
dockerignore that all the apps should use.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2022-01-26 21:52:10 +00:00
Kimonas Sotirchos 33fea6f503 Add CI format checks for the Volumes web app (kubeflow/kubeflow#5820)
* vwa(front): Add npm script to check the formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Update the package-lock.json

Run `npm install` to bring the package-lock.json up to date

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Fix formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(back): Fix formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(docker): Remove unused dockerignore file

We have created a global dockerignore file for all the web apps in the
parent dir.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(docker): Don't copy node_modules in dockerfile

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(make): Don't include dockerignore

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* ci(vwa): Add format check tasks

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(docker): Copy only necessary files for build

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* review: Use docker context instead of cd ..

Don't use a `cd ..` and copy dockerignore files back and forth. Instead
we should use the Docker context and the global dockerignore file we
have for all the web apps.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-05-17 08:25:31 -07:00
Kimonas Sotirchos a63eff43ed Volumes Management UI (kubeflow/kubeflow#5684)
* vwa(back): first commit of volumes web app backend

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): init code for volumes web app frontend

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa: {Make,Docker}files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa: gitignore

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa: README

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* review: Rename Jupyter to Volumes in README

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* review: Rephrase comment in default flavor

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* review: Remove snapshot reference from default flavor

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-03-18 01:07:16 -07:00