Commit Graph

3 Commits

Author SHA1 Message Date
Kimonas Sotirchos 766528e659 web-apps: Ensure in-flight requests are cancelled (kubeflow/kubeflow#6718)
* vwa(front): Use ng serve for local dev

Add proxy rules to connect the webpack dev server with the backend

* twa(front): Use ng serve for local dev

Refs arrikto/dev#1597

* vwa(back): Fix the install-deps make rule

Use the new common code path when installing the common packages.

* wa(front): Disable Angular analytics

Edit the angular.json file of all our frontend components to not send
Angular analytics. This way we won't be seeing a y/N input each time we
try to build the frontend, which could also block a CI/CD system.

* wa(front): Add exponential-backoff service

Create an Angular Service that handles the polling. Specifically the
polling function has as input an observable responsible for fetching the
data. It will return a final observable, which will be using the
fetch-observable, that will only be emitting the final data.

This service will take care of:
1. Checking if the new data is new and reset the polling
2. Cancelling in-flight requests, if someone terminates the subscription

* vwa(front): Use the new Polling Service

The frontend code of VWA will now be using the new Poller Service which
has a pure RxJS implementation underneath. This will make it simpler to
cancel in-flight requests and also moves the reset logic into the common
code.

* jwa(front): Use the new Polling Service

The frontend code of JWA will now be using the new Poller Service which
has a pure RxJS implementation underneath. This will make it simpler to
cancel in-flight requests and also moves the reset logic into the common
code.

* twa(front): Use the new Polling Service

The frontend code of TWA will now be using the new Poller Service which
has a pure RxJS implementation underneath. This will make it simpler to
cancel in-flight requests and also moves the reset logic into the common
code.
2022-11-10 14:37:00 +00:00
Kimonas Sotirchos facf6073e5 web-apps: Introduce an APP_SECURE_COOKIES env var (kubeflow/kubeflow#5764)
* web-apps(back): Introduce APP_SECURE_COOKIES var

Expose a new APP_SECURE_COOKIES env variable that will configure whether
the web apps should set Secure cookies or not.

This will allow the admins to configure the web apps to work when
Kubeflow is exposed over localhost/http.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(back): Switch CSRF checks order

The order the backend makes the CSRF checks should be the following:
1. check if the CSRF cookie is present
2. check if the CSRF header is present
3. check if the CSRF cookie and header have the same value

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps: Set APP_SECURE_COOKIES to false in dev

When running the web apps via the makefiles in dev mode we will need to
explicitly set the APP_SECURE_COOKIES env var to False, since the app
will be served over http.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-03-24 05:16:45 -07:00
Kimonas Sotirchos a63eff43ed Volumes Management UI (kubeflow/kubeflow#5684)
* vwa(back): first commit of volumes web app backend

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): init code for volumes web app frontend

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa: {Make,Docker}files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa: gitignore

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa: README

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* review: Rename Jupyter to Volumes in README

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* review: Rephrase comment in default flavor

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* review: Remove snapshot reference from default flavor

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-03-18 01:07:16 -07:00