Jaeyeon Kim
d987b24363
web-apps(front) : change error msg for min ( kubeflow/kubeflow#6193 )
2021-12-08 22:11:54 +00:00
Hao Xin
0346b82e43
chore(docs): It's better to refer to the cli documents, not repo's readme ( kubeflow/kubeflow#6239 )
2021-12-08 22:05:54 +00:00
Rohan Katkar
35188afc8e
add(web-apps): i18n Fr translations ( kubeflow/kubeflow#6122 )
2021-11-24 15:29:47 +00:00
juliusvonkohout
483cabb7e2
fix(backend): tensorboard-controller does not work because of missing permissions ( kubeflow/kubeflow#6216 )
2021-11-23 23:57:47 +00:00
James Liu
af5f419fd5
fix(web-apps): Use relative path for --deploy-url build. #5566 ( kubeflow/kubeflow#6206 )
...
* fix(web-apps): Use relative path for --base-href build
* volume web app should use volume base-href
2021-11-01 14:10:59 -07:00
juliusvonkohout
f2df5f5b84
fix: tensorboard-controller is killed due to out of memory ( kubeflow/kubeflow#6148 )
...
* Update manager.yaml
* Update manager.yaml
2021-10-19 21:07:15 -07:00
Kimonas Sotirchos
4b4001e108
Update Notebooks README regarding custom packages ( kubeflow/kubeflow#6176 )
...
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-10-11 20:34:43 -07:00
Kimonas Sotirchos
dacbda949d
Bump Golang version in PodDefaults, TensorBoard Controller and KFAM to 1.17 ( kubeflow/kubeflow#6180 )
...
* kfam: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* poddefaults: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* tensorboards: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-10-08 06:02:23 -07:00
Kimonas Sotirchos
eb68995189
jwa(front): Don't disable vendors with no GPUs ( kubeflow/kubeflow#6171 )
...
JWA should not block users from selecting GPUs if the current cluster
nodes do not have any GPUs attached to them. We've seen users that have
autoscaled nodegroups for GPUs, so a GPU node will be added to the
cluster once a Pod has requested it.
Refs: arrikto/dev#1484
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-10-07 06:23:23 -07:00
Mathew Wicks
dcec619962
Improve README for example-notebook-servers ( kubeflow/kubeflow#6165 )
2021-10-05 02:35:17 -07:00
David van der Spek
61cbfabb73
Fix notebook base image gpg keys ( kubeflow/kubeflow#6138 )
2021-09-13 11:49:31 -07:00
Abe Sharp
5e960331fd
Remove virtualservice timeout to prevent websocket disconnect ( kubeflow/kubeflow#6126 )
...
In the existing version, the 'timeout: 300s' added to the notebook's virtual service would cause websockets to disconnect at the 5 minute mark, causing the Jupyter Notebook web terminal function to hang. This is described in https://github.com/kubeflow/kubeflow/issues/6124 .
2021-09-09 03:07:01 -07:00
Abhishek Vilas Munagekar
76c6bc9b40
Fix NaN in Kubeflow Notebooks ( kubeflow/kubeflow#6092 )
...
* Fix NaN in Kubeflow Notebooks
* add a validation check for NaN values
* fix: validation check if value is None
* lint: fix line length
2021-08-16 10:26:06 -07:00
Kimonas Sotirchos
9c1c499f6d
fix(jwa): Fix limits calculation when limitFactor is none ( kubeflow/kubeflow#6058 )
...
* jwa(front): Don't allow NaN values in limits
The UI should always catch a NaN value and don't add it in the form.
Currently this is the case for the cpu/memory limits.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Limits should not be changed if dirty
If the user has manually edited the limits fields then the UI should not
try to automatically calculate them again, using the limitFactors.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-08-13 02:14:54 -07:00
Kimonas Sotirchos
e9b1bfca5c
fix(web-apps): Use Angular's i18n proposed implementation ( kubeflow/kubeflow#6065 )
...
* jwa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormImage
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormAdvancedOptions
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormAffinityTolerations
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormConfigurations
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormCpuRam
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormDataVolumes
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormGpus
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FromName
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormWorkspaceVolume
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Volume
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Add localize to peerDependencies
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Import $localize in library
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n RokService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n ConfirmDialog
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n ResourceTable
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n SnackBar
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-app(front): i18n NameNamespaceSelector
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Remove ngx-translate
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(back): Don't parse keys in status
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(back): Revert backend messages
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(back): Don't parse keys in status
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(back): Revert backend messages
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* wa: Update READMEs
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Add localize when testing
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-08-12 05:13:03 -07:00
Filinto Duran
5ae1de4dcc
Correct missing predicates in controller watches. Fixes #5326 ( kubeflow/kubeflow#5873 )
...
Co-authored-by: Filinto Duran <fduran@d2iq.com>
2021-08-11 09:17:26 -07:00
David van der Spek
941ec2e9ff
Update CRUD web apps from Angular 8 to Angular 12 ( kubeflow/kubeflow#6004 )
...
* common: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* common: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* common: remove entryComponents and replace TestBed.get with TestBed.inject
Edit files manually
* common: make compatible with Angular 9
Edit files manually
* common: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* update kubeflow-common project dependencies
* common: add @angular/localize
ng add @angular/localize
* jupyter: update angular core and cli 8
ng update @angular/core@8 @angular/cli@8
* jupyter: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* jupyter: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* jupyter: remove entryComponents
Edit file manually
* jupyter: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* jupyter: add @angular/localize
ng add @angular/localize
* tensorboards: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* tensorboards: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* tensorboards: remove entryComponents and replace TestBed.get with TestBed.inje…
Edit files manually
* tensorboards: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* tensorboards: add @angular/localize
ng add @angular/localize
* Fix tensorboards-web-app run-dev in makefile
Edit file manually
* volumes: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* volumes: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* volumes: remove entryComponents and replace TestBed.get with TestBe…
Edit files manually
* volumes: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* volumes: add @angular/localize
ng add @angular/localize
* common: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10 --force
* common: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* update kubeflow-common project dependencies
Edit file manually
* common: update fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* common: fix font location
Edit file manually
* jupyter: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* jupyter: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* jupyter: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* tensorboards: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* tensorboards: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* tensorboards: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* volumes: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* volumes: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* volumes: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* common: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* common: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* common: install @angular-devkit/core@11
npm install --save-dev @angular-devkit/core@11
* common: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* common: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* update kubeflow-common project dependencies
Edit file manually
* jupyter: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* jupyter: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* jupyter: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* jupyter: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* tensorboards: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* tensorboards: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* tensorboards: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* tensorboards: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* volumes: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* volumes: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* volumes: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* volumes: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* common: Fix CI failure
* jupyter: npm run format:write
npm run format:write
* volumes: npm run format:write
npm run format:write
* tensorboards: manually run prettier
prettier --write 'src/**/*.{js,ts,html,scss,css}'
* common: Fix MockComponent entryComponents for CI
Manually edit file
* common: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* common: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* common: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* update kubeflow-common project dependencies
Edit file manually
* common: fix Intl.DateTimeFormatOptions
Edit file manually. Type of defaultDateOptions and defaultTimeOptions needs to explicitly be set to Intl.DateTimeFormatOptions.
* jupyter: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* jupyter: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* jupyter: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* jupyter: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* tensorboards: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* tensorboards: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* tensorboards: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* volumes: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* volumes: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* volumes: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* common: update and audit packages
npm update && npm audit fix && npm i lodash-es@4.17.21 && npm i material-icons@0.7.3
* jupyter: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* tensorboards: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* volumes: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* jupyter: npm run format:write
npm run format:write
2021-07-21 02:35:50 -07:00
Kimonas Sotirchos
09be08aa51
WA: Use relative paths for fetching translation files ( kubeflow/kubeflow#6034 )
...
* jwa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-07-07 09:06:22 -07:00
DavidSpek
ef5d576cd2
notebooks: Add additional PGP server for RStudio package validation ( kubeflow/kubeflow#6010 )
...
* Change PGP server for RStudio validation to pgp.surfnet.nl
* Add as secondary keyserver
2021-06-23 04:15:32 -07:00
DavidSpek
34d068da27
Sync spawner yaml from source to manifests ( kubeflow/kubeflow#5999 )
2021-06-21 07:33:17 -07:00
Wendy Gaultier
9f0334174c
CRUD web apps: i18n ( kubeflow/kubeflow#5880 )
...
* feat(jupyter): add modules for translations
* feat(jupyter): fix path for translations + add GPU translations
* feat(jupyter): add translations
* feat(jupyter): add translations to form-default
* feat(jupyter): add translations to affinity/tolerations
* feat(jupyter): add translations to Image Pull Policy
* feat(jupyter): remove imports from app.module.ts + fix translations
* web-apps(front): add TranslationModule to common for jupyter
* Implement i18n for jupyter frontend
- Including common components needed
- Refactor translation file
* web-apps(front): add i18n to messages from backend
Status tooltip text
Snackbar message
* web-apps(front): volumes and tensorboards i18n ini
Add the i18n feature for the other 2 projects
* feat(volume): add translations for volume
* feat(jupyter): refactor asset file
* Update asset files for all folders
* feat(tensorboards): add i18n
Update all asset files
* cwa: add new translations
* cwa: Add README documentation
* fix: formatting with prettier
* Fix tests
* Fix python format
* remove comment
Co-authored-by: saffaalvi <alvi118@uwindsor.ca>
Co-authored-by: Jose-Matsuda <tongster789@gmail.com>
2021-06-21 07:26:17 -07:00
DavidSpek
9381b829fc
Update spawner_ui_config.yaml with new tags ( kubeflow/kubeflow#5998 )
...
* Update images in spawner_ui_config.yaml
* Update manifest image tags
2021-06-21 06:00:17 -07:00
DavidSpek
c0de144a68
Update last batch of notebook server Dockerfiles ( kubeflow/kubeflow#5997 )
2021-06-21 05:12:16 -07:00
DavidSpek
4ebde0067b
Update dockerfiles and make compatible with Renovate ( kubeflow/kubeflow#5968 )
...
* Update dockerfiles and make compatible with Renovate
* Set memory for jupyter pytorch to the same as jupyter tensorflow
* Update protobuf
* Remove conda version and use substring expansion
* Update SQLAlchemy
* Update dill
2021-06-17 06:40:28 -07:00
Saffa Alvi
ffe75b6a52
feat(jupyter): Support hiding image registry/tag ( kubeflow/kubeflow#5681 )
...
* feat(jupyter): Support hiding image registry/tag
* feat(jupyter): Support hiding VSCode/RStudio images registry/tag
* rebasing onto upstream master
* fix: formatting with prettier and set default hideRegistry=true
* fix: move hideRegistry and hideTag from spawnerFormDefaults.image
* fix whitespace
* add tooltip for images
Co-authored-by: JessicaBarh <jessicabarhoma@gmail.com>
2021-06-09 10:26:51 -07:00
DavidSpek
8a3ecf2997
Notebook servers: Add explanation about kernel not connecting ( kubeflow/kubeflow#5920 )
2021-06-03 09:24:37 -07:00
DavidSpek
2e5eaa1dc6
Remove the f-strings in the Jupyter web app's backend ( kubeflow/kubeflow#5680 )
2021-06-03 09:10:37 -07:00
Jaeyeon Kim
2a0d0c7857
[fix]: Make jupyter-web-app parse workspace volume MountPath ( kubeflow/kubeflow#5952 )
...
* [fix]: Make jupyter-web-app parse workspace volume MountPath
- workspace volume path was fixed with "/home/jovyan"
- it should be enable to parse from jupyter-web-app-config's data
* change parsing key correctly
2021-06-03 08:53:36 -07:00
DavidSpek
e7c924013e
Update jupyter, rstudio and vs code notebook images + allow rstudio in iframe ( kubeflow/kubeflow#5961 )
...
* Update jupyter, rstudio and vs code notebook images
* Remove sed and use substring removal
2021-06-03 08:13:37 -07:00
DavidSpek
c1a4f6659f
Update base notebook for Renovate compatibility ( kubeflow/kubeflow#5955 )
...
* Update base notebook for Renovate compatibility
* Separate kubectl and S6 arch
2021-06-03 06:38:36 -07:00
Saffa Alvi
1e7fbce505
feat(jupyter): add fonts as assets to service ( kubeflow/kubeflow#5691 )
...
* cwa(front): Ignore font files in assets
* feat(jupyter): add fonts as assets to service
* CRUD: fonts in common
* CWA: Remove link to css file
* jwa(front): Remove font assets from jupyter
Co-authored-by: Wendy Gaultier <wvgaultier@gmail.com>
2021-06-02 10:44:35 -07:00
juliusvonkohout
2406692558
FIX The number of gpu must be set as string in Kubernetes/Openshift ( kubeflow/kubeflow#5891 )
...
* Update form.py
* Update form.py
* Update form-default.component.ts
* fix whitespace issue
2021-06-02 10:28:35 -07:00
Kimonas Sotirchos
0a7ba3170b
JWA: Don't override assets with logos ConfigMap ( kubeflow/kubeflow#5942 )
...
* jwa(front): Add static logos in the app
The app does not contain the logos' svgs in its source code/static
files. This results in the icons to not show when developing locally.
This commit adds the svgs found in the logos ConfigMap to the static
files of the app as well.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Change logos fetch url
Change the URLs of the logos from `static/assets/*` to
`static/assets/logos`.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(manifests): Don't override assets with logos
Mount the ConfigMap under the `static/assets/logos` directory to not
override the contents of the entire assets dir.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-05-31 01:36:03 -07:00
DavidSpek
4b59c008b9
tensorboard-controller: fix binding issue ( kubeflow/kubeflow#5925 )
2021-05-25 07:30:09 -07:00
Kimonas Sotirchos
33fea6f503
Add CI format checks for the Volumes web app ( kubeflow/kubeflow#5820 )
...
* vwa(front): Add npm script to check the formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Update the package-lock.json
Run `npm install` to bring the package-lock.json up to date
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(back): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(docker): Remove unused dockerignore file
We have created a global dockerignore file for all the web apps in the
parent dir.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(docker): Don't copy node_modules in dockerfile
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(make): Don't include dockerignore
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci(vwa): Add format check tasks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(docker): Copy only necessary files for build
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* review: Use docker context instead of cd ..
Don't use a `cd ..` and copy dockerignore files back and forth. Instead
we should use the Docker context and the global dockerignore file we
have for all the web apps.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-05-17 08:25:31 -07:00
James Liu
51d0acb344
chore: Add comment to reference RStudio license. ( kubeflow/kubeflow#5884 )
2021-05-06 04:39:05 -07:00
DavidSpek
0563160233
notebook-servers: Update JupyterLab and add Git Extension ( kubeflow/kubeflow#5846 )
2021-04-27 10:15:14 -07:00
DavidSpek
fe2789b9d4
Make notebook limits configurable with a multiplication factor ( kubeflow/kubeflow#5815 )
...
* Make notebook limits configurable with a multiplication factor
* Make limits configurable under advanced section
* run prettier to format frontend code
* fix formatting and add rounding in backend
* Return error if limit is smaller than request
* Allow disabling limitFactor by setting it to none
* review: remove camelCase in python backend
* fix: update spawner_ui_config.yaml in manifests directory
* review: fix setting limits backend
* review: remove unnecessary check from backend
2021-04-13 08:40:11 -07:00
DavidSpek
2570a8eea4
Remove Logo Trademarks from the Jupyter Web App and make logos configurable ( kubeflow/kubeflow#5823 )
...
* rebase: Make logos configurable in configmap and remove trademark references
Rebased to remove the changes to the package-lock.json
* review: add suggested changes and add image group section to README
2021-04-13 05:04:04 -07:00
Ilias Katsakioris
92ca8a2f84
tensorboard-controller: Fix scheduling unbound PVCs ( kubeflow/kubeflow#5819 )
...
When the TB controller attempts to schedule a RWO PVC it checks its
accessModes in the PVC status. The controller panics if the list is
empty.
This commit adds a check to ensure the list is not empty.
Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
2021-04-08 17:27:03 -07:00
Mathew Wicks
500f5c61ef
initial notebook server images README.md ( kubeflow/kubeflow#5818 )
2021-04-08 10:19:03 -07:00
Kimonas Sotirchos
149a986d3d
Add CI format checks for the Jupyter web app ( kubeflow/kubeflow#5811 )
...
* jwa(front): Add npm rule for checking the format
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci: Add common tasks for format checks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci(jwa): Add format check tasks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(back): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Fix formatting
Run `npm run format:write` on frontend
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Include prettier in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(docker): Don't copy node_modules in Dockerfile
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps: Add global dockerignore file
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa: Remove unused dockerignore file
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(make): Don't include dockerignore and cleanup
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-04-08 03:51:02 -07:00
DavidSpek
a0069797df
Update image tags and python packages in pytorch and tensorflow full dockerfiles ( kubeflow/kubeflow#5817 )
2021-04-08 03:50:02 -07:00
DavidSpek
e78477ec5d
Update second layer docker images to new tags and some python deps ( kubeflow/kubeflow#5809 )
2021-04-08 02:11:02 -07:00
DavidSpek
686667f5bd
Update notebook server base images ( kubeflow/kubeflow#5804 )
2021-04-06 04:22:00 -07:00
DavidSpek
94390858bc
Specify commonLabels for tensorboard-controller ( kubeflow/kubeflow#5780 )
2021-03-26 03:35:46 -07:00
DavidSpek
50445138fe
(manifests): Remove unused params that break newer kustomize for web apps ( kubeflow/kubeflow#5768 )
2021-03-24 08:04:45 -07:00
DavidSpek
4842c53f7a
Update manifests to use ECR and fix fieldPath in kustomization files ( kubeflow/kubeflow#5765 )
...
* Update manifests to use ECR and latest image tags
* remove duplicate value in central-dashboard kustomization.yaml
2021-03-24 07:35:45 -07:00
Kimonas Sotirchos
facf6073e5
web-apps: Introduce an APP_SECURE_COOKIES env var ( kubeflow/kubeflow#5764 )
...
* web-apps(back): Introduce APP_SECURE_COOKIES var
Expose a new APP_SECURE_COOKIES env variable that will configure whether
the web apps should set Secure cookies or not.
This will allow the admins to configure the web apps to work when
Kubeflow is exposed over localhost/http.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(back): Switch CSRF checks order
The order the backend makes the CSRF checks should be the following:
1. check if the CSRF cookie is present
2. check if the CSRF header is present
3. check if the CSRF cookie and header have the same value
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps: Set APP_SECURE_COOKIES to false in dev
When running the web apps via the makefiles in dev mode we will need to
explicitly set the APP_SECURE_COOKIES env var to False, since the app
will be served over http.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-03-24 05:16:45 -07:00
DavidSpek
b89ce2ce21
(JWA): Add RStudio trademark statement in Notebook Spawner UI ( kubeflow/kubeflow#5758 )
...
* Add RStudio trademark statement
* move tooltip position to the right of the RStudio button
* fix labels of icons
* RStudio trademark tooltip on index page, remove title jupyter-icon
2021-03-23 13:05:44 -07:00