kubeflow
/
notebooks
mirror of https://github.com/kubeflow/notebooks.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
174 Commits 3 Branches 0 Tags 65 MiB
Commit Graph

5 Commits

Author SHA1 Message Date
Harshad Reddy Nalla 30d1facfbc
include ports array in podtemplate for httpProxy setting 
- moved protocal from imageconfig.spec.ports to podtemplates.ports
 - included the podtemplates.ports with defaultdisplayname
 - add validation webhook for podtemplate.ports
 - update the sample workspacekind with ports reference
 - referencing same id for portid in imageconfig and podtemplate.ports

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
 2025-09-16 15:26:29 -04:00
aTheo 91484fee07
feat(ws): retry failed reconciles much less aggressively (#256) 
* feat:Notebooks 2.0 // retry reconciliation failures less aggressively

Signed-off-by: Adriana Theodorakopoulou <atheodorak@outlook.com>

* mathew: fixes 1

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Adriana Theodorakopoulou <atheodorak@outlook.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
 2025-04-15 23:12:23 +00:00
Mathew Wicks e920dd99de
chore: update go linting + update dependencies for controller (#137) 
* chore: update controller kubebuilder

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* chore: add new controller linting

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* chore: update backend (similar to controller kubebuilder update)

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* chore: add new backend linting

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
 2024-12-02 16:56:58 +00:00
Adem Baccara bc4e4454bc
feat(ws): add validation webhooks for Workspace and WorkspaceKind (#34) 
* add validating webhook

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* add tests for workspacekind and workspace webhooks

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* re-add cert-manager

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* refactor  ValidateCreate and ValidateUpdate functions in wokrspaceKind webhook

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* add e2e test for webhooks

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* mathew refactor 1

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* mathew refactor 2

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* mathew refactor 3

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
 2024-08-29 00:14:03 +00:00
Adem Baccara 0cacff77ee
feat(ws): initial Workspace and WorkspaceKind controller loops (#22) 
* feat(ws): implement a reconciliation loop for the workspace

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* remove comments

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* add correct rbac permission for controller

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* implemented collision handling using ownerReferences

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* update the status field during workspace reconciliation

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* add watcher to workspace kind

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* handle the case that multiple ports are specified for an image

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* generate correctly the StatefulSet spec

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* set status.state of the Workspace

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* add rbac permission for configmap

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* update dockerfile

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* mathew updates

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* mathew updates 2

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* mathew updates 3

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* fix todos

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* mathew updates 4

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* handle extraEnv value replacement

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>

* mathew updates 5

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

* mathew updates 6

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
 2024-07-15 21:21:55 +00:00