Commit Graph

31 Commits

Author SHA1 Message Date
Ben Ye d14f6ac07f support metrics in notebook-controller (kubeflow/kubeflow#4123)
Signed-off-by: yeya24 <yb532204897@gmail.com>
2019-10-16 00:15:40 -07:00
Kam Kasravi c1eca0937c Ci for components (kubeflow/kubeflow#4238)
* snapshot

* fixes to service-account and task

* adding admission-webhook, notebook-controller

* update to README.md

* update README.md
2019-10-15 08:31:53 -07:00
Jeremie Vallee c88e721fc7 [3945] Configurable Istio Gateway for Notebook Controller (kubeflow/kubeflow#4216) 2019-10-14 12:06:59 -07:00
Ben Ye 807843ec2a cleanup some codes in notebook controller (kubeflow/kubeflow#4098)
* cleanup some codes in notebook controller

Signed-off-by: yeya24 <yb532204897@gmail.com>

* remove ambassador in notebook controller

Signed-off-by: yeya24 <yb532204897@gmail.com>
2019-10-14 12:06:52 -07:00
Jerome Brette b5ff201a8c Migrate kustomize.go to Kustomize3 (kubeflow/kubeflow#4055)
* Migrate to kustomize3: Phase 1. Update kustomization.yaml

* Migrate to kustomize3: Phase 2: Update kustomize.go

- Update kustomize.go to match new package structure.
- Update module dependencies.

* Migrate to kustomize3: Phase 3: Implements code review

- As per request, revert kustomization.yaml back to deprecated syntax.
- As per request, revert kustomize.go to use deprecated .Bases field.
- Note: patchesStrategicMerge: will be turned into a deprecated field pretty soon.
- Rerun go mod tidy

* Migrate to kustomize3: Phase 4: Activate legacy order transformer
2019-09-20 21:21:25 -07:00
Lun-Kai Hsu 2f2938bead Notebook v1beta1 (kubeflow/kubeflow#4105)
* add v1beta1

* add storage version

* wip

* add conversion

* setup webhook

* fix

* fix manifest

* webhook wip

* no webhook
2019-09-13 07:04:29 -07:00
Lun-Kai Hsu 8cad496a13 Migrate notebook CR to kubebuilder V2 (kubeflow/kubeflow#4013)
* wip

* can build

* tested: able to control notebook

* fix
2019-09-04 17:06:22 -07:00
Kimonas Sotirchos 08f43598c2 Culling of Idle Jupyter Notebooks (kubeflow/kubeflow#3856)
* Create a culler as a package

Helper functions for culling resources. Takes for granted that ISTIO is
installed to the system and queries Prometheus to get metrics.
Specifically, requests/{configurable time}.

If the resource should be culled, then it should be done by setting an
annotation. This way the UIs can also show that the Resource is stopping
and also easily stop a resource by making a PATCH request.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Culling logic enhancements

Add necessary ENV Vars. Culling won't happen by default. To enable it
the user will need to set the ENABLE_CULLING=true

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Misc fixes in logging and comment cleanup

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Fix typo

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Add Notebooks specific culling

Query the /api/status endpoint of each Server

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Remove the generic culling logic

We need to discuss if it would make sense to have this logic as a go
library, or use knative.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Add unit tests

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Remove unused code

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Review changes #1

* rename `getEnvDef` to `getEnvDefault`
* Add a comment to describe how the STOP_ANNOTATION gets used

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Make cluster domain configurable

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2019-08-26 04:40:21 -07:00
Kam Kasravi 0b5e3bd995 add kkasravi to OWNERS (kubeflow/kubeflow#3311) 2019-06-18 16:58:32 -07:00
Gabriel Wen 70bd7acdf5 Merge branch 'master' into fix-notebook-controller 2019-06-03 14:33:05 -07:00
zabbasi daa4768f96 Add details to "conditions" in notebook status (kubeflow/kubeflow#3319)
* added detailes into NotebookCondition to keep track of notebook  container status change

* update notebook controller image

* fix conitions update

* small fix

* temporary changes to debug

* temporary remove delete step from workflow for debugging

* temoraray merging kfctl-test and kfctl-go-test fir debugging

* debugging

* undo the mistake

* debugging

* debugging tests

* merged kfctl-test and kfctl-go-test

* remove wait-for-kubeflow

* merged with master

* remove test delete step for debugging

* small fix

* update jupyter test component

* update condition test for jupyter component

* revert back deleting step

* revert back change in kfctl.sh

* added some temporary change to debug jupyter-test

* revert back temp changes
2019-06-03 14:19:30 -07:00
Gabriel Wen c22959f0ac check env when setting watch 2019-06-03 13:54:10 -07:00
Gabriel Wen 525eee5ed8 update notebook_controller to use env 2019-06-03 13:15:56 -07:00
Kunming Qu 42bbb0cdbf profile and Istio integration (kubeflow/kubeflow#3234)
* profile and Istio integration

* make profile manage Istio gateway

* add README.md

* make notebooks use gateway in kubeflow namespace

* gateway format to ns/name; add watch for istio ServiceRoleBinding

* Support setting auth header format via parameter

* update README

* update README

* update readme; resolve comments
2019-05-29 18:36:19 -07:00
zabbasi a7e7d75be9 Renamed PodPreset CRD to PodDefault (kubeflow/kubeflow#3320)
* renamed PodPreset CRD to PodDefault

* typos

* update jupyter-web-app image
2019-05-21 11:22:10 -07:00
zabbasi 5ae44fbdb4 Integrates notebook-controller and jupyter-web-app with admission-webhook (kubeflow/kubeflow#3245)
* integrate jupyter-web-app and notebook-controller with webhook

* merged podpreset component into admission-webhook

* applied cr comments

* undo notebook image for tesing

* update notebook controller image

* temporaray disbaling kubeflow delete to debug presubmit failure

* temporary remove cluster delete in kfctl workflow test

* typo

* typo

* undo debugging changes
2019-05-20 12:39:13 -07:00
Kunming Qu a80025787b enable Istio Injection in user-created namespace; notebook and Istio integration (kubeflow/kubeflow#3235)
* enable Istio Injection in user-created namespace; notebook service and Istio rbac integration

* update README
2019-05-09 16:59:58 -07:00
Hung-Ting Wen 58c977c8e9 ISTIO support for notebook controller (kubeflow/kubeflow#3104)
* virtual service func init

* create virtualservice

* fix

* fix

* add cluster role

* fix unstructured format

* updates

* fix

* reconcile virtual service

* fix

* revert quote changes

* add virtualservice update

* comment

* copy if spec is not found in toSpec

* add watch event
2019-04-29 11:43:19 -07:00
Lun-Kai Hsu 9f70ca7f10 add labels for notebook so that gcp credentials will be injected by webhook (kubeflow/kubeflow#2853)
* add labels for gcp cred

* kfctl set flag

* review comment

* review comment
2019-03-30 20:36:33 -07:00
Lun-Kai Hsu dc69b63667 notebook CR shows container status (kubeflow/kubeflow#2787)
* wip

* fix

* fix format
2019-03-26 17:08:47 -07:00
zabbasi 2500faee10 added ReadyReplicas status to notebook-controller (kubeflow/kubeflow#2743)
* added ReadyReplicas status to notebook-controller

* fixed issues related to updating the notebook status

* fixed a problem in updating Notebook's status

* applied cr comments

* small change

* small formating change
2019-03-21 21:46:18 -07:00
Lun-Kai Hsu d47a5864ec pf gcb (kubeflow/kubeflow#2603) 2019-03-04 17:08:23 -08:00
Lun-Kai Hsu bfa59d7769 fix (kubeflow/kubeflow#2620) 2019-03-04 16:48:17 -08:00
Lun-Kai Hsu 931e8e32aa Add status to notebook (kubeflow/kubeflow#2558)
* wip

* wip

* update test to check status condition

* fix
2019-03-04 14:36:17 -08:00
Lun-Kai Hsu a9b8f4e8a0 fix (kubeflow/kubeflow#2506) 2019-02-26 11:21:53 -08:00
Abolfazl Shahbazi 4c48320235 Update python code styles based on what's provided in .style.yapf (kubeflow/kubeflow#2447)
* Fix Python code styles based on Pep8 and flake8

* More syle fixes to Python code

* Update python code styles based on what's provided in .style.yapf

* Sync with master and update styles

* Sync with master

* More Python style fixes

* Changes per code review

* Sync with master and update the remaining files

* Add a .flake8 config file for future reference
2019-02-19 22:44:30 -08:00
Lun-Kai Hsu ffc9a1d674 Add build with GCB support to notebook controller (kubeflow/kubeflow#2486)
* fix

* fix

* ignore
2019-02-15 11:52:54 -08:00
Lun-Kai Hsu e377455ce4 Notebook controller fixes (kubeflow/kubeflow#2463)
* fix

* enable e2e test

* fix

* fix

* fix logging for pytest

* fix

* fix

* fix

* fix

* fix

* fix

* address review

* review comment
2019-02-15 00:09:02 -08:00
Lun-Kai Hsu b7555c6727 NB controller fix (kubeflow/kubeflow#2439)
* fix

* fix
2019-02-10 17:37:51 -08:00
Abolfazl Shahbazi ae07f8d4d8 port leftover diff from kfapp-ksapp branch after kfctl merge (kubeflow/kubeflow#2410)
* port leftover diff from kfapp-ksapp branch after kfctl merge

* minor gofmt fix
2019-02-10 10:50:08 -08:00
Lun-Kai Hsu fa3b0b3b0b Golang notebook controller (kubeflow/kubeflow#2336)
* kubebuilder init

* replae dep with modules

* add notebook api

* notebook controller impl

* remove test

* fix dockerfile

* fix svc reconcile

* notebook controller ksonnet

* update generated crd

* add sample

* remove TODO

* make golang version an arg

* rename

* fix path

* add README

* Add todo in readme

* remove arg default
2019-02-05 16:43:39 -08:00