Commit Graph

93 Commits

Author SHA1 Message Date
Tariq Hasan 4451765b12 chore: update node in crud-web-apps from 12 to 16 (kubeflow/kubeflow#7637)
* upgrade node from 12 to 16

Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>

* replace cypress with playwright for e2e tests in jupyter

Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>

* update base image for node

Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>

* update build scripts for tensorboard

Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>

* update build scripts for jupyter

Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>

---------

Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>
2024-11-26 17:15:52 +00:00
Robert Gildein 5abca012ed feat(crud-web-apps): Add Prometheus metrics (kubeflow/kubeflow#7634)
* Add Prometheus metrics to CRUD backend

Use prometheus_flask_exporter library to add Prometheus metrics to
CRUD backend. With this approach all CRUD backens will be able to
enable metrics.

Signed-off-by: Robert Gildein <gildeinrobert@gmail.com>
Signed-off-by: Robert Gildein <robert.gildein@canonical.com>

* KF-6122 Add short doc about metrics a improve code

Add note to README.md about metrics and link the source code for more
information. Fix small issue and missing dependency for Python < 3.8.

Signed-off-by: Robert Gildein <robert.gildein@canonical.com>

* fix getting backend version from Python < 3.8

Signed-off-by: Robert Gildein <robert.gildein@canonical.com>

* Enable metrics by default and increase backend version to 1.2

Signed-off-by: Robert Gildein <robert.gildein@canonical.com>

* switch to group by rule instead of path

Signed-off-by: Robert Gildein <robert.gildein@canonical.com>

* fix yaml files

Signed-off-by: Robert Gildein <robert.gildein@canonical.com>

---------

Signed-off-by: Robert Gildein <gildeinrobert@gmail.com>
Signed-off-by: Robert Gildein <robert.gildein@canonical.com>
2024-09-05 12:01:15 +00:00
Tobias Goerke d4f0f18a70 fix: return waiting on no pvcviewer status (kubeflow/kubeflow#7350)
In some cases, a PVCViewer object has no status as it was just created or is having issues starting a pod.  In those cases, we should rather return waiting than uninitialized, which would appear to the users as if no viewer was started.
2024-05-24 00:25:27 +00:00
dependabot[bot] f116cc5c70 build(deps): bump debug from 4.1.1 to 4.3.4 in /components/crud-web-apps/volumes/frontend (kubeflow/kubeflow#7308)
Bumps [debug](https://github.com/debug-js/debug) from 4.1.1 to 4.3.4.
- [Release notes](https://github.com/debug-js/debug/releases)
- [Commits](https://github.com/debug-js/debug/compare/4.1.1...4.3.4)

---
updated-dependencies:
- dependency-name: debug
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-27 17:15:16 +00:00
dependabot[bot] 14b519252e build(deps): bump @babel/traverse from 7.14.7 to 7.23.2 in /components/crud-web-apps/volumes/frontend (kubeflow/kubeflow#7356)
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.14.7 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-27 17:12:16 +00:00
Mathew Wicks e7f468d924 chore: cleanup inactive owners (kubeflow/kubeflow#7402) 2024-01-24 18:47:53 +00:00
Tobias Goerke 01ccb69dd2 chore: update default filebrowser version (kubeflow/kubeflow#7390)
Filebrowser recently release v2.25.0.
Until now, we couldn't use v2.24.0, which brings chunked uploads, due to an issue with Cloudflare environments. 
This got fixed in v2.25.0, so that chunked uploads should now work for every user: https://github.com/filebrowser/filebrowser/releases/tag/v2.25.0
2023-10-26 14:12:12 +00:00
Kimonas Sotirchos b9ff781a21 ci: Build ARM images for core components (kubeflow/kubeflow#7220)
* ci: Build ARM images for core components

Extend the GH Actions to also build the images on ARM architectures.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* crud-web-apps: Update python and gevent versions

In order to successfully build on linux/arm64/v8 we'll need to:
* Update to Python 3.10
* Bump the gevent version

https://github.com/gevent/gevent/issues/1721#issuecomment-1223751954

* Update the workflows for JWA

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for centraldb

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for kfam

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for notebook-controller

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for PodDefaults

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for Profile Controller

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for pvcviewer controller

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for TensorBoard Controller

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for TWA

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for VWA

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update releasing script to include PVCViewers

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

---------

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
2023-10-04 22:17:15 +00:00
Tobias Goerke 952414a007 fix: downgrade filebrowser to v2.23.0 (kubeflow/kubeflow#7247)
this fixes upload issues for cloudflare users
we are waiting for a patch version v2.24.3
2023-09-19 14:51:30 +00:00
Tobias Goerke 0f464e5bfd fix: viewer-spec.yaml and trigger build (kubeflow/kubeflow#7230)
* build: minor doc improvement triggering build pipe

* fix: viewer-spec.yaml

Two fields are either not correctly indented or named incorrectly

* fix: add volumes definition required by controller

* feat: use filebrowser:v2.24.2 enabling tus uploads
2023-08-16 18:56:03 +00:00
Tobias Goerke 9b2f82188e Add PVCViewer Frontend Integration (kubeflow/kubeflow#7179)
* Add pvcviewer support to volumes backend

* Modifying volumes manifests for pvcviewer support

* viewer-spec is now valid

* Add frontend integration

* Fix flake8 errors

* Use material spinners to display wait times

* Default PVCViewer SA to default-editor

* fix: remove superfluous space in docker builds (kubeflow/kubeflow#7224)
2023-08-04 19:01:20 +00:00
Elena Zioga 95bbbf07da [wa-theme-typography]: Define theme and typography (kubeflow/kubeflow#7062)
* web-apps(front): Define theme and typography

In this commit:
* Create a styles folder that contains all sccs files.
* Define the generic theme and typography.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Use the style of the specified body-1 level

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Use the styles of the specified title and headline levels

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Use primary color in snackbar component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Change back button

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix imports after restructuring

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Add mat-typography class in index.html

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Use the style of the specified title level

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Use primary color

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Fix imports after restructuring

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Add mat-typography class in index.html

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Use the style of the specified title level

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix typo

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Add mat-typography class in index.html

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix imports after restructuring

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Use primary color

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix formatting

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix ui test

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-07-31 16:47:29 +00:00
dependabot[bot] 8475b42785 build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 in /components/crud-web-apps/volumes/frontend (kubeflow/kubeflow#7215)
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-20 09:34:25 +00:00
Kimonas Sotirchos 0dc4261955 Fix Python linting (kubeflow/kubeflow#7060)
* gh-action: Workflow for testing python lint

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* lint: Run autopep8 to lint files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* linting: Manual changes

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

---------

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2023-03-30 09:32:05 +00:00
amitmukati-2604 d438892c77 Adding changes to build multi arch images on pull_request for VWA. (kubeflow/kubeflow#7052) 2023-03-23 15:27:22 +00:00
Elena Zioga c0f00e836b jwa: Improve how JWA exposes errors (kubeflow/kubeflow#6952)
* web-apps(front): Fix status case

* Fix the status case to properly show the warning icon when the status
  phase is warning.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify status-icon component

* Modify the status-icon component to follow the status cases.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify status component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce status-info component

* Have an admonition in the details page of each Notebook with a
  detailed message on the current status.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Extend process_status function

The process_status parses the status by:
- Checking the .status.containerState.
- Checking the .status.conditions, since they have the one-liner reason
  and a message.
- If none of the above exist, it will use the Events emitted for the
  notebook.
- In case it deduces the status from an Event and it's not available
  anymore, it uses a generic message.

Also, add a 10 second delay to the backend logic where we display a
spinner and a generic message to prevent a warning icon from appearing
immediately after a notebook is initialized.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Extend getNotebook request

* Extend the getNotebook request to also include the processed status
  information in the Notebook details page.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Extend the frontend

Extend the frontend by:
- Adding an admonition with a detailed message on the current status
  bellow the notebook name.
- Adding the processed_status field.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix unit tests

Fix unit tests accordingly.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa: Don't show the popup when a notebook is being stopped

* Use the waiting status, which also uses the spinner, when a notebook
  is being stopped.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update lib-status-icon

Signed-off-by: Elena Zioga <elena@arrikto.com>

* fixup! jwa(back): Extend getNotebook request

* fixup! jwa(back): Extend process_status function

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-23 15:23:22 +00:00
Elena Zioga e7a1d7d288 vwa: Remove all the Rok references (kubeflow/kubeflow#6984)
* vwa(front): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(back): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(build): Update Dockerfile

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-06 10:22:35 +00:00
Elena Zioga f465180f05 jwa(front): JWA shows a weird long value for memory when restoring notebook from snapshot (kubeflow/kubeflow#6897)
* web-apps(front): Introduce MemoryValue class

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce unit tests for the MemoryValue class

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Use MemoryValue class for memory column

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Make quantityToScalar() use only Number()

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Update quantityToScalar() import

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update quantityToScalar() import

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-02-24 12:33:24 +00:00
dependabot[bot] 5c74a8acb5 build(deps): bump ua-parser-js from 0.7.31 to 0.7.33 in /components/crud-web-apps/volumes/frontend (kubeflow/kubeflow#6908)
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.31...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-16 13:43:06 +00:00
dependabot[bot] e884dec019 build(deps): bump json5 from 1.0.1 to 1.0.2 in /components/crud-web-apps/volumes/frontend (kubeflow/kubeflow#6881)
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-16 13:37:07 +00:00
Kimonas Sotirchos a99af12eea Add approvers to the frontends (kubeflow/kubeflow#6929)
* Add approvers to the frontends

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Add owners to common frontend code

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

---------

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2023-02-13 17:23:24 +00:00
Orfeas Kourkakis b5e0deec09 cdb-angular: Show KF version (kubeflow/kubeflow#6918)
* cdb-angular: Modify README.md port-forward instructions

Add instructions to port-forward Profiles KFAM service.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Modify SnackBar service to use config parameter

Modify SnackBarService to:

 - Accept as a parameter a config object that will be able to include
   all possible configurations MatSnackBarService
 - Inject MAT_SNACK_BAR_DEFAULT_OPTIONS. This allows a structured way
   for every WA to provide to the service a default configuration
   app-wide for values like like HorizontalPosition and duration.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb(front): Use Kubeflow common library

Build CDB using components from Kubeflow's common libary.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Introduce backend service and ErrorInterceptor

 - Introduce backend service to handle requests to the backend
 - Use snackBar service by KF common library
 - Introduce ErrorInterceptor to hanlde errors in a uniform way.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(back): Remove "kubeflowVersion" from API

Remove the "kubeflowVersion from Workgroup's API "/env-info"
endpoint since it was using CRDs which are deprecated.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(back): Modify KF build version during runtime

By default, the version displayed in the dashboard's sidebar is the
ENV variable `BUILD_VERSION` defined during build time. With this
change, the `/api/workgroup/env-info` endpoint may now return the
build's label, version, and id which will be displayed instead of the
BUILD_VERSION. These values are assigned during runtime and can be
defined through the deployment's `KF_DASHBOARD_BUILD_LABEL`,
`KF_DASHBOARD_VERSION` and `KF_DASHBOARD_BUILD_ID` ENV variables.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Show KF version in the left sidebar

Show KF version at the bottom of the left sidebar navigation menu.
Variables that are used to show the KF version get their default values
during build time but may be modified during runtime by the
depoloyment's ENV vars fetched from the request at
'/api/workflow/env-info'.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Update the use of SnackBarService

Update the use of SnackBarService in order to pass required data via a
`config` object.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Update the use of SnackBarService

Update the use of SnackBarService in order to pass required data via a
`config` object.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* twa(front): Update the use of SnackBarService

Update the use of SnackBarService in order to pass required data via a
`config` object.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Fix flaky filtering unit test

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

---------

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-02-13 16:16:25 +00:00
Orfeas Kourkakis 6a02712226 vwa(front): Prevent PVCs from being deleted when there is a corresponding notebook (kubeflow/kubeflow#6899)
* vwa(back): Append notebooks using each PVC

Append notebooks using each PVC when getting and parsing all PVCs.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Create custom delete action column

Create custom delete column component that extends ActionComponent from
Kubeflow common code and adds the following functionalities:

* Disable the button when a row's notebooks array is not empty
* Display an appropriate message including the notebooks' names

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add delete button component in index page

Implement custom delete column in the table in VWA's index page.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add Used by column in volumes table

Add a Used by column in volumes table of VWA's index page in order to
link to the notebooks that are using each PVC.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Fix integration tests

Update mock request for PVCs

Refs arrikto/dev#2017
Refs arrikto/dev#2135

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Fix format error

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

---------

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-30 10:02:05 +00:00
Elena Zioga 89d4f97303 [wa-actual-links-in-tables] Make links in our table component actual links (kubeflow/kubeflow#6864)
* web-apps(front): Import @angular/router package

Import @angular/router package to use routerLink directive.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce LinkValue class

Introduce a distinct class for our external and internal links.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Remove isLink property from PropertyValue class

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Make links actual links

Make JWA's main table links actual links by using the new LinkValue
class.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Make links actual links

Make VWA's main table links actual links by using the new LinkValue
class.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-01-18 14:19:21 +00:00
Orfeas Kourkakis cf5301b10a vwa(front): Add UI tests with Cypress (kubeflow/kubeflow#6862)
* web-apps(front): Remove Protractor files

Remove Protractor files since it's not used anywhere in the common
code.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Add Cypress attributes

Add more attributes and modify some existing ones for elements to be
selectable during UI tests with Cypress.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Install Cypress

 - Install Cypress & npm scripts for UI tests
 - Remove Protractor files
 - Update README.md with UI tests instructions

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add UI tests with Cypress

 - Add Cypress attributes for elements to be selectable during
   UI tests.
 - Add UI tests with Cypress to check that:
    * New Volume form dialog has proper values
    * Index page table contains all PVC names received
    * Index page table status icons are correctly shown
    * Index page table browse buttons are correctly shown

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(vwa): Add UI tests to VWA's frontend workflow

Add UI tests to VWA's frontend workflow. These tests should run in
Ubuntu 20.04 since Ubuntu 20.04 includes both Chrome and Firefox
installations by default.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix formatting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Fix format errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-03 13:11:24 +00:00
Orfeas Kourkakis 3dec176271 web-apps(front): Sort events & conditions tables by date (kubeflow/kubeflow#6858)
* web-apps(front): Sort tables according to input

Configure tableConfig with new fields (column and order) that the table
will use to sort items during initialization.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Sort conditions table by timestamp

Initialize conditions table sorted by Last Transition Time column, with
the most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Sort events by timestamp

Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Sort events by timestamp

Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix format errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:50:19 +00:00
Orfeas Kourkakis d5216c7d2a jwa(front): Link to VWA details page (kubeflow/kubeflow#6857)
* web-apps(front): Create lib-urls component

Create a URLs component in Kubeflow common library which takes a
list of URLs and their corresponding name and exposes them
horizontally in a div.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Add unit test for lib-urls

Add a unit test for lib-urls component

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Remove column Volumes from index page

Remove Volumes column from the table in JWA's index page.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Link to a Volume details from JWA details page

 - Expose all volumes from a notebook, not only PVCs.
 - Expose the volumes grouped by type, having PVCs link to their
   corresponding volume details page in VWA, using lib-urls
   component.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Implement lib-urls in VWA details page

Implement lib-urls component in the OVERVIEW tab of VWA's volume
details page to avoid duplicate code.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Use common link styles

Use common link styles in configurations component.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* Fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:49:18 +00:00
Orfeas Kourkakis cfe32e59c2 web-apps(front): Fix namespace selector bug (kubeflow/kubeflow#6845)
Fix a bug in the namespace selectors of JWA, VWA and TWA. In order to
show the namespace selector, they only checked if there is no
env.production variable available. This resulted in the selector not
showing even if there was no dashboard which is not expected.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:47:18 +00:00
apoger 6b3fd05ea2 Update KF manifests and gh-action workflows to use the tag=`latest` (kubeflow/kubeflow#6854)
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

review changes

* build images with the latest tag only when a PR
  is merged to master branch

* revert changes  in manifests/workflows for the
  notebook-server images

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-20 15:59:18 +00:00
Orfeas Kourkakis 64a757de75 vwa(front): Handle query parameters and add unit tests (kubeflow/kubeflow#6835)
* vwa(front): Handle query parameters in Volume details page

Add query parameter handling for each tab in order for the user to
be able to navigate directly to the tab of choice inside the Volume
details page.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add unit tests for volume-details-page component

Add unit tests in order to:
 - Show only the proper tab according to query parameters passed.
 - Switch tabs according to query parameters passed.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add unit tests for overview component

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(vwa): Add frontend tests

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-15 11:51:21 +00:00
apoger 54ab6a815e Fix workflows for publishing images only when PR is merged (kubeflow/kubeflow#6842)
* Fix docker-publish workflows

* Remove workflow that builds/push all images

* Remove redundant files from manifests
2022-12-15 09:51:21 +00:00
apoger e327bfc8d7 crud-web-apps: Extend tests for using images of each PR (kubeflow/kubeflow#6832)
* jwa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for JWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* twa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for TWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* vwa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for VWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-12 12:23:27 +00:00
Elena Zioga dd0a681457 web-apps(front): Enable source maps in WAs (kubeflow/kubeflow#6787)
* jwa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-09 14:12:11 +00:00
Orfeas Kourkakis bfb48f8e71 vwa(front): Add YAML tab to Volume details page (kubeflow/kubeflow#6823)
Add tab to show the full yaml of the PVC.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-09 10:43:11 +00:00
apoger 10e0e93085 Cherry-pick commits for using DockerHub for all images (kubeflow/kubeflow#6825)
cherry-picking: #6548
* Update all images to use DockerHub
* Update releasing script for dockerhub

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Cherry-picked-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Co-authored-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2022-12-08 15:37:10 +00:00
Orfeas Kourkakis dfadbec6e1 vwa: Update cluster role to list notebooks (kubeflow/kubeflow#6808)
Update manifests for volumes-web-app-cluster-role to be able to list
notebooks in kubeflow.org.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-07 17:04:37 +00:00
adilhusain-s 6faedb79d3 Adding support for linux-ppc64le in CI to release multi-arch docker image volumes-web-app (kubeflow/kubeflow#6811) 2022-12-07 16:59:36 +00:00
Orfeas Kourkakis ba62fcc93b vwa: Add EVENTS tab to Volume details page (kubeflow/kubeflow#6806)
* vwa(front): Fix tests symLinks to Kubeflow common code

Add field preserveSymLinks in angular.json in order to link to
Kubeflow common library during tests.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix unit tests failing

Fix unit tests failing for the following components: app, index,
index-default, index-rok, form-default, form-rok

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add delete button to Volume details page

In this commit:
 - Add button for Delete action.
 - Create Actions Service to handle delete action and implement it in
   all components that use it.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(back): Get a PVC's events

Add logic in the backend to fetch the events of a PVC.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add EVENTS tab to Volume details page

Add Events tab to show the available events of the pvc in the form
of a table, in order to help a user with debugging the pvc.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-07 16:58:37 +00:00
Elena Zioga cca60b7d26 jwa(front): Fix unit tests (kubeflow/kubeflow#6804)
* jwa(front): Rename form-default component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Create missing module files

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Remove form-rok and form components

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Update JWA's @angular/common package

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify rok-url component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add Rok URL message

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update VWA's @angular/common package

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Remove the headers request

Remove the headers request since the common code implements it.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix JWA's unit tests

Fix JWA's unit tests.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* gh-actions: Add GH action to run JWA unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(build): Update Dockerfile

Update Dockerfile to not build Rok.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-07 12:49:38 +00:00
Orfeas Kourkakis daef70e326 VWA: Create Volume details page (kubeflow/kubeflow#6788)
* vwa(back): Get a single PVC and the pods using it

Add logic in the backend to fetch a single PVC and the pods using
it.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Create Volume details page with OVERVIEW tab

Create OVERVIEW tab to show key information about the PVC.

* vwa(front): Format files

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-05 10:27:08 +00:00
dependabot[bot] 04ee71798e build(deps): bump engine.io and socket.io in /components/crud-web-apps/volumes/frontend (kubeflow/kubeflow#6758)
Bumps [engine.io](https://github.com/socketio/engine.io) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together.

Updates `engine.io` from 6.1.3 to 6.2.1
- [Release notes](https://github.com/socketio/engine.io/releases)
- [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/engine.io/compare/6.1.3...6.2.1)

Updates `socket.io` from 4.4.1 to 4.5.3
- [Release notes](https://github.com/socketio/socket.io/releases)
- [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io/compare/4.4.1...4.5.3)

---
updated-dependencies:
- dependency-name: engine.io
  dependency-type: indirect
- dependency-name: socket.io
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-05 10:17:08 +00:00
Kimonas Sotirchos 485550635b web-apps: Add support for all-namespaces in the Volumes and TensorBoards web apps (kubeflow/kubeflow#6778)
* vwa(front): Support all-namespaces

The VWA will now be able to work with the "All namespaces" option of
the CentralDashboard.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): Support all-namespaces

The TWA will now be able to work with the "All namespaces" option of
the CentralDashboard.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* wa(front): Add cypress attributes

Add more attributes for elements to be selectable when running e2e
tests.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(e2e): Add e2e tests for all-namespaces

Add a new e2e test that checks if the Namespaces column is shown
when selecting all-namespaces.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* dashboard: Allow all-namespaces for vwa/twa

The dashboard will be allowing the VWA and TWA to work with
all-namespaces, now that we added this functionality.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2022-11-29 10:56:43 +00:00
apoger 46f14d4e97 Use K8s 1.25 for the tests (kubeflow/kubeflow#6751)
* kind: Introduce config file for 1.25

* Add a new KinD configuration file for testing with K8s 1.25.3
* Install kind v0.17.0 for testing with K8s 1.25.3

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* gh-actions: Use 1.25 for testing

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* testing: Install Istio 1.16 for testing

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Test commit for enabling the tests

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* notebook-controller: Fix Makefile

Remove the test rule as a prerequisite for running docker-build

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-11-24 08:30:10 +00:00
Elena Zioga 9fa3fde87e Upgrade @angular/material in WAs (kubeflow/kubeflow#6763)
* jwa(front): Upgrade @angular/material package (kubeflow/kubeflow#6462)

* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Upgrade @angular/material package (kubeflow/kubeflow#6462)

* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Upgrade @angular/material package (kubeflow/kubeflow#6462)

* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-11-23 15:06:43 +00:00
Pranav Pandit d83d55a892 updated compatible base images & removed arch dependencies in different components for multiple arch support (kubeflow/kubeflow#6650)
* updated base images in Volume Web component for multiple arch

* updated base images in Tensorboard Web component for multiple arch

* updated base images in Jupyter Web component for multiple arch

* updated admission webhook component for multiple arch

* removed goarch depedency for multiarch building

* removed goarch depedency for multiarch building in admission webhook component

* removed goarch depedency & added powerPC case for multiarch building in access-management component

* removed goarch depedency for multiarch building in tensorboard controller

* removed goarch depedency for multiarch building in notebook Controller

* Removing empty computation to resolve future build issues
2022-11-23 13:42:42 +00:00
Elena Zioga af487b53b9 Sorting support for VWA and TWA (kubeflow/kubeflow#6743)
* vwa(front): Enable sorting in VWA (kubeflow/kubeflow#6460)

* Enable sorting functionality in VWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Enable sorting in TWA (kubeflow/kubeflow#6460)

* Enable sorting functionality in TWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Fix unit tests

* Fix unit tests.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-11-16 14:29:12 +00:00
dependabot[bot] 301c54f18e build(deps): bump loader-utils from 1.2.3 to 1.4.2 in /components/crud-web-apps/volumes/frontend (kubeflow/kubeflow#6737)
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.2.3 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](https://github.com/webpack/loader-utils/compare/v1.2.3...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-15 14:27:28 +00:00
Kimonas Sotirchos 1be7370a06 web-apps: Common code for all-namespaces (kubeflow/kubeflow#6730)
* wa(front): Use es2019 to have .flat()

Add es2019 to the tsconfig.compilerOptions.lib array in order for the
tslint linter to not complain about the use of flat().

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* wa(front): all-namespaces requests helper

Add a helper function in the backend.service that can take care of
creating the observable that will make requests for all namespaces.

Refs arrikto/dev#1529

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* wa(front): Disable toolbar + button on all-namespaces

Add helper methods to toolbar buttons to disable/enable them and add a
tooltip if the user selected all-namespaces.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* wa(front): Common logic for dynamic ns column

We want to show a `namespace` column when the user selects
all-namespaces, to make it easier to identify the different objects.

To not replicate the logic of adding and removing a column if all
namespaces was selected we moved this logic in the common table
component.

We also add an option to the component's config to disable/enable this
behavior.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Utilize common code for all-namespaces

Update the JWA's code to work with the common code introduced to
supporting all-namespaces. This includes changes for:
* The Namespace column in the main table
* Helpers for performing requests in all namespaces
* Dynamically enabling/disabling the `+ new` button

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* frontend: Update the linting GH Action

Ensure we run `ng lint` to check if the code is properly linted.

Previously we just did `ng lint --fix` which would try to fix the code,
and not complain about it. But this means that we don't actually check
if the code is linted.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* wa(front): Fix linting issues in common code

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* gh-actions: Lint apps in parallel

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2022-11-14 16:22:26 +00:00
dependabot[bot] 00f0ce5a23 build(deps): bump loader-utils from 1.2.3 to 1.4.1 in /components/crud-web-apps/volumes/frontend (kubeflow/kubeflow#6717)
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.2.3 to 1.4.1.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md)
- [Commits](https://github.com/webpack/loader-utils/compare/v1.2.3...v1.4.1)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-14 12:54:26 +00:00
dependabot[bot] 2d2bd86bbb build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 in /components/crud-web-apps/volumes/frontend (kubeflow/kubeflow#6728)
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io-parser/compare/4.0.4...4.0.5)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-11 10:19:51 +00:00