* feat(dashboard): add Habana Gaudi as an option for GPUs
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
* feat(notebooks): add Intel Gaudi pytorch containers
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
* feat(notebooks): add gaudi jupyter containers to be built and published
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
* feat(notebooks): add a note about hugepages with Gaudi workloads
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
---------
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
* Add Prometheus metrics to CRUD backend
Use prometheus_flask_exporter library to add Prometheus metrics to
CRUD backend. With this approach all CRUD backens will be able to
enable metrics.
Signed-off-by: Robert Gildein <gildeinrobert@gmail.com>
Signed-off-by: Robert Gildein <robert.gildein@canonical.com>
* KF-6122 Add short doc about metrics a improve code
Add note to README.md about metrics and link the source code for more
information. Fix small issue and missing dependency for Python < 3.8.
Signed-off-by: Robert Gildein <robert.gildein@canonical.com>
* fix getting backend version from Python < 3.8
Signed-off-by: Robert Gildein <robert.gildein@canonical.com>
* Enable metrics by default and increase backend version to 1.2
Signed-off-by: Robert Gildein <robert.gildein@canonical.com>
* switch to group by rule instead of path
Signed-off-by: Robert Gildein <robert.gildein@canonical.com>
* fix yaml files
Signed-off-by: Robert Gildein <robert.gildein@canonical.com>
---------
Signed-off-by: Robert Gildein <gildeinrobert@gmail.com>
Signed-off-by: Robert Gildein <robert.gildein@canonical.com>
In order to maintain consistency and compatibility, explicitly convert the 'username' variable to a string using the str() function before returning it. This ensures that the function consistently provides a string representation of the username, addressing potential variations in the original data type.
https://github.com/kubeflow/kubeflow/issues/7456
Update authn.py
Update notebook_template.yaml
* Handle edge case when node capacity is undefined gracefully
* Change log message to capacity
* No need to make the message a warning
* Resolve flake8 issue
* ensure closing bracket matches indentation of opening bracket
* Fix flake8 issues from other files
The change introduced by kubeflow/kubeflow#6736 removed the default GPU vendors
list, which causes an issue when trying to select a vendor from the dropdown menu
if the vendors list is not configured.
This commit can be reverted if proper documentation is provided for users/distributions
to configure the dropdown menu.
Fixes#7273
* web-apps(front): Define theme and typography
In this commit:
* Create a styles folder that contains all sccs files.
* Define the generic theme and typography.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Use the style of the specified body-1 level
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Use the styles of the specified title and headline levels
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Use primary color in snackbar component
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Change back button
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix imports after restructuring
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Add mat-typography class in index.html
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Use the style of the specified title level
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Use primary color
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Fix imports after restructuring
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Add mat-typography class in index.html
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Use the style of the specified title level
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix typo
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Add mat-typography class in index.html
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix imports after restructuring
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Use primary color
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix formatting
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix ui test
Signed-off-by: Elena Zioga <elena@arrikto.com>
---------
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Fix status case
* Fix the status case to properly show the warning icon when the status
phase is warning.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Modify status-icon component
* Modify the status-icon component to follow the status cases.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Modify status component
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Introduce status-info component
* Have an admonition in the details page of each Notebook with a
detailed message on the current status.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(back): Extend process_status function
The process_status parses the status by:
- Checking the .status.containerState.
- Checking the .status.conditions, since they have the one-liner reason
and a message.
- If none of the above exist, it will use the Events emitted for the
notebook.
- In case it deduces the status from an Event and it's not available
anymore, it uses a generic message.
Also, add a 10 second delay to the backend logic where we display a
spinner and a generic message to prevent a warning icon from appearing
immediately after a notebook is initialized.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(back): Extend getNotebook request
* Extend the getNotebook request to also include the processed status
information in the Notebook details page.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Extend the frontend
Extend the frontend by:
- Adding an admonition with a detailed message on the current status
bellow the notebook name.
- Adding the processed_status field.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix unit tests
Fix unit tests accordingly.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa: Don't show the popup when a notebook is being stopped
* Use the waiting status, which also uses the spinner, when a notebook
is being stopped.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Update lib-status-icon
Signed-off-by: Elena Zioga <elena@arrikto.com>
* fixup! jwa(back): Extend getNotebook request
* fixup! jwa(back): Extend process_status function
---------
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix the size input value
The size form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix the access-mode input value
The access mode form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix the name input value
The name form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Use 5Gi everywhere
All new volumes will have a default value of 5Gi. This includes the 'Add
new volume' button for both the workspace and data volumes.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Add UI tests with Cypress
Add integration tests with Cypress to ensure that the form will have the
correct values once it gets the ConfigMap.
Signed-off-by: Elena Zioga <elena@arrikto.com>
---------
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Remove rok references
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(back): Remove rok references
Signed-off-by: Elena Zioga <elena@arrikto.com>
---------
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Introduce MemoryValue class
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Introduce unit tests for the MemoryValue class
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Use MemoryValue class for memory column
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Make quantityToScalar() use only Number()
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Update quantityToScalar() import
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Update quantityToScalar() import
Signed-off-by: Elena Zioga <elena@arrikto.com>
---------
Signed-off-by: Elena Zioga <elena@arrikto.com>
* cdb-angular: Modify README.md port-forward instructions
Add instructions to port-forward Profiles KFAM service.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Modify SnackBar service to use config parameter
Modify SnackBarService to:
- Accept as a parameter a config object that will be able to include
all possible configurations MatSnackBarService
- Inject MAT_SNACK_BAR_DEFAULT_OPTIONS. This allows a structured way
for every WA to provide to the service a default configuration
app-wide for values like like HorizontalPosition and duration.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb(front): Use Kubeflow common library
Build CDB using components from Kubeflow's common libary.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Introduce backend service and ErrorInterceptor
- Introduce backend service to handle requests to the backend
- Use snackBar service by KF common library
- Introduce ErrorInterceptor to hanlde errors in a uniform way.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(back): Remove "kubeflowVersion" from API
Remove the "kubeflowVersion from Workgroup's API "/env-info"
endpoint since it was using CRDs which are deprecated.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(back): Modify KF build version during runtime
By default, the version displayed in the dashboard's sidebar is the
ENV variable `BUILD_VERSION` defined during build time. With this
change, the `/api/workgroup/env-info` endpoint may now return the
build's label, version, and id which will be displayed instead of the
BUILD_VERSION. These values are assigned during runtime and can be
defined through the deployment's `KF_DASHBOARD_BUILD_LABEL`,
`KF_DASHBOARD_VERSION` and `KF_DASHBOARD_BUILD_ID` ENV variables.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* cdb-angular(front): Show KF version in the left sidebar
Show KF version at the bottom of the left sidebar navigation menu.
Variables that are used to show the KF version get their default values
during build time but may be modified during runtime by the
depoloyment's ENV vars fetched from the request at
'/api/workflow/env-info'.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Update the use of SnackBarService
Update the use of SnackBarService in order to pass required data via a
`config` object.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Update the use of SnackBarService
Update the use of SnackBarService in order to pass required data via a
`config` object.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* twa(front): Update the use of SnackBarService
Update the use of SnackBarService in order to pass required data via a
`config` object.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Fix flaky filtering unit test
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
---------
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Fix bug where extracting the ENV vars from PodDefaults for a notebook
would fail when one of the PodDefaults didn't contain any ENV variables.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Import @angular/router package
Import @angular/router package to use routerLink directive.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Introduce LinkValue class
Introduce a distinct class for our external and internal links.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Modify unit tests
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Remove isLink property from PropertyValue class
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Make links actual links
Make JWA's main table links actual links by using the new LinkValue
class.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Make links actual links
Make VWA's main table links actual links by using the new LinkValue
class.
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Add integration tests with Cypress
- Upgrade Cypress to version ^10.10.0
- Add integration tests with Cypress to check that:
* Index page renders every Notebook name into the table
* Index page shows correct Status icon for all notebooks
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* gh-actions(jwa): Add UI tests to JWA's frontend workflow
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* fixup! gh-actions(jwa): Add UI tests to JWA's frontend workflow
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Add missing generateName form control
Add missing generateName form control when creating the metadata
form group from a PVC.
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Update volume's mount path when name changes
Extend VolumeMountComponent class and update volume's mount path
when it is not dirty and name is changed. This feature affects only
the data volumes and not the workspace volume.
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Add UI tests for volume's mount path input
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
* Set REGISTRY prefix when building notebook-server images
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Fix publish workflows for nb-server images when a PR is merged
Whenever a PR is merged:
* Build/Push notebook-server images with TAG=$(shell git describe --tags --always --dirty)
* Build/Push notebook-server images with TAG=latest when the target branch is master
* Build/Push notebook-server images with TAG=$(cat releasing/version/VERSION) when
Version changes
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Update manifests to use latest tag for notebook-server images
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* web-apps(front): Sort tables according to input
Configure tableConfig with new fields (column and order) that the table
will use to sort items during initialization.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Sort conditions table by timestamp
Initialize conditions table sorted by Last Transition Time column, with
the most recent ones being on top.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Sort events by timestamp
Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Sort events by timestamp
Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Fix format errors
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Create lib-urls component
Create a URLs component in Kubeflow common library which takes a
list of URLs and their corresponding name and exposes them
horizontally in a div.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Add unit test for lib-urls
Add a unit test for lib-urls component
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Remove column Volumes from index page
Remove Volumes column from the table in JWA's index page.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Link to a Volume details from JWA details page
- Expose all volumes from a notebook, not only PVCs.
- Expose the volumes grouped by type, having PVCs link to their
corresponding volume details page in VWA, using lib-urls
component.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* vwa(front): Implement lib-urls in VWA details page
Implement lib-urls component in the OVERVIEW tab of VWA's volume
details page to avoid duplicate code.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Use common link styles
Use common link styles in configurations component.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* Fix linting errors
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Fix a bug in the namespace selectors of JWA, VWA and TWA. In order to
show the namespace selector, they only checked if there is no
env.production variable available. This resulted in the selector not
showing even if there was no dashboard which is not expected.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
review changes
* build images with the latest tag only when a PR
is merged to master branch
* revert changes in manifests/workflows for the
notebook-server images
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* jwa(front): Add buttons to Notebook details page
In this commit:
- Add buttons for Connect, Start/Stop, Delete actions.
- Create Actions Service to handle button actions and implement it
in all components that use these buttons.
- Small CSS tweak in title toolbar component in order for
buttons to be aligned horizontally.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Handle query parameters in Notebook page
Add query parameter handling for each tab in order for the user to
be able to navigate directly to the tab of choice inside the
Notebook details page.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* web-apps(front): Add default values in lib-conditions-table fields
Add default values for lastTransitionTime, reason & message fields
in order to prevent the table's Sorting functionality returning
error due to null values.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Add unit tests for notebook-page component
In this commit, add unit tests in order to:
- Show only the proper tab according to query parameters passed.
- Switch tabs according to query parameters passed.
- Update disabled field of buttons according to notebook status.
- Update start/stop button according to notebook status.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Add unit tests for OVERVIEW tab component
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* jwa(front): Fix panel.ts file
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Modify form name component
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Add a helper tooltip in section component
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Rework the Create page
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix linting errors
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow for JWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* twa: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow for TWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* vwa: Extend tests for using images of each PR
Changes:
* Introduce intergration test workflow for VWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
- This change is required as images with tag v1.5.0 do not
exist in "docker.io/kubeflownotebookswg" registry.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* jwa(front): Add source maps in the browser
* Enable source maps in both development and production.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Add source maps in the browser
* Enable source maps in both development and production.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Add source maps in the browser
* Enable source maps in both development and production.
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Rename form-default component
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Create missing module files
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Remove form-rok and form components
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Update JWA's @angular/common package
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Modify rok-url component
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Add Rok URL message
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Update VWA's @angular/common package
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Remove the headers request
Remove the headers request since the common code implements it.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix JWA's unit tests
Fix JWA's unit tests.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* gh-actions: Add GH action to run JWA unit tests
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(build): Update Dockerfile
Update Dockerfile to not build Rok.
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
Eder Ignatowicz