Commit Graph

139 Commits

Author SHA1 Message Date
Tobias Goerke 0e787960f5 fix: local var shadowing import (kubeflow/kubeflow#7375)
resolves #7373
2023-10-23 18:05:08 +00:00
Tobias Goerke 7286a41656 fix: KeyError on KF 1.8 (kubeflow/kubeflow#7335)
This change fixes an error 500 on notebook creation
2023-10-13 08:45:52 +00:00
Daniela Plascencia b38794b7c6 fix: set default GPU vendors list (kubeflow/kubeflow#7320)
The change introduced by kubeflow/kubeflow#6736 removed the default GPU vendors
list, which causes an issue when trying to select a vendor from the dropdown menu
if the vendors list is not configured.
This commit can be reverted if proper documentation is provided for users/distributions
to configure the dropdown menu.
Fixes #7273
2023-10-09 08:28:18 +00:00
Kimonas Sotirchos b9ff781a21 ci: Build ARM images for core components (kubeflow/kubeflow#7220)
* ci: Build ARM images for core components

Extend the GH Actions to also build the images on ARM architectures.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* crud-web-apps: Update python and gevent versions

In order to successfully build on linux/arm64/v8 we'll need to:
* Update to Python 3.10
* Bump the gevent version

https://github.com/gevent/gevent/issues/1721#issuecomment-1223751954

* Update the workflows for JWA

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for centraldb

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for kfam

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for notebook-controller

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for PodDefaults

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for Profile Controller

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for pvcviewer controller

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for TensorBoard Controller

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for TWA

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update workflows for VWA

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

* Update releasing script to include PVCViewers

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>

---------

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
2023-10-04 22:17:15 +00:00
boarder7395 5213455aa3 Only load spawner_ui_config.yaml once every 10 minutes. closes #7259 (kubeflow/kubeflow#7260)
* Only load spawner_ui_config.yaml once every 10 minutes.

* Update cache to 60 seconds
2023-10-04 16:24:16 +00:00
Elena Zioga 95bbbf07da [wa-theme-typography]: Define theme and typography (kubeflow/kubeflow#7062)
* web-apps(front): Define theme and typography

In this commit:
* Create a styles folder that contains all sccs files.
* Define the generic theme and typography.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Use the style of the specified body-1 level

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Use the styles of the specified title and headline levels

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Use primary color in snackbar component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Change back button

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix imports after restructuring

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Add mat-typography class in index.html

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Use the style of the specified title level

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Use primary color

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Fix imports after restructuring

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Add mat-typography class in index.html

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Use the style of the specified title level

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix typo

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Add mat-typography class in index.html

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix imports after restructuring

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Use primary color

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix formatting

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix ui test

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-07-31 16:47:29 +00:00
axel7083 310d4a0c10 feature(notebook): Adding creator user-id to annotation (kubeflow/kubeflow#7198)
* Adding creator annotation to notebooks

* Adding missing html

* Fixing linter issue

* Fixing prettier

* Adding condition for displaying creator (backward compatibility)
2023-07-31 16:37:29 +00:00
dependabot[bot] 095d47ac53 build(deps): bump socket.io-parser from 4.2.1 to 4.2.3 in /components/crud-web-apps/jupyter/frontend (kubeflow/kubeflow#7145)
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.1 to 4.2.3.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io-parser/compare/4.2.1...4.2.3)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-13 18:14:03 +00:00
Kimonas Sotirchos 0dc4261955 Fix Python linting (kubeflow/kubeflow#7060)
* gh-action: Workflow for testing python lint

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* lint: Run autopep8 to lint files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* linting: Manual changes

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

---------

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2023-03-30 09:32:05 +00:00
Elena Zioga c0f00e836b jwa: Improve how JWA exposes errors (kubeflow/kubeflow#6952)
* web-apps(front): Fix status case

* Fix the status case to properly show the warning icon when the status
  phase is warning.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify status-icon component

* Modify the status-icon component to follow the status cases.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify status component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce status-info component

* Have an admonition in the details page of each Notebook with a
  detailed message on the current status.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Extend process_status function

The process_status parses the status by:
- Checking the .status.containerState.
- Checking the .status.conditions, since they have the one-liner reason
  and a message.
- If none of the above exist, it will use the Events emitted for the
  notebook.
- In case it deduces the status from an Event and it's not available
  anymore, it uses a generic message.

Also, add a 10 second delay to the backend logic where we display a
spinner and a generic message to prevent a warning icon from appearing
immediately after a notebook is initialized.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Extend getNotebook request

* Extend the getNotebook request to also include the processed status
  information in the Notebook details page.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Extend the frontend

Extend the frontend by:
- Adding an admonition with a detailed message on the current status
  bellow the notebook name.
- Adding the processed_status field.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix unit tests

Fix unit tests accordingly.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa: Don't show the popup when a notebook is being stopped

* Use the waiting status, which also uses the spinner, when a notebook
  is being stopped.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update lib-status-icon

Signed-off-by: Elena Zioga <elena@arrikto.com>

* fixup! jwa(back): Extend getNotebook request

* fixup! jwa(back): Extend process_status function

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-23 15:23:22 +00:00
Elena Zioga 8af965fb9b jwa(front): Fix the workspace volume form's inputs (kubeflow/kubeflow#7029)
* jwa(front): Fix the size input value

The size form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix the access-mode input value

The access mode form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix the name input value

The name form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Use 5Gi everywhere

All new volumes will have a default value of 5Gi. This includes the 'Add
new volume' button for both the workspace and data volumes.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Add UI tests with Cypress

Add integration tests with Cypress to ensure that the form will have the
correct values once it gets the ConfigMap.

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-22 13:57:43 +00:00
amitmukati-2604 07a01a3861 Adding changes to build JWA on pull_request (kubeflow/kubeflow#6992)
* Adding changes to build JWA on pull_request

* Adding changes to build JWA on pull_request
2023-03-21 11:05:41 +00:00
Midhun Nair 78e067e594 Fix: Strip unwanted space in custom image name (kubeflow/kubeflow#7026) 2023-03-14 15:40:25 +00:00
Mathew Wicks e3725c98d8 clean up default `spawner_ui_config.yaml` (kubeflow/kubeflow#6736) 2023-03-08 07:45:12 +00:00
Elena Zioga 40cd9ad78e web-apps(front): Fix typos (kubeflow/kubeflow#7017)
* jwa(front): Fix typo

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix typos

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-06 17:58:36 +00:00
Elena Zioga 85f262abb9 jwa: Remove all the Rok references (kubeflow/kubeflow#6985)
* jwa(front): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-06 10:06:35 +00:00
Elena Zioga f465180f05 jwa(front): JWA shows a weird long value for memory when restoring notebook from snapshot (kubeflow/kubeflow#6897)
* web-apps(front): Introduce MemoryValue class

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce unit tests for the MemoryValue class

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Use MemoryValue class for memory column

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Make quantityToScalar() use only Number()

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Update quantityToScalar() import

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update quantityToScalar() import

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-02-24 12:33:24 +00:00
dependabot[bot] c1df60efda build(deps): bump json5 from 1.0.1 to 1.0.2 in /components/crud-web-apps/jupyter/frontend (kubeflow/kubeflow#6880)
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-16 13:38:06 +00:00
Kimonas Sotirchos a99af12eea Add approvers to the frontends (kubeflow/kubeflow#6929)
* Add approvers to the frontends

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Add owners to common frontend code

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

---------

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2023-02-13 17:23:24 +00:00
Orfeas Kourkakis b5e0deec09 cdb-angular: Show KF version (kubeflow/kubeflow#6918)
* cdb-angular: Modify README.md port-forward instructions

Add instructions to port-forward Profiles KFAM service.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Modify SnackBar service to use config parameter

Modify SnackBarService to:

 - Accept as a parameter a config object that will be able to include
   all possible configurations MatSnackBarService
 - Inject MAT_SNACK_BAR_DEFAULT_OPTIONS. This allows a structured way
   for every WA to provide to the service a default configuration
   app-wide for values like like HorizontalPosition and duration.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb(front): Use Kubeflow common library

Build CDB using components from Kubeflow's common libary.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Introduce backend service and ErrorInterceptor

 - Introduce backend service to handle requests to the backend
 - Use snackBar service by KF common library
 - Introduce ErrorInterceptor to hanlde errors in a uniform way.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(back): Remove "kubeflowVersion" from API

Remove the "kubeflowVersion from Workgroup's API "/env-info"
endpoint since it was using CRDs which are deprecated.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(back): Modify KF build version during runtime

By default, the version displayed in the dashboard's sidebar is the
ENV variable `BUILD_VERSION` defined during build time. With this
change, the `/api/workgroup/env-info` endpoint may now return the
build's label, version, and id which will be displayed instead of the
BUILD_VERSION. These values are assigned during runtime and can be
defined through the deployment's `KF_DASHBOARD_BUILD_LABEL`,
`KF_DASHBOARD_VERSION` and `KF_DASHBOARD_BUILD_ID` ENV variables.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Show KF version in the left sidebar

Show KF version at the bottom of the left sidebar navigation menu.
Variables that are used to show the KF version get their default values
during build time but may be modified during runtime by the
depoloyment's ENV vars fetched from the request at
'/api/workflow/env-info'.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Update the use of SnackBarService

Update the use of SnackBarService in order to pass required data via a
`config` object.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Update the use of SnackBarService

Update the use of SnackBarService in order to pass required data via a
`config` object.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* twa(front): Update the use of SnackBarService

Update the use of SnackBarService in order to pass required data via a
`config` object.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Fix flaky filtering unit test

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

---------

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-02-13 16:16:25 +00:00
Orfeas Kourkakis c75943512f jwa(front): Fix ENV vars bug in details page (kubeflow/kubeflow#6903)
Fix bug where extracting the ENV vars from PodDefaults for a notebook
would fail when one of the PodDefaults didn't contain any ENV variables.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-25 17:44:52 +00:00
Elena Zioga 89d4f97303 [wa-actual-links-in-tables] Make links in our table component actual links (kubeflow/kubeflow#6864)
* web-apps(front): Import @angular/router package

Import @angular/router package to use routerLink directive.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce LinkValue class

Introduce a distinct class for our external and internal links.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Remove isLink property from PropertyValue class

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Make links actual links

Make JWA's main table links actual links by using the new LinkValue
class.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Make links actual links

Make VWA's main table links actual links by using the new LinkValue
class.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-01-18 14:19:21 +00:00
Orfeas Kourkakis c7e03bbaba jwa(front): Add UI tests with Cypress (kubeflow/kubeflow#6891)
* jwa(front): Add integration tests with Cypress

 - Upgrade Cypress to version ^10.10.0
 - Add integration tests with Cypress to check that:
   * Index page renders every Notebook name into the table
   * Index page shows correct Status icon for all notebooks

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(jwa): Add UI tests to JWA's frontend workflow

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* fixup! gh-actions(jwa): Add UI tests to JWA's frontend workflow

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-16 11:03:00 +00:00
Tasos Alexiou a14539b57c jwa(front): Auto update mount path (kubeflow/kubeflow#6875)
* jwa(front): Add missing generateName form control

Add missing generateName form control when creating the metadata
form group from a PVC.

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Update volume's mount path when name changes

Extend VolumeMountComponent class and update volume's mount path
when it is not dirty and name is changed. This feature affects only
the data volumes and not the workspace volume.

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Add UI tests for volume's mount path input

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
2023-01-11 14:38:16 +00:00
apoger 8f1a9df4a8 Fix Makefiles/Workflows/Manifests for the example-notebook-server images (kubeflow/kubeflow#6860)
* Set REGISTRY prefix when building notebook-server images

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Fix publish workflows for nb-server images when a PR is merged

Whenever a PR is merged:

* Build/Push notebook-server images with TAG=$(shell git describe --tags --always --dirty)

* Build/Push notebook-server images with TAG=latest when the target branch is master

* Build/Push notebook-server images with TAG=$(cat releasing/version/VERSION) when
  Version changes

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Update manifests to use latest tag for notebook-server images

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-21 07:43:12 +00:00
Orfeas Kourkakis 3dec176271 web-apps(front): Sort events & conditions tables by date (kubeflow/kubeflow#6858)
* web-apps(front): Sort tables according to input

Configure tableConfig with new fields (column and order) that the table
will use to sort items during initialization.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Sort conditions table by timestamp

Initialize conditions table sorted by Last Transition Time column, with
the most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Sort events by timestamp

Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Sort events by timestamp

Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix format errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:50:19 +00:00
Orfeas Kourkakis d5216c7d2a jwa(front): Link to VWA details page (kubeflow/kubeflow#6857)
* web-apps(front): Create lib-urls component

Create a URLs component in Kubeflow common library which takes a
list of URLs and their corresponding name and exposes them
horizontally in a div.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Add unit test for lib-urls

Add a unit test for lib-urls component

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Remove column Volumes from index page

Remove Volumes column from the table in JWA's index page.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Link to a Volume details from JWA details page

 - Expose all volumes from a notebook, not only PVCs.
 - Expose the volumes grouped by type, having PVCs link to their
   corresponding volume details page in VWA, using lib-urls
   component.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Implement lib-urls in VWA details page

Implement lib-urls component in the OVERVIEW tab of VWA's volume
details page to avoid duplicate code.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Use common link styles

Use common link styles in configurations component.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* Fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:49:18 +00:00
Orfeas Kourkakis cfe32e59c2 web-apps(front): Fix namespace selector bug (kubeflow/kubeflow#6845)
Fix a bug in the namespace selectors of JWA, VWA and TWA. In order to
show the namespace selector, they only checked if there is no
env.production variable available. This resulted in the selector not
showing even if there was no dashboard which is not expected.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:47:18 +00:00
apoger 6b3fd05ea2 Update KF manifests and gh-action workflows to use the tag=`latest` (kubeflow/kubeflow#6854)
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

review changes

* build images with the latest tag only when a PR
  is merged to master branch

* revert changes  in manifests/workflows for the
  notebook-server images

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-20 15:59:18 +00:00
Orfeas Kourkakis afed933c2c jwa(front): Add details page functionalities & unit tests (kubeflow/kubeflow#6822)
* jwa(front): Add buttons to Notebook details page

In this commit:

 - Add buttons for Connect, Start/Stop, Delete actions.
 - Create Actions Service to handle button actions and implement it
   in all components that use these buttons.
 - Small CSS tweak in title toolbar component in order for
   buttons to be aligned horizontally.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Handle query parameters in Notebook page

Add query parameter handling for each tab in order for the user to
be able to navigate directly to the tab of choice inside the
Notebook details page.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Add default values in lib-conditions-table fields

Add default values for lastTransitionTime, reason & message fields
in order to prevent the table's Sorting functionality returning
error due to null values.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Add unit tests for notebook-page component

In this commit, add unit tests in order to:
 - Show only the proper tab according to query parameters passed.
 - Switch tabs according to query parameters passed.
 - Update disabled field of buttons according to notebook status.
 - Update start/stop button according to notebook status.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Add unit tests for OVERVIEW tab component

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-15 11:54:21 +00:00
apoger 54ab6a815e Fix workflows for publishing images only when PR is merged (kubeflow/kubeflow#6842)
* Fix docker-publish workflows

* Remove workflow that builds/push all images

* Remove redundant files from manifests
2022-12-15 09:51:21 +00:00
Elena Zioga 0cb36aedf4 jwa(front): Rework the create page (kubeflow/kubeflow#6826)
* jwa(front): Fix panel.ts file

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify form name component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add a helper tooltip in section component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Rework the Create page

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix linting errors

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-15 09:06:22 +00:00
apoger e327bfc8d7 crud-web-apps: Extend tests for using images of each PR (kubeflow/kubeflow#6832)
* jwa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for JWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* twa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for TWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* vwa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for VWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-12 12:23:27 +00:00
Elena Zioga dd0a681457 web-apps(front): Enable source maps in WAs (kubeflow/kubeflow#6787)
* jwa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-09 14:12:11 +00:00
apoger 10e0e93085 Cherry-pick commits for using DockerHub for all images (kubeflow/kubeflow#6825)
cherry-picking: #6548
* Update all images to use DockerHub
* Update releasing script for dockerhub

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Cherry-picked-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Co-authored-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2022-12-08 15:37:10 +00:00
amitmukati-2604 ae4fc7b0c0 Adding support for linux/ppc64le in CI for jupyter-web-app multi-arch… (kubeflow/kubeflow#6800) 2022-12-08 13:09:10 +00:00
Elena Zioga cca60b7d26 jwa(front): Fix unit tests (kubeflow/kubeflow#6804)
* jwa(front): Rename form-default component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Create missing module files

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Remove form-rok and form components

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Update JWA's @angular/common package

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify rok-url component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add Rok URL message

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update VWA's @angular/common package

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Remove the headers request

Remove the headers request since the common code implements it.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix JWA's unit tests

Fix JWA's unit tests.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* gh-actions: Add GH action to run JWA unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(build): Update Dockerfile

Update Dockerfile to not build Rok.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-07 12:49:38 +00:00
Orfeas Kourkakis 750178e2ae jwa(front): Add YAML tab to Notebook details page (kubeflow/kubeflow#6790)
Add tab to show the full YAML both from the Notebook and from its
underlying pod, when there is one.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-05 10:28:08 +00:00
Orfeas Kourkakis 2a2ad29745 jwa: Add EVENTS tab to Notebook details page (kubeflow/kubeflow#6782)
* jwa(back): Get a notebook's events

 - Add logic in the backend to fetch the events of a notebook.
 - Fix the authorization parameters in the get_notebook_events
   function.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Add EVENTS tab to Notebook details page

Add Events tab to show the available events of the notebook in the
form of a table, in order to help a user with debugging the
notebook.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-01 16:25:45 +00:00
Orfeas Kourkakis 03c240a5d5 jwa(front): Add LOGS tab to the notebook details page (kubeflow/kubeflow#6779)
* jwa(back): Get a notebook's logs

Add logic in the backend to fetch the logs of a notebook's
underlying pod.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Add LOGS tab to Notebook details page

 - Create Logs tab to show the logs of the notebook's underlying
   pod.
 - Create Logs Viewer component in Kubeflow common library exactly
   like the one we have in MWA.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-11-29 15:28:42 +00:00
Orfeas Kourkakis 7c9be4729a jwa: Update manifests to access Pods and Pods/log (kubeflow/kubeflow#6780)
As part of the effort for the new Notebook details page in JWA, update
the manifests for jwa's cluster role in order to list resources pods and
get pods/log.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-11-29 13:36:44 +00:00
Kimonas Sotirchos 485550635b web-apps: Add support for all-namespaces in the Volumes and TensorBoards web apps (kubeflow/kubeflow#6778)
* vwa(front): Support all-namespaces

The VWA will now be able to work with the "All namespaces" option of
the CentralDashboard.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): Support all-namespaces

The TWA will now be able to work with the "All namespaces" option of
the CentralDashboard.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* wa(front): Add cypress attributes

Add more attributes for elements to be selectable when running e2e
tests.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(e2e): Add e2e tests for all-namespaces

Add a new e2e test that checks if the Namespaces column is shown
when selecting all-namespaces.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* dashboard: Allow all-namespaces for vwa/twa

The dashboard will be allowing the VWA and TWA to work with
all-namespaces, now that we added this functionality.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2022-11-29 10:56:43 +00:00
Orfeas Kourkakis 54f4cee3b2 jwa(front): Create distinct notebook details page (kubeflow/kubeflow#6769)
* jwa(back): Get a single notebook and its pod

In this commit:

 - Add logic in the backend to fetch a single notebook and its
   underlying pod.
 - Make list_pods function in Kubeflow common code to accept a
   label_selector parameter and use it to filter out results when
   available.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Create Notebook details page with OVERVIEW tab

In this commit:

 - Create OVERVIEW tab to show key information about the notebook
   and its underlying pod.
 - Create Content List Item component in Kubeflow commonn library to
   be able to encapsulate any content/component in the form of a
   list item.
 - Create Variables Group component in Kubeflow common library to
   show groups of variables in the form of chips.
 - Small UI tweak in Details list Item component from Kubeflow
   common library in order to stop chips from overlapping with each
   other.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* Fix linting errors

* Include Kubeflow common library's new package-lock.json

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Replace pod conditions with notebook status conditions

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(back): Backend fetch pods fix

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-11-29 08:17:42 +00:00
dependabot[bot] f0d9b37e14 build(deps): bump loader-utils from 1.4.1 to 1.4.2 in /components/crud-web-apps/jupyter/frontend (kubeflow/kubeflow#6748)
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md)
- [Commits](https://github.com/webpack/loader-utils/compare/v1.4.1...v1.4.2)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-28 18:02:16 +00:00
dependabot[bot] c7c1b85944 build(deps): bump engine.io and socket.io in /components/crud-web-apps/jupyter/frontend (kubeflow/kubeflow#6759)
Bumps [engine.io](https://github.com/socketio/engine.io) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together.

Updates `engine.io` from 6.1.3 to 6.2.1
- [Release notes](https://github.com/socketio/engine.io/releases)
- [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/engine.io/compare/6.1.3...6.2.1)

Updates `socket.io` from 4.4.1 to 4.5.3
- [Release notes](https://github.com/socketio/socket.io/releases)
- [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io/compare/4.4.1...4.5.3)

---
updated-dependencies:
- dependency-name: engine.io
  dependency-type: indirect
- dependency-name: socket.io
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-28 11:13:14 +00:00
Orfeas Kourkakis 878eb35e0f jwa(front): Use new Editor component (kubeflow/kubeflow#6775)
Import new Editor component from Kubeflow Common Library and replace
all instances of previous Ace Editor.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-11-28 10:23:14 +00:00
Mathew Wicks 7f1d338ab6 fix setting readOnly on gpus (kubeflow/kubeflow#6735) 2022-11-24 12:34:10 +00:00
apoger 46f14d4e97 Use K8s 1.25 for the tests (kubeflow/kubeflow#6751)
* kind: Introduce config file for 1.25

* Add a new KinD configuration file for testing with K8s 1.25.3
* Install kind v0.17.0 for testing with K8s 1.25.3

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* gh-actions: Use 1.25 for testing

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* testing: Install Istio 1.16 for testing

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Test commit for enabling the tests

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* notebook-controller: Fix Makefile

Remove the test rule as a prerequisite for running docker-build

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-11-24 08:30:10 +00:00
Elena Zioga 9fa3fde87e Upgrade @angular/material in WAs (kubeflow/kubeflow#6763)
* jwa(front): Upgrade @angular/material package (kubeflow/kubeflow#6462)

* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Upgrade @angular/material package (kubeflow/kubeflow#6462)

* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Upgrade @angular/material package (kubeflow/kubeflow#6462)

* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-11-23 15:06:43 +00:00
Elena Zioga 955fb6b19b Filtering support for the web apps (kubeflow/kubeflow#6754)
* web-apps(front): Add filtering functionality in WAs (kubeflow/kubeflow#6462)

* Add filtering functionality in the common table component.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Differentiate type property (kubeflow/kubeflow#6462)

* Differentiate type property from other ComponentValue properties.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-11-23 13:44:43 +00:00