0dc4261955
Fix Python linting ( kubeflow/kubeflow#7060 )
...
* gh-action: Workflow for testing python lint
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* lint: Run autopep8 to lint files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* linting: Manual changes
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
---------
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2023-03-30 09:32:05 +00:00
6bcb843d8f
Support Pod Defaults in Tensorboard Web App ( kubeflow/kubeflow#6924 )
...
* support Pod Defaults in Tensorboard Web App
* flint files
2023-02-13 16:31:24 +00:00
e9b1bfca5c
fix(web-apps): Use Angular's i18n proposed implementation ( kubeflow/kubeflow#6065 )
...
* jwa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormImage
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormAdvancedOptions
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormAffinityTolerations
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormConfigurations
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormCpuRam
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormDataVolumes
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormGpus
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FromName
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormWorkspaceVolume
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Volume
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Add localize to peerDependencies
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Import $localize in library
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n RokService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n ConfirmDialog
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n ResourceTable
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n SnackBar
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-app(front): i18n NameNamespaceSelector
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Remove ngx-translate
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(back): Don't parse keys in status
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(back): Revert backend messages
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(back): Don't parse keys in status
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(back): Revert backend messages
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* wa: Update READMEs
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Add localize when testing
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-08-12 05:13:03 -07:00
941ec2e9ff
Update CRUD web apps from Angular 8 to Angular 12 ( kubeflow/kubeflow#6004 )
...
* common: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* common: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* common: remove entryComponents and replace TestBed.get with TestBed.inject
Edit files manually
* common: make compatible with Angular 9
Edit files manually
* common: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* update kubeflow-common project dependencies
* common: add @angular/localize
ng add @angular/localize
* jupyter: update angular core and cli 8
ng update @angular/core@8 @angular/cli@8
* jupyter: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* jupyter: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* jupyter: remove entryComponents
Edit file manually
* jupyter: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* jupyter: add @angular/localize
ng add @angular/localize
* tensorboards: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* tensorboards: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* tensorboards: remove entryComponents and replace TestBed.get with TestBed.inje…
Edit files manually
* tensorboards: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* tensorboards: add @angular/localize
ng add @angular/localize
* Fix tensorboards-web-app run-dev in makefile
Edit file manually
* volumes: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* volumes: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* volumes: remove entryComponents and replace TestBed.get with TestBe…
Edit files manually
* volumes: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* volumes: add @angular/localize
ng add @angular/localize
* common: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10 --force
* common: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* update kubeflow-common project dependencies
Edit file manually
* common: update fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* common: fix font location
Edit file manually
* jupyter: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* jupyter: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* jupyter: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* tensorboards: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* tensorboards: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* tensorboards: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* volumes: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* volumes: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* volumes: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* common: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* common: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* common: install @angular-devkit/core@11
npm install --save-dev @angular-devkit/core@11
* common: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* common: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* update kubeflow-common project dependencies
Edit file manually
* jupyter: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* jupyter: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* jupyter: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* jupyter: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* tensorboards: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* tensorboards: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* tensorboards: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* tensorboards: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* volumes: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* volumes: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* volumes: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* volumes: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* common: Fix CI failure
* jupyter: npm run format:write
npm run format:write
* volumes: npm run format:write
npm run format:write
* tensorboards: manually run prettier
prettier --write 'src/**/*.{js,ts,html,scss,css}'
* common: Fix MockComponent entryComponents for CI
Manually edit file
* common: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* common: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* common: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* update kubeflow-common project dependencies
Edit file manually
* common: fix Intl.DateTimeFormatOptions
Edit file manually. Type of defaultDateOptions and defaultTimeOptions needs to explicitly be set to Intl.DateTimeFormatOptions.
* jupyter: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* jupyter: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* jupyter: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* jupyter: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* tensorboards: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* tensorboards: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* tensorboards: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* volumes: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* volumes: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* volumes: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* common: update and audit packages
npm update && npm audit fix && npm i lodash-es@4.17.21 && npm i material-icons@0.7.3
* jupyter: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* tensorboards: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* volumes: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* jupyter: npm run format:write
npm run format:write
2021-07-21 02:35:50 -07:00
9f0334174c
CRUD web apps: i18n ( kubeflow/kubeflow#5880 )
...
* feat(jupyter): add modules for translations
* feat(jupyter): fix path for translations + add GPU translations
* feat(jupyter): add translations
* feat(jupyter): add translations to form-default
* feat(jupyter): add translations to affinity/tolerations
* feat(jupyter): add translations to Image Pull Policy
* feat(jupyter): remove imports from app.module.ts + fix translations
* web-apps(front): add TranslationModule to common for jupyter
* Implement i18n for jupyter frontend
- Including common components needed
- Refactor translation file
* web-apps(front): add i18n to messages from backend
Status tooltip text
Snackbar message
* web-apps(front): volumes and tensorboards i18n ini
Add the i18n feature for the other 2 projects
* feat(volume): add translations for volume
* feat(jupyter): refactor asset file
* Update asset files for all folders
* feat(tensorboards): add i18n
Update all asset files
* cwa: add new translations
* cwa: Add README documentation
* fix: formatting with prettier
* Fix tests
* Fix python format
* remove comment
Co-authored-by: saffaalvi <alvi118@uwindsor.ca>
Co-authored-by: Jose-Matsuda <tongster789@gmail.com>
2021-06-21 07:26:17 -07:00
facf6073e5
web-apps: Introduce an APP_SECURE_COOKIES env var ( kubeflow/kubeflow#5764 )
...
* web-apps(back): Introduce APP_SECURE_COOKIES var
Expose a new APP_SECURE_COOKIES env variable that will configure whether
the web apps should set Secure cookies or not.
This will allow the admins to configure the web apps to work when
Kubeflow is exposed over localhost/http.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(back): Switch CSRF checks order
The order the backend makes the CSRF checks should be the following:
1. check if the CSRF cookie is present
2. check if the CSRF header is present
3. check if the CSRF cookie and header have the same value
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps: Set APP_SECURE_COOKIES to false in dev
When running the web apps via the makefiles in dev mode we will need to
explicitly set the APP_SECURE_COOKIES env var to False, since the app
will be served over http.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-03-24 05:16:45 -07:00
ebbd123359
Fixes in Tensorboard web app ( kubeflow/kubeflow#5693 )
...
* twa(front): Use correct base-href when building
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(backend): Fix regex for parsing prefix
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa: Add git tag while building the image
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa: Fix dockerfile for buster-slim image
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa: Use common date-time component to show date
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(back): Fetch the name directly from the CR
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* review: Remove unused npm script
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa: Don't override the app's config
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa: Use correct AWS image in Makefile
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* review: Use bash in Dockerfile entrypoint
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-03-18 12:26:16 -07:00
315e973ea4
twa: Update the build process and instructions for the Tensorboards web app ( kubeflow/kubeflow#5498 )
...
* web-apps(back): Helper config functions
Introduce helper function for creating the config object for an app.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa: Update the build process
Update both the frontend and the backend of the Tensorboards web app to
follow the build/run process of the other web apps as well.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa: Update the README
Restructure the README to look like the JWA one. Also update the
instructions with the latest process for running the web app.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2021-01-08 05:04:54 -08:00
e32222032c
Tensorboard web-app: Add functionality to inform TWA frontend about the status of Tensorboard servers ( kubeflow/kubeflow#5259 )
...
* Extend Tensorboard CRD with status.readyReplicas field
The Tensorboard CRD didn't contain any information about the
Tensorboard server being ready or not. So, the status of the
Tensorboard resource is extended so that it contains a
readyReplicas field, similar to the status.readyReplicas of
the deployment of the Tensorboard server.
* Extend Tensorboard controller to update status of Tensorboard CR
The frontend of the Tensorboard web-app will need information
about whether the Tensorboard servers are ready to connect or not.
As a result, the Tensorboard controller now copies the value of the
status.readyReplicas field of the Tensorboard deployment to the
status.readyReplicas of the Tensorboard CR.
Also, a Deployment() function was added for applying and updating
Tensorboard server deployments.
* Update tensorboard.status.phase of TWA backend response
The frontend of the TWA will need information about the status
of the Tensorboard server, so that it can inform the user about
the server being ready being ready to connect or not.
As a result, the backend sets the status.phase field of the response
to "ready", if tensorboard.status.readyReplicas == 1. Otherwise, the
status.phase field of the response is set to "unavailable".
Also, the getPVCName() function was added, which extracts the name
of a given PVC object.
* Add GET route for PVCs
The Tensorboard web-app frontend will be using an autocomplete
drop-bar to show user the PVCs that live in a specific namespace.
These PVCs could be used as log storages for the Tensorboard server.
So, a PVC GET route was added to the Tensorboard web-app backend.
* Add message to Tensorboard response object in TWA backend
The frontend of the TWA will need to output a response message for
every Tensorboard object. This response message will inform the
user about the current state of the Tensorboard server.
* Use status.STATUS_PHASE for backend response
* Add requirements.txt to TWA backend
* Use status.create_status() for backend response
2020-08-30 05:08:20 -07:00
f55c0d77dc
tensorboard web-app: Create Tensorboard web-app backend ( kubeflow/kubeflow#5180 )
...
* Create Tensorboard web-app backend
Create the code for the Tensorboard web-app backend which
includes routes for GET, POST and DELETE requests.
The backend is created with Python/Flask, so it also uses
the common code from 'kubeflow.kubeflow.crud_backend'.
* Add 'get_age(k8s_object)' function to 'crud_backend' common code
It would be useful for all web apps of the 'crud-web-apps' folder
to return age information to their frontends.
As a result, 'get_age(k8s_object)' was added to the common code,
so that all web apps can use it.
2020-08-20 03:25:22 -07:00
Kimonas Sotirchos
Suraj Kota
David van der Spek
Wendy Gaultier
Konstantinos Andriopoulos