Commit Graph

5 Commits

Author SHA1 Message Date
noa limoy fb652afae0 feat: migrate PVCViewer Controller CI workflows to notebooks repo
- Add integration test workflow with Kind cluster setup
- Add multi-arch build test for AMD64, ARM64, PPC64LE platforms
- Add unit test workflow with Go test coverage
- Include testing infrastructure scripts for cert-manager and Istio

This migration enables unified CI/CD for PVCViewer Controller within the notebooks repository structure.

Signed-off-by: noa limoy <nlimoy@redhat.com>
2025-09-18 15:20:58 +03:00
Tobias Goerke fd9c880e1d chore: update pvcviewer dependencies (kubeflow/kubeflow#7561)
* build(deps): bump golang.org/x/net in /components/pvcviewer-controller

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0.
- [Commits](https://github.com/golang/net/compare/v0.17.0...v0.23.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: update controller-gen to v0.14.0

Signed-off-by: Tobias Goerke <tobias.goerke@gmail.com>

* chore: update go version and dependencies

Signed-off-by: Tobias Goerke <tobias.goerke@gmail.com>

* chore: update GitHub actions go version

Signed-off-by: Tobias Goerke <tobias.goerke@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Tobias Goerke <tobias.goerke@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-21 17:21:24 +00:00
Tobias Goerke 8a4d0efe6e feat: make pvcviewer istio gateway configurable (kubeflow/kubeflow#7351) 2023-10-19 00:31:56 +00:00
Tobias Goerke e462c28b64 fix: pvcviewer tests (kubeflow/kubeflow#7292)
Changes filepaths on master caused the download of CRDs to fail.
Instead, we now add the CRDs statically, to prevent issues like these.

See for more info:
https://github.com/kubeflow/kubeflow/pull/7286#issuecomment-1728151521
2023-09-21 09:04:37 +00:00
Tobias Goerke 797c9d0486 Re-Introducing the Volumes Viewer (kubeflow/kubeflow#6876)
* Integrating volumes viewer into volumes ui backend

* Integrating volumes viewer into volumes ui frontend

* Modified the volume viewer's manifests to be in accordance with the volumes viewer changes

* Bootstrapping/creating VolumesViewer Controller

* Changed/reverted image definitions

* Fixed code style issues

* Run prettier on index-default.component.ts

* Reverted accidental method call change back to getSelectedNamespace2

* Reverted package-lock.json

* Now using the VOLUME_VIEWER_IMAGE env variable in the viewer's podTemplate

* Set readinessProbe.initialDelaySeconds=2 for new viewers

* Removed downward api references in favor of Python variable expansion

* Revised crd schema

- Now includes a status.URL field
- Reverted changes to status.py to minimize diff

* Providing NAME as a possible var for var expansion

* Return and use the VolumesViewer.Status.URL

* Reconcile status while deletion ongoing

* Restored empty line to get file off diff

* Reducing diff on get.py

* Run prettier

* Updated OWNERS/README

* Changes to schema comments / renaming

* Improved test performance and reliability
By cleaning up resources created by tests in afterEach()
Also: Pod watch now only triggers for non-terminating RUNNING/PENDING pods, reducing the number of reconciliation calls

* Renaming VolumesViewer -> PVCViewer as discussed in community meeting

* Moving changes to volumes frontend to another PR as discussed in community meeting

* Renaming file names

* Renaming PVCViewerSpec.PodTemplate -> PodSpec

* Renaming PVCViewerSpec.Service -> Networking

* Adding the Spec.PVC field and validating/defaulting webhooks

* Adding the option to load a default podSpec from file

* Introduced PVCViewer.Status.Conditions

* Validator requires the PVC to be used in podSpec

* Added tests for the validating webhook

* Removed debug log message

* Updating manifests to work with new webhooks

* Updating documentation

* Refactored manager according to specs

* Modifying pvcviewer OWNERS

* Makefile & renaming comp -> pvcviewer-controller

* Changing nameprefix to pvcviewer-

* Setting imagePullPolicy: IfNotPresent

* Adding a base directory

* Generating TLS certs for make run

* Adding a log time encoder
2023-06-14 07:33:34 +00:00